X-Git-Url: https://git.ucc.asn.au/?a=blobdiff_plain;ds=inline;f=Kernel%2Fvfs%2Fopen.c;h=d203571327283e6d271fc5128ccc8ebf881fca97;hb=077a1c5d962b20dee54c6b31c8f37d2fe79105ad;hp=0494294db84c9bac4882d8d87d6fc85de33074d4;hpb=1a96e0dd77d6922078edd703fc7c2e809b9499b8;p=tpg%2Facess2.git diff --git a/Kernel/vfs/open.c b/Kernel/vfs/open.c index 0494294d..d2035713 100644 --- a/Kernel/vfs/open.c +++ b/Kernel/vfs/open.c @@ -3,7 +3,7 @@ * - Open, Close and ChDir */ #define DEBUG 0 -#include +#include #include "vfs.h" #include "vfs_int.h" #include "vfs_ext.h" @@ -15,7 +15,7 @@ // === IMPORTS === extern tVFS_Node gVFS_MemRoot; -extern tVFS_Mount *gRootMount; +extern tVFS_Mount *gVFS_RootMount; // === GLOBALS === tVFS_Handle *gaUserHandles = (void*)MM_PPD_VFS; @@ -30,10 +30,12 @@ char *VFS_GetAbsPath(char *Path) { char *ret; int pathLen = strlen(Path); - int read, write; - int pos, endLen; - int slashNum = 0; - Uint slashOffsets[MAX_PATH_SLASHES]; + char *pathComps[MAX_PATH_SLASHES]; + char *tmpStr; + int iPos = 0; + int iPos2 = 0; + char *chroot = CFGPTR(CFG_VFS_CHROOT); + int chrootLen; char *cwd = CFGPTR(CFG_VFS_CWD); int cwdLen; @@ -51,9 +53,16 @@ char *VFS_GetAbsPath(char *Path) return ret; } + // - Fetch ChRoot + if( chroot == NULL ) { + chroot = ""; + chrootLen = 0; + } else { + chrootLen = strlen(chroot); + } + // Check if the path is already absolute if(Path[0] == '/') { - endLen = pathLen + 1; ret = malloc(pathLen + 1); if(!ret) { Warning("VFS_GetAbsPath - malloc() returned NULL"); @@ -61,65 +70,96 @@ char *VFS_GetAbsPath(char *Path) } strcpy(ret, Path); } else { - cwdLen = strlen(cwd); - endLen = cwdLen + pathLen + 2; + if(cwd == NULL) { + cwd = "/"; + cwdLen = 1; + } + else { + cwdLen = strlen(cwd); + } // Prepend the current directory - ret = malloc(endLen); + ret = malloc( cwdLen + 1 + pathLen + 1 ); strcpy(ret, cwd); ret[cwdLen] = '/'; strcpy(&ret[cwdLen+1], Path); + //Log("ret = '%s'\n", ret); } - // Remove . and .. - read = write = 1; // Cwd has already been parsed - for(; read < endLen; read = pos+1) + // Parse Path + pathComps[iPos++] = tmpStr = ret+1; + while(*tmpStr) { - pos = strpos( &ret[read], '/' ); - // If we are in the last section, force a break at the end of the itteration - if(pos == -1) pos = endLen; - else pos += read; // Else, Adjust to absolute - - // Check Length - if(pos - read <= 2) + if(*tmpStr++ == '/') { - // Current Dir "." - if(strncmp(&ret[read], ".", pos-read) == 0) continue; - // Parent ".." - if(strncmp(&ret[read], "..", pos-read) == 0) - { - // If there is no higher, silently ignore - if(slashNum < 1) { - write = 1; - continue; - } - // Reverse write pointer - write = slashOffsets[ --slashNum ]; - continue; + pathComps[iPos++] = tmpStr; + if(iPos == MAX_PATH_SLASHES) { + LOG("Path '%s' has too many elements", Path); + free(ret); + LEAVE('n'); + return NULL; } } - - - // Only copy if the positions differ - if(read != write) { - //Log("write = %i, read = %i, pos-read+1 = %i", write, read, pos-read+1); - memcpy( &ret[write], &ret[read], pos-read+1 ); - //Log("ret = '%s'", ret); + } + pathComps[iPos] = NULL; + + // Cleanup + iPos2 = iPos = 0; + while(pathComps[iPos]) + { + tmpStr = pathComps[iPos]; + // Always Increment iPos + iPos++; + // .. + if(tmpStr[0] == '.' && tmpStr[1] == '.' && (tmpStr[2] == '/' || tmpStr[2] == '\0') ) + { + if(iPos2 != 0) + iPos2 --; + continue; } - - if(slashNum < MAX_PATH_SLASHES) - slashOffsets[ slashNum++ ] = write; - else { - LOG("Path '%s' has too many elements", Path); - free(ret); - LEAVE('n'); - return NULL; + // . + if(tmpStr[0] == '.' && (tmpStr[1] == '/' || tmpStr[1] == '\0') ) + { + continue; + } + // Empty + if(tmpStr[0] == '/' || tmpStr[0] == '\0') + { + continue; } - // Increment write pointer - write += (pos-read)+1; + // Set New Position + pathComps[iPos2] = tmpStr; + iPos2++; } + pathComps[iPos2] = NULL; + + // Build New Path + iPos2 = 1; iPos = 0; + ret[0] = '/'; + while(pathComps[iPos]) + { + tmpStr = pathComps[iPos]; + while(*tmpStr && *tmpStr != '/') + { + ret[iPos2++] = *tmpStr; + tmpStr++; + } + ret[iPos2++] = '/'; + iPos++; + } + if(iPos2 > 1) + ret[iPos2-1] = 0; + else + ret[iPos2] = 0; + + + // Prepend the chroot + tmpStr = malloc(chrootLen + strlen(ret) + 1); + strcpy( tmpStr, chroot ); + strcpy( tmpStr+chrootLen, ret ); + free(ret); + ret = tmpStr; - // `ret` should now be the absolute path LEAVE('s', ret); //Log("VFS_GetAbsPath: RETURN '%s'", ret); return ret; @@ -132,7 +172,7 @@ char *VFS_GetAbsPath(char *Path) tVFS_Node *VFS_ParsePath(char *Path, char **TruePath) { tVFS_Mount *mnt; - tVFS_Mount *longestMount = gRootMount; // Root is first + tVFS_Mount *longestMount = gVFS_RootMount; // Root is first int cmp, retLength = 0; int ofs, nextSlash; tVFS_Node *curNode, *tmpNode; @@ -154,18 +194,21 @@ tVFS_Node *VFS_ParsePath(char *Path, char **TruePath) if(Path[0] == '/' && Path[1] == '\0') { if(TruePath) { - *TruePath = malloc( gRootMount->MountPointLen+1 ); - strcpy(*TruePath, gRootMount->MountPoint); + *TruePath = malloc( gVFS_RootMount->MountPointLen+1 ); + strcpy(*TruePath, gVFS_RootMount->MountPoint); } - LEAVE('p', gRootMount->RootNode); - return gRootMount->RootNode; + LEAVE('p', gVFS_RootMount->RootNode); + return gVFS_RootMount->RootNode; } // Check if there is anything mounted - if(!gMounts) return NULL; + if(!gVFS_Mounts) { + Warning("WTF! There's nothing mounted?"); + return NULL; + } // Find Mountpoint - for(mnt = gMounts; + for(mnt = gVFS_Mounts; mnt; mnt = mnt->Next) { @@ -195,7 +238,7 @@ tVFS_Node *VFS_ParsePath(char *Path, char **TruePath) // Sanity Check /*if(!longestMount) { - Log("VFS_GetTruePath - ERROR: No Root Node\n"); + Log("VFS_ParsePath - ERROR: No Root Node\n"); return NULL; }*/ @@ -226,23 +269,26 @@ tVFS_Node *VFS_ParsePath(char *Path, char **TruePath) // Check permissions on root of filesystem if( !VFS_CheckACL(curNode, VFS_PERM_EXECUTE) ) { - curNode->Close( curNode ); + if(curNode->Close) curNode->Close( curNode ); if(TruePath) { free(*TruePath); *TruePath = NULL; } + //Log("Permissions fail on '%s'", Path); LEAVE('n'); return NULL; } // Check if the node has a FindDir method - if(!curNode->FindDir) { + if( !curNode->FindDir ) + { if(curNode->Close) curNode->Close(curNode); if(TruePath) { free(*TruePath); *TruePath = NULL; } Path[nextSlash] = '/'; + //Log("FindDir fail on '%s'", Path); LEAVE('n'); return NULL; } @@ -250,8 +296,7 @@ tVFS_Node *VFS_ParsePath(char *Path, char **TruePath) // Get Child Node tmpNode = curNode->FindDir(curNode, &Path[ofs]); LOG("tmpNode = %p", tmpNode); - if(curNode->Close) - curNode->Close(curNode); + if(curNode->Close) curNode->Close(curNode); curNode = tmpNode; // Error Check @@ -261,6 +306,7 @@ tVFS_Node *VFS_ParsePath(char *Path, char **TruePath) free(*TruePath); *TruePath = NULL; } + //Log("Child fail on '%s' ('%s)", Path, &Path[ofs]); Path[nextSlash] = '/'; LEAVE('n'); return NULL; @@ -273,6 +319,13 @@ tVFS_Node *VFS_ParsePath(char *Path, char **TruePath) *TruePath = NULL; } tmp = malloc( curNode->Size + 1 ); + if(!curNode->Read) { + Warning("VFS_ParsePath - Read of node %p is NULL (%s)", + curNode, Path); + if(curNode->Close) curNode->Close(curNode); + LEAVE('n'); + return NULL; + } curNode->Read( curNode, 0, curNode->Size, tmp ); tmp[ curNode->Size ] = '\0'; @@ -281,6 +334,7 @@ tVFS_Node *VFS_ParsePath(char *Path, char **TruePath) // Error Check if(!curNode) { + Log("Symlink fail '%s'", tmp); free(tmp); // Free temp string LEAVE('n'); return NULL; @@ -335,6 +389,7 @@ tVFS_Node *VFS_ParsePath(char *Path, char **TruePath) // Check if file was found if(!tmpNode) { LOG("Node '%s' not found in dir '%s'", &Path[ofs], Path); + //Log("Child fail '%s' ('%s')", Path, &Path[ofs]); if(TruePath) free(*TruePath); if(curNode->Close) curNode->Close(curNode); LEAVE('n'); @@ -409,6 +464,7 @@ int VFS_Open(char *Path, Uint Mode) } if(!node) { + LOG("Cannot find node"); LEAVE('i', -1); return -1; } @@ -422,7 +478,8 @@ int VFS_Open(char *Path, Uint Mode) // Permissions Check if( !VFS_CheckACL(node, i) ) { - node->Close( node ); + if(node->Close) node->Close( node ); + Log("VFS_Open: Permissions Failed"); LEAVE('i', -1); return -1; } @@ -473,6 +530,108 @@ int VFS_Open(char *Path, Uint Mode) } } + Log("VFS_Open: Out of handles"); + LEAVE('i', -1); + return -1; +} + + +/** + * \brief Open a file from an open directory + */ +int VFS_OpenChild(Uint *Errno, int FD, char *Name, Uint Mode) +{ + tVFS_Handle *h; + tVFS_Node *node; + int i; + + // Get handle + h = VFS_GetHandle(FD); + if(h == NULL) { + Log_Warning("VFS", "VFS_OpenChild - Invalid file handle 0x%x", FD); + if(Errno) *Errno = EINVAL; + LEAVE('i', -1); + return -1; + } + + // Check for directory + if( !(h->Node->Flags & VFS_FFLAG_DIRECTORY) ) { + Log_Warning("VFS", "VFS_OpenChild - Passed handle is not a directory", FD); + if(Errno) *Errno = ENOTDIR; + LEAVE('i', -1); + return -1; + } + + // Find Child + node = h->Node->FindDir(h->Node, Name); + if(!node) { + if(Errno) *Errno = ENOENT; + LEAVE('i', -1); + return -1; + } + + i = 0; + i |= (Mode & VFS_OPENFLAG_EXEC) ? VFS_PERM_EXECUTE : 0; + i |= (Mode & VFS_OPENFLAG_READ) ? VFS_PERM_READ : 0; + i |= (Mode & VFS_OPENFLAG_WRITE) ? VFS_PERM_WRITE : 0; + + // Permissions Check + if( !VFS_CheckACL(node, i) ) { + if(node->Close) node->Close( node ); + Log_Notice("VFS", "VFS_OpenChild - Permissions Failed"); + if(Errno) *Errno = EACCES; + LEAVE('i', -1); + return -1; + } + + // Check for a user open + if(Mode & VFS_OPENFLAG_USER) + { + // Allocate Buffer + if( MM_GetPhysAddr( (Uint)gaUserHandles ) == 0 ) + { + Uint addr, size; + size = CFGINT(CFG_VFS_MAXFILES) * sizeof(tVFS_Handle); + for(addr = 0; addr < size; addr += 0x1000) + MM_Allocate( (Uint)gaUserHandles + addr ); + memset( gaUserHandles, 0, size ); + } + // Get a handle + for(i=0;iNode->Flags & VFS_FFLAG_DIRECTORY) ) { + LOG("Path is not a directory"); + VFS_Close(fd); + return -1; + } + + // Close file + VFS_Close(fd); + + // Free old working directory + if( CFGPTR(CFG_VFS_CHROOT) ) + free( CFGPTR(CFG_VFS_CHROOT) ); + // Set new + CFGPTR(CFG_VFS_CHROOT) = buf; + + LOG("Updated Root to '%s'", buf); + + return 1; +} + /** * \fn tVFS_Handle *VFS_GetHandle(int FD) * \brief Gets a pointer to the handle information structure @@ -565,3 +773,7 @@ tVFS_Handle *VFS_GetHandle(int FD) if(h->Node == NULL) return NULL; return h; } + +// === EXPORTS === +EXPORT(VFS_Open); +EXPORT(VFS_Close);