X-Git-Url: https://git.ucc.asn.au/?a=blobdiff_plain;ds=sidebyside;f=Usermode%2FApplications%2FCLIShell_src%2Fmain.c;h=4fe8a4a2331cb3f154c563d5099b310dafc7b88a;hb=1a96e0dd77d6922078edd703fc7c2e809b9499b8;hp=aa1d9abec48744cd0f5182998adb526848ee1439;hpb=f6b468cee21ebf1c9b98efec5315950aa043ead5;p=tpg%2Facess2.git

diff --git a/Usermode/Applications/CLIShell_src/main.c b/Usermode/Applications/CLIShell_src/main.c
index aa1d9abe..4fe8a4a2 100644
--- a/Usermode/Applications/CLIShell_src/main.c
+++ b/Usermode/Applications/CLIShell_src/main.c
@@ -13,6 +13,7 @@
 // ==== PROTOTYPES ====
 char	*ReadCommandLine(int *Length);
 void	Parse_Args(char *str, char **dest);
+void	CallCommand(char **Args);
 void	Command_Colour(int argc, char **argv);
 void	Command_Clear(int argc, char **argv);
 void	Command_Cd(int argc, char **argv);
@@ -27,12 +28,15 @@ struct	{
 	{"colour", Command_Colour}, {"clear", Command_Clear},
 	{"cd", Command_Cd}, {"dir", Command_Dir}
 };
+static char	*cDEFAULT_PATH[] = {"/Acess"};
 #define	BUILTIN_COUNT	(sizeof(cBUILTINS)/sizeof(cBUILTINS[0]))
 
 // ==== LOCAL VARIABLES ====
+ int	giNumPathDirs = 1;
+char	**gasPathDirs = cDEFAULT_PATH;
+char	**gasEnvironment;
 char	gsCommandBuffer[1024];
 char	*gsCurrentDirectory = NULL;
-char	gsTmpBuffer[1024];
 char	**gasCommandHistory;
  int	giLastCommand = 0;
  int	giCommandSpace = 0;
@@ -43,12 +47,13 @@ int main(int argc, char *argv[], char *envp[])
 	char	*sCommandStr;
 	char	*saArgs[32];
 	 int	length = 0;
-	 int	pid = -1;
+	 int	i;
 	 int	iArgCount = 0;
 	 int	bCached = 1;
-	t_sysFInfo	info;
 	
-	//Command_Clear(0, NULL);
+	gasEnvironment = envp;
+	
+	Command_Clear(0, NULL);
 	
 	{
 		char	*tmp = getenv("CWD");
@@ -61,7 +66,6 @@ int main(int argc, char *argv[], char *envp[])
 		}
 	}	
 	
-	write(_stdout, 1, "\n");
 	write(_stdout, 22, "Acess Shell Version 3\n");
 	write(_stdout,  2, "\n");
 	for(;;)
@@ -70,13 +74,17 @@ int main(int argc, char *argv[], char *envp[])
 		if(saArgs[0])	free(saArgs);
 		if(!bCached)	free(sCommandStr);
 		bCached = 0;
-		write(_stdout, 1, "\n");
 		write(_stdout, strlen(gsCurrentDirectory), gsCurrentDirectory);
 		write(_stdout, 3, "$ ");
 		
 		// Read Command line
 		sCommandStr = ReadCommandLine( &length );
 		
+		if(!sCommandStr) {
+			write(_stdout, 25, "PANIC: Out of heap space\n");
+			return -1;
+		}
+		
 		// Check if the command should be cached
 		if(gasCommandHistory == NULL || strcmp(sCommandStr, gasCommandHistory[giLastCommand]) != 0)
 		{
@@ -100,46 +108,18 @@ int main(int argc, char *argv[], char *envp[])
 		if(saArgs[1][0] == '\0')	continue;
 		
 		// Check Built-In Commands
-		//  [HACK] Mem Usage - Use Length in place of `i'
-		for(length=0;length<BUILTIN_COUNT;length++)
+		for( i = 0; i < BUILTIN_COUNT; i++ )
 		{
-			if(strcmp(saArgs[1], cBUILTINS[length].name) == 0)
+			if( strcmp(saArgs[1], cBUILTINS[i].name) == 0 )
 			{
-				cBUILTINS[length].fcn(iArgCount-1, &saArgs[1]);
+				cBUILTINS[i].fcn(iArgCount-1, &saArgs[1]);
 				break;
 			}
 		}
+		if(i != BUILTIN_COUNT)	continue;
 		
-		if(length != BUILTIN_COUNT)	continue;
-		
-		// - Calling a file
-		GeneratePath(saArgs[1], gsCurrentDirectory, gsTmpBuffer);
-		// Use length in place of fp
-		length = open(gsTmpBuffer, 0);
-		// Check file existence
-		if(length == -1) {
-			Print("Unknown Command: `");Print(saArgs[1]);Print("'\n");	// Error Message
-			continue;
-		}
-		// Check if the file is a directory
-		finfo( length, &info, 0 );
-		close( length );
-		if(info.flags & FILEFLAG_DIRECTORY) {
-			Print("`");Print(saArgs[1]);	// Error Message
-			Print("' is a directory.\n");
-			continue;
-		}
-		// Load new executable
-		pid = clone(CLONE_VM, 0);
-		if(pid == 0)	execve(gsTmpBuffer, &saArgs[1], envp);
-		if(pid <= 0) {
-			Print("Unablt to create process: `");Print(gsTmpBuffer);Print("'\n");	// Error Message
-			//SysDebug("pid = %i\n", pid);
-		}
-		else {
-			 int	status;
-			waittid(pid, &status);
-		}
+		// Shall we?
+		CallCommand( &saArgs[1] );
 	}
 }
 
@@ -155,14 +135,29 @@ char *ReadCommandLine(int *Length)
 	 
 	// Preset Variables
 	ret = malloc( space+1 );
-	len = 0;
-	pos = 0;
+	if(!ret)	return NULL;
+	len = 0;	pos = 0;
 		
 	// Read In Command Line
 	do {
 		read(_stdin, 1, &ch);	// Read Character from stdin (read is a blocking call)
 		// Ignore control characters
-		if(ch < 0)	continue;
+		if(ch == '\x1B') {
+			read(_stdin, 1, &ch);	// Read control character
+			switch(ch)
+			{
+			case 'D':	if(pos)	pos--;	break;
+			case 'C':	if(pos<len)	pos++;	break;
+			case '[':
+				read(_stdin, 1, &ch);	// Read control character
+				switch(ch)
+				{
+				case 'D':	if(pos)	pos--;	break;
+				case 'C':	if(pos<len)	pos++;	break;
+				}
+			}
+			continue;
+		}
 		// Backspace
 		if(ch == '\b') {
 			if(len <= 0)		continue;	// Protect against underflows
@@ -207,6 +202,12 @@ void Parse_Args(char *str, char **dest)
 	 int	i = 1;
 	char	*buf = malloc( strlen(str) + 1 );
 	
+	if(buf == NULL) {
+		dest[0] = NULL;
+		Print("Parse_Args: Out of heap space!\n");
+		return ;
+	}
+	
 	strcpy(buf, str);
 	dest[0] = buf;
 	
@@ -237,6 +238,79 @@ void Parse_Args(char *str, char **dest)
 	}
 }
 
+/**
+ * \fn void CallCommand(char **Args)
+ */
+void CallCommand(char **Args)
+{
+	t_sysFInfo	info;
+	 int	pid = -1;
+	 int	fd = 0;
+	char	sTmpBuffer[1024];
+	char	*exefile = Args[0];
+	
+	if(exefile[0] == '/'
+	|| (exefile[0] == '.' && exefile[1] == '/')
+	|| (exefile[0] == '.' && exefile[1] == '.' && exefile[2] == '/')
+		)
+	{
+		GeneratePath(exefile, gsCurrentDirectory, sTmpBuffer);
+		// Check file existence
+		fd = open(sTmpBuffer, OPENFLAG_EXEC);
+		if(fd == -1) {
+			Print("Unknown Command: `");Print(Args[0]);Print("'\n");	// Error Message
+			return ;
+		}
+		
+		// Get File info and close file
+		finfo( fd, &info, 0 );
+		close( fd );
+		
+		// Check if the file is a directory
+		if(info.flags & FILEFLAG_DIRECTORY) {
+			Print("`");Print(sTmpBuffer);	// Error Message
+			Print("' is a directory.\n");
+			return ;
+		}
+	}
+	else
+	{
+		 int	i;
+		
+		// Check all components of $PATH
+		for( i = 0; i < giNumPathDirs; i++ )
+		{
+			GeneratePath(exefile, gasPathDirs[i], sTmpBuffer);
+			fd = open(sTmpBuffer, OPENFLAG_EXEC);
+			if(fd == -1)	continue;
+			finfo( fd, &info, 0 );
+			close( fd );
+			if(info.flags & FILEFLAG_DIRECTORY)	continue;
+			// Woohoo! We found a valid command
+			break;
+		}
+		
+		// Exhausted path directories
+		if( i == giNumPathDirs ) {
+			Print("Unknown Command: `");Print(exefile);Print("'\n");
+			return ;
+		}
+	}
+	
+	// Create new process
+	pid = clone(CLONE_VM, 0);
+	// Start Task
+	if(pid == 0)
+		execve(sTmpBuffer, Args, gasEnvironment);
+	if(pid <= 0) {
+		Print("Unablt to create process: `");Print(sTmpBuffer);Print("'\n");	// Error Message
+	}
+	else {
+		 int	status;
+		waittid(pid, &status);
+	}
+}
+
 /**
  * \fn void Command_Colour(int argc, char **argv)
  * \brief 
@@ -249,7 +323,6 @@ void Command_Colour(int argc, char **argv)
 	// Verify Arg Count
 	if(argc < 2)
 	{
-		Print("Please specify a colour\n");
 		goto usage;
 	}
 	
@@ -290,6 +363,7 @@ void Command_Colour(int argc, char **argv)
 
 	// Function Usage (Requested via a Goto (I know it's ugly))
 usage:
+	Print("Usage: colour <foreground> [<background>]\n");
 	Print("Valid Colours are ");
 	for(fg=0;fg<8;fg++)
 	{
@@ -300,6 +374,10 @@ usage:
 	return;
 }
 
+/**
+ * \fn void Command_Clear(int argc, char **argv)
+ * \brief Clear the screen
+ */
 void Command_Clear(int argc, char **argv)
 {
 	write(_stdout, 4, "\x1B[2J");	//Clear Screen
@@ -339,6 +417,9 @@ void Command_Cd(int argc, char **argv)
 	free(gsCurrentDirectory);
 	gsCurrentDirectory = malloc(strlen(tmpPath)+1);
 	strcpy(gsCurrentDirectory, tmpPath);
+	
+	// Register change with kernel
+	chdir( gsCurrentDirectory );
 }
 
 /**