X-Git-Url: https://git.ucc.asn.au/?a=blobdiff_plain;f=Kernel%2Fsyscalls.c;h=ff472941a5e9db907c5d4962200f21e23a72f62f;hb=8396db7669b978201bd1d507fddacf992771a7ee;hp=90422ceedd9bb2cb873e1df32997afa7842d1100;hpb=2c9822ab13554ffab9f634a839ee916e0388179c;p=tpg%2Facess2.git

diff --git a/Kernel/syscalls.c b/Kernel/syscalls.c
index 90422cee..ff472941 100644
--- a/Kernel/syscalls.c
+++ b/Kernel/syscalls.c
@@ -2,7 +2,7 @@
  * AcessOS Microkernel Version
  * syscalls.c
  */
-#define DEBUG	1
+#define DEBUG	0
 
 #include <common.h>
 #include <syscalls.h>
@@ -17,13 +17,20 @@ extern int	Proc_GetMessage(Uint *Err, Uint *Source, void *Buffer);
 extern int	Proc_Execve(char *File, char **ArgV, char **EnvP);
 extern Uint	Binary_Load(char *file, Uint *entryPoint);
 extern int	VFS_FInfo(int FD, void *Dest, int MaxACLs);
+extern int	VFS_GetACL(int FD, void *Dest);
+extern int	VFS_ChDir(char *Dest);
 extern int	Threads_SetName(char *NewName);
 extern int	Threads_GetPID();
 extern int	Threads_GetTID();
 extern int	Threads_GetUID();
 extern int	Threads_GetGID();
 
+// === PROTOTYPES ===
+ int	Syscall_ValidString(Uint Addr);
+ int	Syscall_Valid(int Size, Uint Addr);
+
 // === CODE ===
+// TODO: Do sanity checking on arguments, ATM the user can really fuck with the kernel
 void SyscallHandler(tSyscallRegs *Regs)
 {
 	Uint64	ret = 0;
@@ -34,6 +41,7 @@ void SyscallHandler(tSyscallRegs *Regs)
 		LOG("Syscall %s", cSYSCALL_NAMES[Regs->Num]);
 	LOG("Arg1: 0x%x, Arg2: 0x%x, Arg3: 0x%x", Regs->Arg1, Regs->Arg2, Regs->Arg3);
 	#endif
+	
 	switch(Regs->Num)
 	{
 	// -- Exit the current thread
@@ -49,7 +57,7 @@ void SyscallHandler(tSyscallRegs *Regs)
 	case SYS_CLONE:
 		// Call clone system call
 		ret = Proc_Clone(&err, Regs->Arg1);
-		// Change user stack if requested
+		// Change user stack if a new stack address is passed
 		if(ret == 0 && Regs->Arg2)
 			Regs->StackPointer = Regs->Arg2;
 		break;
@@ -126,28 +134,54 @@ void SyscallHandler(tSyscallRegs *Regs)
 	
 	case SYS_WRITE:
 		#if BITS < 64
-		VFS_Write( Regs->Arg1, Regs->Arg2|((Uint64)Regs->Arg3<<32), (void*)Regs->Arg4 );
+		ret = VFS_Write( Regs->Arg1, Regs->Arg2|((Uint64)Regs->Arg3<<32), (void*)Regs->Arg4 );
 		#else
-		VFS_Write( Regs->Arg1, Regs->Arg2, (void*)Regs->Arg3 );
+		ret = VFS_Write( Regs->Arg1, Regs->Arg2, (void*)Regs->Arg3 );
 		#endif
 		break;
 	
 	case SYS_READ:
 		#if BITS < 64
-		VFS_Read( Regs->Arg1, Regs->Arg2|((Uint64)Regs->Arg3<<32), (void*)Regs->Arg4 );
+		ret = VFS_Read( Regs->Arg1, Regs->Arg2|((Uint64)Regs->Arg3<<32), (void*)Regs->Arg4 );
 		#else
-		VFS_Read( Regs->Arg1, Regs->Arg2, (void*)Regs->Arg3 );
+		ret = VFS_Read( Regs->Arg1, Regs->Arg2, (void*)Regs->Arg3 );
 		#endif
 		break;
 	
 	case SYS_FINFO:
 		ret = VFS_FInfo( Regs->Arg1, (void*)Regs->Arg2, Regs->Arg3 );
 		break;
-		
+	
+	// Get ACL Value
+	case SYS_GETACL:
+		if( !Syscall_Valid(8, Regs->Arg1) ) {
+			err = -EINVAL;
+			ret = -1;
+			break;
+		}
+		ret = VFS_GetACL( Regs->Arg1, (void*)Regs->Arg2 );
+		break;
+	
+	// Read Directory
 	case SYS_READDIR:
+		if( !Syscall_ValidString(Regs->Arg2) ) {
+			err = -EINVAL;
+			ret = -1;
+			break;
+		}
 		ret = VFS_ReadDir( Regs->Arg1, (void*)Regs->Arg2 );
 		break;
 	
+	// Change Directory
+	case SYS_CHDIR:
+		if( !Syscall_ValidString(Regs->Arg1) ) {
+			err = -EINVAL;
+			ret = -1;
+			break;
+		}
+		ret = VFS_ChDir( (void*)Regs->Arg1 );
+		break;
+	
 	// -- Debug
 	case SYS_DEBUG:
 		Log((char*)Regs->Arg1,
@@ -176,3 +210,36 @@ void SyscallHandler(tSyscallRegs *Regs)
 	#endif
 }
 
+/**
+ * \fn int Syscall_ValidString(Uint Addr)
+ * \brief Checks if a memory address contains a valid string
+ */
+int Syscall_ValidString(Uint Addr)
+{
+	// Check 1st page
+	if(!MM_GetPhysAddr(Addr))	return 0;
+	
+	// Traverse String
+	while(*(char*)Addr)
+	{
+		if(!MM_GetPhysAddr(Addr))	return 0;
+		// Increment string pointer
+		Addr ++;
+	}
+	
+	return 1;
+}
+
+/**
+ * \fn int Syscall_Valid(int Size, Uint Addr)
+ * \brief Checks if a memory address is valid
+ */
+int Syscall_Valid(int Size, Uint Addr)
+{
+	while(Size--)
+	{
+		if(!MM_GetPhysAddr(Addr))	return 0;
+		Addr ++;
+	}
+	return 1;
+}