X-Git-Url: https://git.ucc.asn.au/?a=blobdiff_plain;f=Kernel%2Fvfs%2Ffs%2Ffat.c;h=5712da9102bb4e37a89948c435018551e6d2aa30;hb=95a7eaaa4a1065334125b65130866f8d1048ddb7;hp=8a5582733802a248751f4fb4c4ae5d161484ebd6;hpb=d7801bfc828d3328ac9a0172db8a71b8f33c4a19;p=tpg%2Facess2.git

diff --git a/Kernel/vfs/fs/fat.c b/Kernel/vfs/fs/fat.c
index 8a558273..5712da91 100644
--- a/Kernel/vfs/fs/fat.c
+++ b/Kernel/vfs/fs/fat.c
@@ -1,28 +1,15 @@
 /*
- * Acess2
+ * Acess 2
  * FAT12/16/32 Driver Version (Incl LFN)
  */
-//INCLUDES
+#define DEBUG	0
 #include <common.h>
 #include <modules.h>
 #include <vfs.h>
 #include "fs_fat.h"
 
-#define DEBUG	0
 #define VERBOSE	1
 
-#if DEBUG
-# define DEBUGS(v...)	Log(v)
-#else
-# define DEBUGS(v...)
-# undef ENTER
-# undef LOG
-# undef LEAVE
-# define ENTER(...)
-# define LOG(...)
-# define LEAVE(...)
-#endif
-
 #define CACHE_FAT	1	//!< Caches the FAT in memory
 #define USE_LFN		1	//!< Enables the use of Long File Names
 
@@ -38,7 +25,7 @@ typedef struct s_lfncache {
 
 // === PROTOTYPES ===
  int	FAT_Install(char **Arguments);
-tVFS_Node	*FAT_InitDevice(char *device, char *options);
+tVFS_Node	*FAT_InitDevice(char *device, char **options);
 void	FAT_Unmount(tVFS_Node *Node);
 Uint64	FAT_Read(tVFS_Node *node, Uint64 offset, Uint64 length, void *buffer);
 Uint64	FAT_Write(tVFS_Node *node, Uint64 offset, Uint64 length, void *buffer);
@@ -49,7 +36,7 @@ tVFS_Node	*FAT_FindDir(tVFS_Node *dirNode, char *file);
 void	FAT_CloseFile(tVFS_Node *node);
 
 // === SEMI-GLOBALS ===
-MODULE_DEFINE(0, 0x5B /*v0.90*/, FAT32, FAT_Install, NULL);
+MODULE_DEFINE(0, 0x51 /*v0.80*/, FAT32, FAT_Install, NULL, NULL);
 tFAT_VolInfo	gFAT_Disks[8];
  int	giFAT_PartCount = 0;
 #if CACHE_FAT
@@ -74,10 +61,10 @@ int FAT_Install(char **Arguments)
 }
 
 /**
- * \fn tVFS_Node *FAT_InitDevice(char *Device, char *options)
+ * \fn tVFS_Node *FAT_InitDevice(char *Device, char **options)
  * \brief Reads the boot sector of a disk and prepares the structures for it
  */
-tVFS_Node *FAT_InitDevice(char *Device, char *options)
+tVFS_Node *FAT_InitDevice(char *Device, char **options)
 {
 	fat_bootsect *bs;
 	 int	i;
@@ -213,16 +200,13 @@ tVFS_Node *FAT_InitDevice(char *Device, char *options)
 			fat_cache[giFAT_PartCount][i] = buf[i&127];
 		}
 	}
-	DEBUGS(" FAT_InitDisk: FAT Fully Cached\n");
+	LOG("FAT Fully Cached");
 	}
 	#endif /*CACHE_FAT*/
 	
 	//Initalise inode cache for FAT
 	gFAT_Disks[giFAT_PartCount].inodeHandle = Inode_GetHandle();
-	
-	#if DEBUG
-		Log(" FAT_InitDisk: Inode Cache handle is %i\n", gFAT_Disks[giFAT_PartCount].inodeHandle);
-	#endif
+	LOG("Inode Cache handle is %i", gFAT_Disks[giFAT_PartCount].inodeHandle);
 	
 	// == VFS Interface
 	node = &gFAT_Disks[giFAT_PartCount].rootNode;
@@ -292,9 +276,7 @@ static Uint32 FAT_int_GetFatValue(int handle, Uint32 cluster)
  */
 static void FAT_int_ReadCluster(int Handle, Uint32 Cluster, int Length, void *Buffer)
 {
-	#if DEBUG
 	ENTER("iHandle xCluster iLength pBuffer", Handle, Cluster, Length, Buffer);
-	#endif
 	VFS_ReadAt(
 		gFAT_Disks[Handle].fileHandle,
 		(gFAT_Disks[Handle].firstDataSect + (Cluster-2)*gFAT_Disks[Handle].bootsect.spc )
@@ -302,9 +284,7 @@ static void FAT_int_ReadCluster(int Handle, Uint32 Cluster, int Length, void *Bu
 		Length,
 		Buffer
 		);
-	#if DEBUG
 	LEAVE('-');
-	#endif
 }
 
 /**
@@ -342,6 +322,18 @@ Uint64 FAT_Read(tVFS_Node *node, Uint64 offset, Uint64 length, void *buffer)
 		return 0;
 	}
 	
+	// Sanity Check offset
+	if(offset > node->Size) {
+		//LOG("Reading past EOF (%i > %i)", offset, node->Size);
+		return 0;
+	}
+	// Clamp Size
+	if(offset + length > node->Size) {
+		//LOG("Reading past EOF (%lli + %lli > %lli), clamped to %lli",
+		//	offset, length, node->Size, node->Size - offset);
+		length = node->Size - offset;
+	}
+	
 	// Single Cluster including offset
 	if(length + offset < bpc)
 	{
@@ -349,7 +341,7 @@ Uint64 FAT_Read(tVFS_Node *node, Uint64 offset, Uint64 length, void *buffer)
 		memcpy( buffer, (void*)( tmpBuf + offset%bpc ), length );
 		free(tmpBuf);
 		LEAVE('i', 1);
-		return 1;
+		return length;
 	}
 	
 	preSkip = offset / bpc;
@@ -379,7 +371,7 @@ Uint64 FAT_Read(tVFS_Node *node, Uint64 offset, Uint64 length, void *buffer)
 	if (count == 1) {
 		free(tmpBuf);
 		LEAVE('i', 1);
-		return 1;
+		return length;
 	}
 	
 	cluster = FAT_int_GetFatValue(handle, cluster);