X-Git-Url: https://git.ucc.asn.au/?a=blobdiff_plain;f=KernelLand%2FKernel%2Fdrv%2Fvterm_termbuf.c;h=cb0de748635fd1da7ddf359a96eebf305353e3ef;hb=07ed0e7479fc741a947579d4460a25a050fc9260;hp=2511048cfaf86ae23606cb5231f59e5fd2c9941a;hpb=48743e39650eb1ef988380e9d95f27fd40d3a9ce;p=tpg%2Facess2.git

diff --git a/KernelLand/Kernel/drv/vterm_termbuf.c b/KernelLand/Kernel/drv/vterm_termbuf.c
index 2511048c..cb0de748 100644
--- a/KernelLand/Kernel/drv/vterm_termbuf.c
+++ b/KernelLand/Kernel/drv/vterm_termbuf.c
@@ -5,8 +5,18 @@
  * drv/vterm_termbuf.c
  * - Virtual Terminal - Terminal buffer manipulation
  */
+#define DEBUG	0
+#define DEBUG_CHECKHEAP	0
 #include "vterm.h"
 
+#if DEBUG_CHECKHEAP
+# define HEAP_VALIDATE()	Heap_Validate()
+#else
+# define HEAP_VALIDATE()	do{}while(0)
+#endif
+
+extern int	Term_HandleVT100(tVTerm *Term, int Len, const char *Buf);
+
 // === CODE ===
 
 /**
@@ -15,30 +25,34 @@
  */
 void VT_int_PutString(tVTerm *Term, const Uint8 *Buffer, Uint Count)
 {
-	Uint32	val;
-	 int	i;
-	
 	// Iterate
-	for( i = 0; i < Count; i++ )
+	for( int ofs = 0; ofs < Count; )
 	{
-		// Handle escape sequences
-		if( Buffer[i] == 0x1B )
-		{
-			i ++;
-			i += VT_int_ParseEscape(Term, (const char*)&Buffer[i]) - 1;
-			continue;
+		int esc_len = Term_HandleVT100(Term, Count - ofs, (const void*)(Buffer + ofs));
+		if( esc_len < 0 ) {
+			esc_len = -esc_len;
+			//LOG("%i '%*C'", esc_len, esc_len, Buffer+ofs);
+			LOG("%i '%.*s'", esc_len, esc_len, Buffer+ofs);
+			VT_int_PutRawString(Term, Buffer + ofs, esc_len);
+			//Debug("Raw string '%.*s'", esc_len, Buffer+ofs);
 		}
-		
-		// Fast check for non UTF-8
-		if( Buffer[i] < 128 )	// Plain ASCII
-			VT_int_PutChar(Term, Buffer[i]);
-		else {	// UTF-8
-			i += ReadUTF8(&Buffer[i], &val) - 1;
-			VT_int_PutChar(Term, val);
+		else {
+			//Debug("Escape code '%.*s'", esc_len, Buffer+ofs);
 		}
+		ASSERTCR(esc_len, >, 0, );
+		ofs += esc_len;
 	}
 	// Update Screen
-	VT_int_UpdateScreen( Term, 0 );
+	VT_int_UpdateScreen( Term, 1 );
+}
+
+void VT_int_PutRawString(tVTerm *Term, const Uint8 *String, size_t Bytes)
+{
+	for( int i = 0; i < Bytes; ) {
+		Uint32	val;
+		i += ReadUTF8(String+i, &val);
+		VT_int_PutChar(Term, val);
+	}
 }
 
 /**
@@ -50,19 +64,28 @@ void VT_int_PutChar(tVTerm *Term, Uint32 Ch)
 	 int	i;
 	tVT_Char	*buffer;
 	 int	write_pos;
+	 int	limit;
+	
+	HEAP_VALIDATE();
 	
 	if(Term->Flags & VT_FLAG_ALTBUF) {
 		buffer = Term->AltBuf;
 		write_pos = Term->AltWritePos;
+		limit = Term->TextHeight * Term->TextWidth;
 	}
 	else {
 		buffer = Term->Text;
 		write_pos = Term->WritePos;
+		limit = Term->TextHeight*(giVT_Scrollback+1) * Term->TextWidth;
 	}
 	
+	// TODO: Can the write position be equal to the end of screen?
+	ASSERTC(write_pos, <, limit);
+	
 	switch(Ch)
 	{
-	case '\0':	return;	// Ignore NULL byte
+	case '\0':	// Ignore NULL byte
+		return;
 	case '\n':
 		VT_int_UpdateScreen( Term, 0 );	// Update the line before newlining
 		write_pos += Term->TextWidth;
@@ -70,14 +93,14 @@ void VT_int_PutChar(tVTerm *Term, Uint32 Ch)
 		write_pos -= write_pos % Term->TextWidth;
 		break;
 	
-	case '\t': { int tmp = write_pos / Term->TextWidth;
-		write_pos %= Term->TextWidth;
+	case '\t': {
+		size_t	col =  write_pos % Term->TextWidth;
 		do {
 			buffer[ write_pos ].Ch = '\0';
 			buffer[ write_pos ].Colour = Term->CurColour;
 			write_pos ++;
-		} while(write_pos & 7);
-		write_pos += tmp * Term->TextWidth;
+			col ++;
+		} while( (col & 7) && col < Term->TextWidth );
 		break; }
 	
 	case '\b':
@@ -85,7 +108,7 @@ void VT_int_PutChar(tVTerm *Term, Uint32 Ch)
 		if(write_pos == 0)	break;
 		
 		write_pos --;
-		// Singe Character
+		// Single Character
 		if(buffer[ write_pos ].Ch != '\0') {
 			buffer[ write_pos ].Ch = 0;
 			buffer[ write_pos ].Colour = Term->CurColour;
@@ -114,30 +137,23 @@ void VT_int_PutChar(tVTerm *Term, Uint32 Ch)
 	
 	if(Term->Flags & VT_FLAG_ALTBUF)
 	{
-		Term->AltBuf = buffer;
 		Term->AltWritePos = write_pos;
 		
-		if(Term->AltWritePos >= Term->TextWidth*Term->TextHeight)
+		if(Term->AltWritePos >= limit)
 		{
 			Term->AltWritePos -= Term->TextWidth;
 			VT_int_ScrollText(Term, 1);
 		}
-		
 	}
 	else
 	{
-		Term->Text = buffer;
 		Term->WritePos = write_pos;
 		// Move Screen
 		// - Check if we need to scroll the entire scrollback buffer
-		if(Term->WritePos >= Term->TextWidth*Term->TextHeight*(giVT_Scrollback+1))
+		if(Term->WritePos >= limit)
 		{
 			 int	base;
 			
-			// Update previous line
-			Term->WritePos -= Term->TextWidth;
-			VT_int_UpdateScreen( Term, 0 );
-			
 			// Update view position
 			base = Term->TextWidth*Term->TextHeight*(giVT_Scrollback);
 			if(Term->ViewPos < base)
@@ -146,20 +162,18 @@ void VT_int_PutChar(tVTerm *Term, Uint32 Ch)
 				Term->ViewPos = base;
 			
 			VT_int_ScrollText(Term, 1);
+			Term->WritePos -= Term->TextWidth;
 		}
 		// Ok, so we only need to scroll the screen
 		else if(Term->WritePos >= Term->ViewPos + Term->TextWidth*Term->TextHeight)
 		{
-			// Update the last line
-			Term->WritePos -= Term->TextWidth;
-			VT_int_UpdateScreen( Term, 0 );
-			Term->WritePos += Term->TextWidth;
-			
-			VT_int_ScrollText(Term, 1);
+			VT_int_ScrollFramebuffer( Term, 1 );
 			
 			Term->ViewPos += Term->TextWidth;
 		}
 	}
+
+	HEAP_VALIDATE();
 	
 	//LEAVE('-');
 }
@@ -167,16 +181,18 @@ void VT_int_PutChar(tVTerm *Term, Uint32 Ch)
 void VT_int_ScrollText(tVTerm *Term, int Count)
 {
 	tVT_Char	*buf;
-	 int	height, init_write_pos;
-	 int	len, i;
+	 int	*write_pos_ptr;
+	 int	height;
 	 int	scroll_top, scroll_height;
+	
+	HEAP_VALIDATE();
 
 	// Get buffer pointer and attributes	
 	if( Term->Flags & VT_FLAG_ALTBUF )
 	{
 		buf = Term->AltBuf;
 		height = Term->TextHeight;
-		init_write_pos = Term->AltWritePos;
+		write_pos_ptr = &Term->AltWritePos;
 		scroll_top = Term->ScrollTop;
 		scroll_height = Term->ScrollHeight;
 	}
@@ -184,32 +200,32 @@ void VT_int_ScrollText(tVTerm *Term, int Count)
 	{
 		buf = Term->Text;
 		height = Term->TextHeight*(giVT_Scrollback+1);
-		init_write_pos = Term->WritePos;
+		write_pos_ptr = &Term->WritePos;
 		scroll_top = 0;
 		scroll_height = height;
 	}
+	
+	const int init_write_pos = *write_pos_ptr;
 
-	// Scroll text downwards	
+	// Scroll text upwards (more space at bottom)
 	if( Count > 0 )
 	{
-		 int	base;
-	
 		// Set up
 		if(Count > scroll_height)	Count = scroll_height;
-		base = Term->TextWidth*(scroll_top + scroll_height - Count);
-		len = Term->TextWidth*(scroll_height - Count);
+		size_t	chars = Term->TextWidth*Count;
+		size_t	base = Term->TextWidth*scroll_top;
+		size_t	len = Term->TextWidth*(scroll_height - Count);
 		
 		// Scroll terminal cache
-		memmove(
-			&buf[Term->TextWidth*scroll_top],
-			&buf[Term->TextWidth*(scroll_top+Count)],
-			len*sizeof(tVT_Char)
-			);
+		ASSERTC( base + chars + len, <=, Term->TextWidth*height );
+		memmove( &buf[base], &buf[base+chars], len*sizeof(tVT_Char) );
+		
 		// Clear last rows
-		for( i = 0; i < Term->TextWidth*Count; i ++ )
+		for( int i = 0; i < chars; i ++ )
 		{
-			buf[ base + i ].Ch = 0;
-			buf[ base + i ].Colour = Term->CurColour;
+			ASSERTC(base + len + i, <, Term->TextWidth*height);
+			buf[ base + len + i ].Ch = 0;
+			buf[ base + len + i ].Colour = Term->CurColour;
 		}
 		
 		// Update Screen
@@ -218,13 +234,10 @@ void VT_int_ScrollText(tVTerm *Term, int Count)
 			Term->AltWritePos = base;
 		else
 			Term->WritePos = Term->ViewPos + Term->TextWidth*(Term->TextHeight - Count);
-		for( i = 0; i < Count; i ++ )
+		for( int i = 0; i < Count; i ++ )
 		{
 			VT_int_UpdateScreen( Term, 0 );
-			if( Term->Flags & VT_FLAG_ALTBUF )
-				Term->AltWritePos += Term->TextWidth;
-			else
-				Term->WritePos += Term->TextWidth;
+			*write_pos_ptr += Term->TextWidth;
 		}
 	}
 	else
@@ -232,40 +245,36 @@ void VT_int_ScrollText(tVTerm *Term, int Count)
 		Count = -Count;
 		if(Count > scroll_height)	Count = scroll_height;
 		
-		len = Term->TextWidth*(scroll_height - Count);
+		size_t	chars = Term->TextWidth*Count;
+		size_t	base = Term->TextWidth*scroll_top;
+		size_t	len = Term->TextWidth*scroll_height - chars;
 		
 		// Scroll terminal cache
-		memmove(
-			&buf[Term->TextWidth*(scroll_top+Count)],
-			&buf[Term->TextWidth*scroll_top],
-			len*sizeof(tVT_Char)
-			);
+		ASSERTC( base + chars + len, <=, Term->TextWidth*height );
+		memmove( &buf[base+chars], &buf[base], len*sizeof(tVT_Char) );
+
 		// Clear preceding rows
-		for( i = 0; i < Term->TextWidth*Count; i ++ )
+		for( int i = 0; i < chars; i ++ )
 		{
 			buf[ i ].Ch = 0;
 			buf[ i ].Colour = Term->CurColour;
 		}
 		
+		// Update screen (shift framebuffer, re-render revealed lines)
 		VT_int_ScrollFramebuffer( Term, -Count );
 		if( Term->Flags & VT_FLAG_ALTBUF )
 			Term->AltWritePos = Term->TextWidth*scroll_top;
 		else
 			Term->WritePos = Term->ViewPos;
-		for( i = 0; i < Count; i ++ )
+		for( int i = 0; i < Count; i ++ )
 		{
 			VT_int_UpdateScreen( Term, 0 );
-			if( Term->Flags & VT_FLAG_ALTBUF )
-				Term->AltWritePos += Term->TextWidth;
-			else
-				Term->WritePos += Term->TextWidth;
 		}
 	}
 	
-	if( Term->Flags & VT_FLAG_ALTBUF )
-		Term->AltWritePos = init_write_pos;
-	else
-		Term->WritePos = init_write_pos;
+	*write_pos_ptr = init_write_pos;
+
+	HEAP_VALIDATE();
 }
 
 /**
@@ -273,21 +282,48 @@ void VT_int_ScrollText(tVTerm *Term, int Count)
  * \param Term	Terminal to modify
  * \param Num	Line number to clear
  */
-void VT_int_ClearLine(tVTerm *Term, int Num)
+void VT_int_ClearLine(tVTerm *Term, int Row)
 {
-	 int	i;
-	tVT_Char	*cell;
+	HEAP_VALIDATE();
+	
+	size_t	height = Term->TextHeight * (Term->Flags & VT_FLAG_ALTBUF ? 1 : giVT_Scrollback + 1);
+	tVT_Char	*buffer = (Term->Flags & VT_FLAG_ALTBUF ? Term->AltBuf : Term->Text);
+	ASSERTCR(Row, >=, 0, );
+	ASSERTCR(Row, <, height, );
+	
+	size_t	base = Row * Term->TextWidth;
 	
-	if( Num < 0 || Num >= Term->TextHeight * (giVT_Scrollback + 1) )	return ;
+	for( int i = 0; i < Term->TextWidth; i ++ )
+	{
+		buffer[ base + i ].Ch = 0;
+		buffer[ base + i ].Colour = Term->CurColour;
+	}
 	
-	cell = (Term->Flags & VT_FLAG_ALTBUF) ? Term->AltBuf : Term->Text;
-	cell = &cell[ Num*Term->TextWidth ];
+	HEAP_VALIDATE();
+}
+
+void VT_int_ClearInLine(tVTerm *Term, int Row, int FirstCol, int LastCol)
+{
+	HEAP_VALIDATE();
 	
-	for( i = Term->TextWidth; i--; )
+	size_t	height = Term->TextHeight * (Term->Flags & VT_FLAG_ALTBUF ? 1 : giVT_Scrollback + 1);
+	tVT_Char	*buffer = (Term->Flags & VT_FLAG_ALTBUF ? Term->AltBuf : Term->Text);
+	ASSERTCR(Row, >=, 0, );
+	ASSERTCR(Row, <, height, );
+
+	ASSERTCR(FirstCol, <=, LastCol, );
+	ASSERTCR(FirstCol, <, Term->TextWidth, );
+	ASSERTCR(LastCol, <=, Term->TextWidth, );
+	
+	size_t	base = Row * Term->TextWidth;
+	for( int i = FirstCol; i < LastCol; i ++ )
 	{
-		cell[ i ].Ch = 0;
-		cell[ i ].Colour = Term->CurColour;
+		ASSERTC(base + i, <, height * Term->TextWidth);
+		buffer[ base + i ].Ch = 0;
+		buffer[ base + i ].Colour = Term->CurColour;
 	}
+	
+	HEAP_VALIDATE();
 }
 
 /**
@@ -297,7 +333,7 @@ void VT_int_ClearLine(tVTerm *Term, int Num)
  * \param NewWidth	New framebuffer width
  * \param NewHeight	New framebuffer height
  */
-void VT_int_ChangeMode(tVTerm *Term, int NewMode, int NewWidth, int NewHeight)
+void VT_int_Resize(tVTerm *Term, int NewWidth, int NewHeight)
 {
 	 int	oldW = Term->Width;
 	 int	oldTW = Term->TextWidth;
@@ -305,14 +341,14 @@ void VT_int_ChangeMode(tVTerm *Term, int NewMode, int NewWidth, int NewHeight)
 	 int	oldTH = Term->TextHeight;
 	tVT_Char	*oldTBuf = Term->Text;
 	Uint32	*oldFB = Term->Buffer;
-	 int	w, h, i;
+	 int	w, h;
+	
+	HEAP_VALIDATE();
 	
 	// TODO: Increase RealWidth/RealHeight when this happens
 	if(NewWidth > giVT_RealWidth)	NewWidth = giVT_RealWidth;
 	if(NewHeight > giVT_RealHeight)	NewHeight = giVT_RealHeight;
 	
-	Term->Mode = NewMode;
-
 	// Fast exit if no resolution change
 	if(NewWidth == Term->Width && NewHeight == Term->Height)
 		return ;
@@ -335,7 +371,7 @@ void VT_int_ChangeMode(tVTerm *Term, int NewMode, int NewWidth, int NewHeight)
 		w = (oldTW > Term->TextWidth) ? Term->TextWidth : oldTW;
 		h = (oldTH > Term->TextHeight) ? Term->TextHeight : oldTH;
 		h *= giVT_Scrollback + 1;
-		for( i = 0; i < h; i ++ )
+		for( int i = 0; i < h; i ++ )
 		{
 			memcpy(
 				&Term->Text[i*Term->TextWidth],
@@ -358,7 +394,7 @@ void VT_int_ChangeMode(tVTerm *Term, int NewMode, int NewWidth, int NewHeight)
 		// Copy old buffer
 		w = (oldW > Term->Width) ? Term->Width : oldW;
 		h = (oldH > Term->Height) ? Term->Height : oldH;
-		for( i = 0; i < h; i ++ )
+		for( int i = 0; i < h; i ++ )
 		{
 			memcpy(
 				&Term->Buffer[i*Term->Width],
@@ -370,7 +406,8 @@ void VT_int_ChangeMode(tVTerm *Term, int NewMode, int NewWidth, int NewHeight)
 	}
 	
 	// Debug
-	switch(NewMode)
+	#if 0
+	switch(Term->Mode)
 	{
 	case TERM_MODE_TEXT:
 		Log_Log("VTerm", "Set VT %p to text mode (%ix%i)",
@@ -384,6 +421,9 @@ void VT_int_ChangeMode(tVTerm *Term, int NewMode, int NewWidth, int NewHeight)
 	//case TERM_MODE_3DACCEL:
 	//	return;
 	}
+	#endif
+
+	HEAP_VALIDATE();
 }