X-Git-Url: https://git.ucc.asn.au/?a=blobdiff_plain;f=KernelLand%2FKernel%2Fmessages.c;h=823742333f55347696a5c3b4dce1baa0f458a072;hb=04a050f42807686dc119838c82372409246d55bb;hp=09c8c14ecc014c934827273792f2471a22f5eef5;hpb=22da3a43e0ef78edafb8b3e36e8062bbeb62f18e;p=tpg%2Facess2.git diff --git a/KernelLand/Kernel/messages.c b/KernelLand/Kernel/messages.c index 09c8c14e..82374233 100644 --- a/KernelLand/Kernel/messages.c +++ b/KernelLand/Kernel/messages.c @@ -78,10 +78,11 @@ int Proc_SendMessage(Uint Dest, int Length, void *Data) * \fn int Proc_GetMessage(Uint *Source, void *Buffer) * \brief Gets a message * \param Source Where to put the source TID + * \param BufSize Size of \a Buffer, only this many bytes will be copied * \param Buffer Buffer to place the message data (set to NULL to just get message length) * \return Message length */ -int Proc_GetMessage(Uint *Source, void *Buffer) +int Proc_GetMessage(Uint *Source, Uint BufSize, void *Buffer) { int ret; void *tmp; @@ -113,7 +114,7 @@ int Proc_GetMessage(Uint *Source, void *Buffer) // Get message if(Buffer != GETMSG_IGNORE) { - if( !CheckMem( Buffer, cur->Messages->Length ) ) + if( !CheckMem( Buffer, BufSize ) ) { LOG("Invalid buffer"); errno = -EINVAL; @@ -121,18 +122,28 @@ int Proc_GetMessage(Uint *Source, void *Buffer) LEAVE('i', -1); return -1; } + if( BufSize < cur->Messages->Length ) + Log_Notice("Threads", "Buffer of 0x%x passed, but 0x%x long message, truncated", + BufSize, cur->Messages->Length); + else if( BufSize < cur->Messages->Length ) + BufSize = cur->Messages->Length; + else + ; // equal LOG("Copied to buffer"); - memcpy(Buffer, cur->Messages->Data, cur->Messages->Length); + memcpy(Buffer, cur->Messages->Data, BufSize); } ret = cur->Messages->Length; // Remove from list tmp = cur->Messages; cur->Messages = cur->Messages->Next; + // - Removed last message? Clear the end-of-list pointer if(cur->Messages == NULL) cur->LastMessage = NULL; + // > Otherwise, re-mark the IPCMSG event flag + else cur->EventState |= THREAD_EVENT_IPCMSG; SHORTREL( &cur->IsLocked ); - + free(tmp); // Free outside of lock LEAVE('i', ret);