X-Git-Url: https://git.ucc.asn.au/?a=blobdiff_plain;f=KernelLand%2FKernel%2Fvfs%2Ffs%2Froot.c;h=abe594576bf62d071164a098e4ff6f050bd9f910;hb=8dcc3e209d0d728565a18c8dca2b0ba220b74a6f;hp=9fa1732b9391f054dc84ba20b57fb055590cdb59;hpb=51ab5f489bc356940c95cc936fd0508e8f07ea97;p=tpg%2Facess2.git

diff --git a/KernelLand/Kernel/vfs/fs/root.c b/KernelLand/Kernel/vfs/fs/root.c
index 9fa1732b..abe59457 100644
--- a/KernelLand/Kernel/vfs/fs/root.c
+++ b/KernelLand/Kernel/vfs/fs/root.c
@@ -16,13 +16,14 @@ tVFS_Node	*Root_InitDevice(const char *Device, const char **Options);
  int	Root_MkNod(tVFS_Node *Node, const char *Name, Uint Flags);
 tVFS_Node	*Root_FindDir(tVFS_Node *Node, const char *Name);
 char	*Root_ReadDir(tVFS_Node *Node, int Pos);
-Uint64	Root_Read(tVFS_Node *Node, Uint64 Offset, Uint64 Length, void *Buffer);
-Uint64	Root_Write(tVFS_Node *Node, Uint64 Offset, Uint64 Length, const void *Buffer);
+size_t	Root_Read(tVFS_Node *Node, off_t Offset, size_t Length, void *Buffer);
+size_t	Root_Write(tVFS_Node *Node, off_t Offset, size_t Length, const void *Buffer);
 tRamFS_File	*Root_int_AllocFile(void);
 
 // === GLOBALS ===
 tVFS_Driver	gRootFS_Info = {
-	"rootfs", 0, Root_InitDevice, NULL, NULL
+	.Name = "rootfs", 
+	.InitDevice = Root_InitDevice
 	};
 tRamFS_File	RootFS_Files[MAX_FILES];
 tVFS_ACL	RootFS_DirACLs[3] = {
@@ -60,7 +61,9 @@ tVFS_Node *Root_InitDevice(const char *Device, const char **Options)
 	
 	// Create Root Node
 	root = &RootFS_Files[0];
-	
+
+	root->Name[0] = '/';
+	root->Name[1] = '\0';
 	root->Node.ImplPtr = root;
 	
 	root->Node.CTime
@@ -69,6 +72,7 @@ tVFS_Node *Root_InitDevice(const char *Device, const char **Options)
 	root->Node.NumACLs = 3;
 	root->Node.ACLs = RootFS_DirACLs;
 
+	root->Node.Flags = VFS_FFLAG_DIRECTORY;
 	root->Node.Type = &gRootFS_DirType;
 	
 	return &root->Node;
@@ -82,20 +86,21 @@ int Root_MkNod(tVFS_Node *Node, const char *Name, Uint Flags)
 {
 	tRamFS_File	*parent = Node->ImplPtr;
 	tRamFS_File	*child;
-	tRamFS_File	*prev = (tRamFS_File *) &parent->Data.FirstChild;
+	tRamFS_File	*prev = NULL;
 	
 	ENTER("pNode sName xFlags", Node, Name, Flags);
 	
-	LOG("%i > %i", strlen(Name)+1, sizeof(child->Name));
+	LOG("Sanity check name length - %i > %i", strlen(Name)+1, sizeof(child->Name));
 	if(strlen(Name) + 1 > sizeof(child->Name))
-		LEAVE_RET('i', 0);
+		LEAVE_RET('i', EINVAL);
 	
 	// Find last child, while we're at it, check for duplication
 	for( child = parent->Data.FirstChild; child; prev = child, child = child->Next )
 	{
 		if(strcmp(child->Name, Name) == 0) {
-			LEAVE('i', 0);
-			return 0;
+			LOG("Duplicate");
+			LEAVE('i', EEXIST);
+			return EEXIST;
 		}
 	}
 	
@@ -103,6 +108,7 @@ int Root_MkNod(tVFS_Node *Node, const char *Name, Uint Flags)
 	memset(child, 0, sizeof(tRamFS_File));
 	
 	strcpy(child->Name, Name);
+	LOG("Name = '%s'", child->Name);
 	
 	child->Parent = parent;
 	child->Next = NULL;
@@ -125,12 +131,16 @@ int Root_MkNod(tVFS_Node *Node, const char *Name, Uint Flags)
 		child->Node.Type = &gRootFS_FileType;
 	}
 	
-	prev->Next = child;
+	// Append!
+	if( prev )
+		prev->Next = child;
+	else
+		parent->Data.FirstChild = child;
 	
 	parent->Node.Size ++;
 	
-	LEAVE('i', 1);
-	return 1;
+	LEAVE('i', EOK);
+	return EOK;
 }
 
 /**
@@ -142,14 +152,19 @@ tVFS_Node *Root_FindDir(tVFS_Node *Node, const char *Name)
 	tRamFS_File	*parent = Node->ImplPtr;
 	tRamFS_File	*child = parent->Data.FirstChild;
 	
-	//Log("Root_FindDir: (Node=%p, Name='%s')", Node, Name);
+	ENTER("pNode sName", Node, Name);
 	
-	for(;child;child = child->Next)
+	for( child = parent->Data.FirstChild; child; child = child->Next )
 	{
-		//Log(" Root_FindDir: strcmp('%s', '%s')", child->Node.Name, Name);
-		if(strcmp(child->Name, Name) == 0)	return &child->Node;
+		LOG("child->Name = '%s'", child->Name);
+		if(strcmp(child->Name, Name) == 0)
+		{
+			LEAVE('p', &child->Node);
+			return &child->Node;
+		}
 	}
 	
+	LEAVE('n');
 	return NULL;
 }
 
@@ -170,39 +185,32 @@ char *Root_ReadDir(tVFS_Node *Node, int Pos)
 }
 
 /**
- * \fn Uint64 Root_Read(tVFS_Node *Node, Uint64 Offset, Uint64 Length, void *Buffer)
  * \brief Read from a file in the root directory
  */
-Uint64 Root_Read(tVFS_Node *Node, Uint64 Offset, Uint64 Length, void *Buffer)
+size_t Root_Read(tVFS_Node *Node, off_t Offset, size_t Length, void *Buffer)
 {
 	tRamFS_File	*file = Node->ImplPtr;
-	ENTER("pNode XOffset XLength pBuffer", Node, Offset, Length, Buffer);
-	
-	if(Offset > Node->Size) {
-		LEAVE('i', 0);
-		return 0;
-	}
-	if(Length > Node->Size)	Length = Node->Size;
 	
+	if(Offset > Node->Size)	return 0;
+
+	if(Length > Node->Size)
+		Length = Node->Size;
 	if(Offset+Length > Node->Size)
 		Length = Node->Size - Offset;
 	
 	memcpy(Buffer, file->Data.Bytes+Offset, Length);
-	LOG("Buffer = '%.*s'", (int)Length, Buffer);
-
-	LEAVE('i', Length);
+	
 	return Length;
 }
 
 /**
- * \fn Uint64 Root_Write(tVFS_Node *Node, Uint64 Offset, Uint64 Length, void *Buffer)
  * \brief Write to a file in the root directory
  */
-Uint64 Root_Write(tVFS_Node *Node, Uint64 Offset, Uint64 Length, const void *Buffer)
+size_t Root_Write(tVFS_Node *Node, off_t Offset, size_t Length, const void *Buffer)
 {
 	tRamFS_File	*file = Node->ImplPtr;
 
-	ENTER("pNode XOffset XLength pBuffer", Node, Offset, Length, Buffer);
+	ENTER("pNode XOffset xLength pBuffer", Node, Offset, Length, Buffer);
 
 	if(Offset > Node->Size) {
 		LEAVE('i', -1);