X-Git-Url: https://git.ucc.asn.au/?a=blobdiff_plain;f=KernelLand%2FModules%2FIPStack%2Ficmp.c;h=f34d790fd01751a1616f91c11857ba203de07298;hb=e14ac96d48bb4ef5cfc845e345df4770e1145ceb;hp=80974ef15f780482f95df563ce5cf1a574352e48;hpb=adbc1540ed20292d7f8be392483f7c15cb0d8e31;p=tpg%2Facess2.git

diff --git a/KernelLand/Modules/IPStack/icmp.c b/KernelLand/Modules/IPStack/icmp.c
index 80974ef1..f34d790f 100644
--- a/KernelLand/Modules/IPStack/icmp.c
+++ b/KernelLand/Modules/IPStack/icmp.c
@@ -26,7 +26,7 @@ struct {
  */
 void ICMP_Initialise()
 {
-	IPv4_RegisterCallback(IP4PROT_ICMP, ICMP_GetPacket);
+	IPv4_RegisterCallback(IP4PROT_ICMP, ICMP_GetPacket, NULL);
 }
 
 /**
@@ -64,12 +64,15 @@ void ICMP_GetPacket(tInterface *Interface, void *Address, int Length, void *Buff
 		{
 		case 3:	// Port Unreachable
 			Log_Debug("ICMPv4", "Destination Unreachable (Port Unreachable)");
+			IPv4_HandleError( Interface, IPERR_PORT_UNREACHABLE,
+				htons(Length)-sizeof(tICMPHeader), hdr->Data );
 			break;
 		default:
 			Log_Debug("ICMPv4", "Destination Unreachable (Code %i)", hdr->Code);
+			IPv4_HandleError( Interface, IPERR_MISC,
+				htons(Length)-sizeof(tICMPHeader), hdr->Data );
 			break;
 		}
-//		IPv4_Unreachable( Interface, hdr->Code, htons(hdr->Length)-sizeof(tICMPHeader), hdr->Data );
 		break;
 	
 	// -- 8: Echo Request
@@ -87,7 +90,6 @@ void ICMP_GetPacket(tInterface *Interface, void *Address, int Length, void *Buff
 		tIPStackBuffer	*buffer = IPStack_Buffer_CreateBuffer(1 + IPV4_BUFFERS);
 		IPStack_Buffer_AppendSubBuffer(buffer, Length, 0, hdr, NULL, NULL);
 		IPv4_SendPacket(Interface, *(tIPv4*)Address, 1, ntohs(hdr->Sequence), buffer);
-		IPStack_Buffer_DestroyBuffer(buffer);
 		break;
 	default:
 		break;
@@ -128,12 +130,11 @@ int ICMP_Ping(tInterface *Interface, tIPv4 Addr)
 	tIPStackBuffer	*buffer = IPStack_Buffer_CreateBuffer(1 + IPV4_BUFFERS);
 	IPStack_Buffer_AppendSubBuffer(buffer, sizeof(buf), 0, buf, NULL, NULL);
 	IPv4_SendPacket(Interface, Addr, 1, i, buffer);
-	IPStack_Buffer_DestroyBuffer(buffer);
 	
 	end = ts + Interface->TimeoutDelay;
 	while( !gICMP_PingSlots[i].bArrived && now() < end)	Threads_Yield();
 	
-	if(now() >= end)
+	if( !gICMP_PingSlots[i].bArrived )
 		return -1;
 	
 	return (int)( now() - ts );