X-Git-Url: https://git.ucc.asn.au/?a=blobdiff_plain;f=Modules%2FIPStack%2Ficmp.c;h=de3a9db5ab606bf49fb5fe9a65957d27121389b8;hb=4f1a9b430a3fa57bbe52a6a2fe546f6fe93c389d;hp=34e6eda4f5f145df7523d1e5a23a7dcedd936f80;hpb=0df427777a3ab005eaeebc1ee4a326c8dfe91b29;p=tpg%2Facess2.git

diff --git a/Modules/IPStack/icmp.c b/Modules/IPStack/icmp.c
index 34e6eda4..de3a9db5 100644
--- a/Modules/IPStack/icmp.c
+++ b/Modules/IPStack/icmp.c
@@ -37,41 +37,56 @@ void ICMP_GetPacket(tInterface *Interface, void *Address, int Length, void *Buff
 {
 	tICMPHeader	*hdr = Buffer;
 	
-	Log("[ICMP ] Length = %i", Length);
-	Log("[ICMP ] hdr->Type = %i", hdr->Type);
-	Log("[ICMP ] hdr->Code = %i", hdr->Code);
-	Log("[ICMP ] hdr->Checksum = 0x%x", ntohs(hdr->Checksum));
-	Log("[ICMP ] hdr->ID = 0x%x", ntohs(hdr->ID));
-	Log("[ICMP ] hdr->Sequence = 0x%x", ntohs(hdr->Sequence));
+	//Log_Debug("ICMPv4", "Length = %i", Length);
+	Log_Debug("ICMPv4", "hdr->Type, hdr->Code = %i, %i", hdr->Type, hdr->Code);
+	//Log_Debug("ICMPv4", "hdr->Checksum = 0x%x", ntohs(hdr->Checksum));
+	Log_Debug("ICMPv4", "hdr->ID = 0x%x", ntohs(hdr->ID));
+	Log_Debug("ICMPv4", "hdr->Sequence = 0x%x", ntohs(hdr->Sequence));
 	
 	switch(hdr->Type)
 	{
 	// -- 0: Echo Reply
 	case ICMP_ECHOREPLY:
 		if(hdr->Code != 0) {
-			Warning("[ICMP ] Code == %i for ICMP Echo Reply, should be 0", hdr->Code);
+			Log_Warning("ICMPv4", "Code == %i for ICMP Echo Reply, should be 0", hdr->Code);
 			return ;
 		}
 		if(hdr->ID != (Uint16)~hdr->Sequence) {
-			Warning("[ICMP ] ID and Sequence values do not match");
-			return ;
+			Log_Warning("ICMPv4", "ID and Sequence values do not match");
+			//return ;
 		}
 		gICMP_PingSlots[hdr->ID].bArrived = 1;
 		break;
 	
+	// -- 3: Destination Unreachable
+	case ICMP_UNREACHABLE:
+		switch(hdr->Code)
+		{
+		case 3:	// Port Unreachable
+			Log_Debug("ICMPv4", "Destination Unreachable (Port Unreachable)");
+			break;
+		default:
+			Log_Debug("ICMPv4", "Destination Unreachable (Code %i)", hdr->Code);
+			break;
+		}
+//		IPv4_Unreachable( Interface, hdr->Code, htons(hdr->Length)-sizeof(tICMPHeader), hdr->Data );
+		break;
+	
 	// -- 8: Echo Request
 	case ICMP_ECHOREQ:
 		if(hdr->Code != 0) {
-			Warning("[ICMP ] Code == %i for ICMP Echo Request, should be 0", hdr->Code);
+			Log_Warning("ICMPv4", "Code == %i for ICMP Echo Request, should be 0", hdr->Code);
 			return ;
 		}
-		Log("[ICMP ] Replying");
+		//Log_Debug("ICMPv4", "Replying");
 		hdr->Type = ICMP_ECHOREPLY;
 		hdr->Checksum = 0;
 		hdr->Checksum = htons( IPv4_Checksum(hdr, Length) );
-		Log("[ICMP ] Checksum = 0x%04x", hdr->Checksum);
+		//Log_Debug("ICMPv4", "Checksum = 0x%04x", hdr->Checksum);
 		IPv4_SendPacket(Interface, *(tIPv4*)Address, 1, ntohs(hdr->Sequence), Length, hdr);
 		break;
+	default:
+		break;
 	}
 	
 }
@@ -95,7 +110,7 @@ int ICMP_Ping(tInterface *Interface, tIPv4 Addr)
 		{
 			if(gICMP_PingSlots[i].Interface == NULL)	break;
 		}
-		if(gICMP_PingSlots[i].Interface == NULL)	break;
+		if( i < PING_SLOTS )	break;
 		Threads_Yield();
 	}
 	gICMP_PingSlots[i].Interface = Interface;
@@ -109,8 +124,7 @@ int ICMP_Ping(tInterface *Interface, tIPv4 Addr)
 	end = ts + Interface->TimeoutDelay;
 	while( !gICMP_PingSlots[i].bArrived && now() < end)	Threads_Yield();
 	
-	ts = now() - ts;
-	if(ts > Interface->TimeoutDelay)
+	if(now() > end)
 		return -1;
 	
 	return (int)ts;