X-Git-Url: https://git.ucc.asn.au/?a=blobdiff_plain;f=Usermode%2FApplications%2FCLIShell_src%2Fmain.c;h=1a501ad17c453dea52cba74bdaeaed8326d247d9;hb=7429a700d87487ff20b5e8a47ff939d80d26f56c;hp=ca06a0584deaab311dba073398690c34d689353c;hpb=001546477549f71fd1af08e13c60e0a39397532a;p=tpg%2Facess2.git

diff --git a/Usermode/Applications/CLIShell_src/main.c b/Usermode/Applications/CLIShell_src/main.c
index ca06a058..1a501ad1 100644
--- a/Usermode/Applications/CLIShell_src/main.c
+++ b/Usermode/Applications/CLIShell_src/main.c
@@ -8,6 +8,7 @@
 #include <string.h>
 #include "header.h"
 #include <readline.h>
+#include <errno.h>
 
 #define _stdin	0
 #define _stdout	1
@@ -80,6 +81,10 @@ int main(int argc, char *argv[], char **envp)
 		// Read Command line
 		sCommandStr = Readline( readline_state );
 		printf("\n");
+		if( !sCommandStr ) {
+			perror("Readline");
+			return 1;
+		}
 		
 		// Parse Command Line into arguments
 		iArgCount = Parse_Args(sCommandStr, saArgs);
@@ -300,27 +305,23 @@ void Command_Cd(int argc, char **argv)
  */
 void Command_Dir(int argc, char **argv)
 {
-	 int	dp, fp, dirLen;
+	 int	dp, fp;
 	char	modeStr[11] = "RWXrwxRWX ";
-	char	tmpPath[1024];
-	char	*fileName;
+	char	fileName[256];
 	t_sysFInfo	info;
 	t_sysACL	acl;
 	
+
+	// -- Generate and open directory --
 	// Generate Directory Path
+	char	tmpPath[1024];
 	if(argc > 1)
-		dirLen = GeneratePath(argv[1], gsCurrentDirectory, tmpPath);
+		GeneratePath(argv[1], gsCurrentDirectory, tmpPath);
 	else
-	{
 		strcpy(tmpPath, gsCurrentDirectory);
-	}
-	dirLen = strlen(tmpPath);
-	
 	// Open Directory
 	dp = _SysOpen(tmpPath, OPENFLAG_READ);
-	// Check if file opened
-	if(dp == -1)
-	{
+	if(dp == -1) {
 		printf("Unable to open directory `%s', File cannot be found\n", tmpPath);
 		return;
 	}
@@ -339,15 +340,7 @@ void Command_Dir(int argc, char **argv)
 		return;
 	}
 	
-	// Append Shash for file paths
-	if(tmpPath[dirLen-1] != '/')
-	{
-		tmpPath[dirLen++] = '/';
-		tmpPath[dirLen] = '\0';
-	}
-	
-	fileName = (char*)(tmpPath+dirLen);
-	// Read Directory Content
+	// -- Read Directory Contents --
 	while( (fp = _SysReadDir(dp, fileName)) )
 	{
 		if(fp < 0)
@@ -357,7 +350,7 @@ void Command_Dir(int argc, char **argv)
 			break;
 		}
 		// Open File
-		fp = _SysOpen(tmpPath, 0);
+		fp = _SysOpenChild(dp, fileName, 0);
 		if(fp == -1)	continue;
 		// Get File Stats
 		_SysFInfo(fp, &info, 0);