X-Git-Url: https://git.ucc.asn.au/?a=blobdiff_plain;f=src%2Fserver%2Fdispense.c;h=b0a59364e5c8ae63479e151adfbf66d3b8148157;hb=0e15ed888a4d398530a74a6b713414e649767358;hp=09fe56785c5ba1fd6bd519faef73473281df9f3c;hpb=d5281ab72f8a105cdc849e4efa602f9fa5c33170;p=tpg%2Fopendispense2.git diff --git a/src/server/dispense.c b/src/server/dispense.c index 09fe567..b0a5936 100644 --- a/src/server/dispense.c +++ b/src/server/dispense.c @@ -3,9 +3,12 @@ #include "common.h" #include #include +#include int _GetMinBalance(int Account); + int _CanTransfer(int Source, int Destination, int Ammount); int _Transfer(int Source, int Destination, int Ammount, const char *Reason); + int _GetSalesAcct(tItem *Item); // === CODE === /** @@ -15,28 +18,29 @@ */ int DispenseItem(int ActualUser, int User, tItem *Item) { - int ret; + int ret, salesAcct; tHandler *handler; char *username, *actualUsername; - char *reason; handler = Item->Handler; + salesAcct = _GetSalesAcct(Item); + + // Check if the user can afford it + if( Item->Price && !_CanTransfer(User, salesAcct, Item->Price) ) + { + return 2; // 2: No balance + } + + // HACK: Naming a slot "dead" disables it + if( strcmp(Item->Name, "dead") == 0 ) + return 1; + // Check if the dispense is possible if( handler->CanDispense ) { ret = handler->CanDispense( User, Item->ID ); if(ret) return 1; // 1: Unable to dispense } - - // Subtract the balance - if( Item->Price ) - { - reason = mkstr("Dispense - %s:%i %s", handler->Name, Item->ID, Item->Name); - if( !reason ) reason = Item->Name; // TODO: Should I instead return an error? - ret = _Transfer( User, Bank_GetAcctByName(COKEBANK_SALES_ACCT), Item->Price, reason); - free(reason); - if(ret) return 2; // 2: No balance - } // Get username for debugging username = Bank_GetAcctName(User); @@ -45,15 +49,22 @@ int DispenseItem(int ActualUser, int User, tItem *Item) if( handler->DoDispense ) { ret = handler->DoDispense( User, Item->ID ); if(ret) { - Log_Error("Dispense failed after deducting cost (%s dispensing %s - %ic)", - username, Item->Name, Item->Price); - if( Item->Price ) - _Transfer( Bank_GetAcctByName(COKEBANK_SALES_ACCT), User, Item->Price, "rollback" ); + Log_Error("Dispense failed (%s dispensing %s:%i '%s')", + username, Item->Handler->Name, Item->ID, Item->Name); free( username ); - return -1; // 1: Unkown Error again + return -1; // 1: Unknown Error again } } + // Take away money + if( Item->Price ) + { + char *reason; + reason = mkstr("Dispense - %s:%i %s", handler->Name, Item->ID, Item->Name); + _Transfer( User, salesAcct, Item->Price, reason ); + free(reason); + } + actualUsername = Bank_GetAcctName(ActualUser); // And log that it happened @@ -67,6 +78,39 @@ int DispenseItem(int ActualUser, int User, tItem *Item) return 0; // 0: EOK } +/** + * \brief Refund a dispense + */ +int DispenseRefund(int ActualUser, int DestUser, tItem *Item, int OverridePrice) +{ + int ret; + int src_acct, price; + char *username, *actualUsername; + + src_acct = _GetSalesAcct(Item); + + if( OverridePrice > 0 ) + price = OverridePrice; + else + price = Item->Price; + + ret = _Transfer( src_acct, DestUser, price, "Refund"); + if(ret) return ret; + + username = Bank_GetAcctName(DestUser); + actualUsername = Bank_GetAcctName(ActualUser); + + Log_Info("refund '%s' (%s:%i) to %s by %s [cost %i, balance %i]", + Item->Name, Item->Handler->Name, Item->ID, + username, actualUsername, price, Bank_GetBalance(DestUser) + ); + + free(username); + free(actualUsername); + + return 0; +} + /** * \brief Give money from one user to another */ @@ -76,6 +120,10 @@ int DispenseGive(int ActualUser, int SrcUser, int DestUser, int Ammount, const c char *actualUsername; char *srcName, *dstName; + // HACK: Naming a slot "dead" disables it (catch for snack) + if( strcmp(ReasonGiven, "dead") == 0 ) + return 1; + if( Ammount < 0 ) return 1; // Um... negative give? Not on my watch! ret = _Transfer( SrcUser, DestUser, Ammount, ReasonGiven ); @@ -86,8 +134,8 @@ int DispenseGive(int ActualUser, int SrcUser, int DestUser, int Ammount, const c srcName = Bank_GetAcctName(SrcUser); dstName = Bank_GetAcctName(DestUser); - Log_Info("give %i to %s from %s by %s [balances %i, %i] - %s", - Ammount, dstName, srcName, actualUsername, + Log_Info("give %i from %s to %s by %s [balances %i, %i] - %s", + Ammount, srcName, dstName, actualUsername, Bank_GetBalance(SrcUser), Bank_GetBalance(DestUser), ReasonGiven ); @@ -99,6 +147,42 @@ int DispenseGive(int ActualUser, int SrcUser, int DestUser, int Ammount, const c return 0; } +#if 0 // Dead Code +/** + * \brief Move money from one user to another (Admin Only) + */ +int DispenseTransfer(int ActualUser, int SrcUser, int DestUser, int Ammount, const char *ReasonGiven) +{ + int ret; + char *actualUsername; + char *srcName, *dstName; + + // Make sure the user is an admin + if( !(Bank_GetFlags(ActualUser) & USER_FLAG_ADMIN) ) + return 1; + + ret = _Transfer( SrcUser, DestUser, Ammount, ReasonGiven ); + if(ret) return 2; // No Balance + + + actualUsername = Bank_GetAcctName(ActualUser); + srcName = Bank_GetAcctName(SrcUser); + dstName = Bank_GetAcctName(DestUser); + + Log_Info("move %i from %s to %s by %s [balances %i, %i] - %s", + Ammount, srcName, dstName, actualUsername, + Bank_GetBalance(SrcUser), Bank_GetBalance(DestUser), + ReasonGiven + ); + + free(srcName); + free(dstName); + free(actualUsername); + + return 0; +} +#endif + /** * \brief Add money to an account */ @@ -107,7 +191,11 @@ int DispenseAdd(int ActualUser, int User, int Ammount, const char *ReasonGiven) int ret; char *dstName, *byName; - ret = _Transfer( Bank_GetAcctByName(COKEBANK_DEBT_ACCT), User, Ammount, ReasonGiven ); +#if DISPENSE_ADD_BELOW_MIN + ret = _Transfer( Bank_GetAcctByName(COKEBANK_DEBT_ACCT,1), User, Ammount, ReasonGiven ); +#else + ret = Bank_Transfer( Bank_GetAcctByName(COKEBANK_DEBT_ACCT,1), User, Ammount, ReasonGiven ); +#endif if(ret) return 2; byName = Bank_GetAcctName(ActualUser); @@ -123,6 +211,26 @@ int DispenseAdd(int ActualUser, int User, int Ammount, const char *ReasonGiven) return 0; } +int DispenseSet(int ActualUser, int User, int Balance, const char *ReasonGiven) +{ + int curBal = Bank_GetBalance(User); + char *byName, *dstName; + + _Transfer( Bank_GetAcctByName(COKEBANK_DEBT_ACCT,1), User, Balance-curBal, ReasonGiven ); + + byName = Bank_GetAcctName(ActualUser); + dstName = Bank_GetAcctName(User); + + Log_Info("set balance of %s to %i by %s [balance %i] - %s", + dstName, Balance, byName, Bank_GetBalance(User), ReasonGiven + ); + + free(byName); + free(dstName); + + return 0; +} + /** * \brief Donate money to the club */ @@ -133,7 +241,7 @@ int DispenseDonate(int ActualUser, int User, int Ammount, const char *ReasonGive if( Ammount < 0 ) return 2; - ret = _Transfer( User, Bank_GetAcctByName(COKEBANK_DEBT_ACCT), Ammount, ReasonGiven ); + ret = _Transfer( User, Bank_GetAcctByName(COKEBANK_DONATE_ACCT,1), Ammount, ReasonGiven ); if(ret) return 2; byName = Bank_GetAcctName(ActualUser); @@ -149,36 +257,98 @@ int DispenseDonate(int ActualUser, int User, int Ammount, const char *ReasonGive return 0; } +int DispenseUpdateItem(int User, tItem *Item, const char *NewName, int NewPrice) +{ + char *username; + + // Sanity checks + if( NewPrice < 0 ) return 2; + if( !Item ) return 2; + if( strlen(NewName) < 1 ) return 2; + + // Update the item + free(Item->Name); + Item->Name = strdup(NewName); + Item->Price = NewPrice; + + username = Bank_GetAcctName(User); + + Log_Info("item %s:%i updated to '%s' %i by %s", + Item->Handler->Name, Item->ID, + NewName, NewPrice, username + ); + + free(username); + + // Update item file + Items_UpdateFile(); + + return 0; +} + // --- Internal Functions --- int _GetMinBalance(int Account) { int flags = Bank_GetFlags(Account); + // Evil little piece of HACK: + // root's balance cannot be changed by any of the above functions + // - Stops dispenses as root by returning insufficent balance. + { + char *username = Bank_GetAcctName(Account); + if( strcmp(username, "root") == 0 ) + { + free(username); + return INT_MAX; + } + free(username); + } + // - Internal accounts have no lower bound if( flags & USER_FLAG_INTERNAL ) return INT_MIN; - // Admin to -$10 - if( flags & USER_FLAG_ADMIN ) return -1000; + // Admin to -$50 +// if( flags & USER_FLAG_ADMIN ) return -5000; - // Coke to -$5 - if( flags & USER_FLAG_COKE ) return -500; + // Coke to -$20 +// if( flags & USER_FLAG_COKE ) return -2000; // Anyone else, non-negative return 0; } -int _Transfer(int Source, int Destination, int Ammount, const char *Reason) +/** + * \brief Check if a transfer is possible + * \return Boolean success + */ +int _CanTransfer(int Source, int Destination, int Ammount) { + if( Bank_GetFlags(Source) & USER_FLAG_DISABLED ) + return 0; if( Ammount > 0 ) { - if( Bank_GetBalance(Source) + Ammount < _GetMinBalance(Source) ) - return 1; + if( Bank_GetBalance(Source) - Ammount < _GetMinBalance(Source) ) + return 0; } else { - if( Bank_GetBalance(Destination) - Ammount < _GetMinBalance(Destination) ) - return 1; + if( Bank_GetBalance(Destination) + Ammount < _GetMinBalance(Destination) ) + return 0; } - + return 1; +} + +int _Transfer(int Source, int Destination, int Ammount, const char *Reason) +{ + if( !_CanTransfer(Source, Destination, Ammount) ) + return 1; return Bank_Transfer(Source, Destination, Ammount, Reason); } + +int _GetSalesAcct(tItem *Item) +{ + char string[sizeof(COKEBANK_SALES_PREFIX)+strlen(Item->Handler->Name)]; + strcpy(string, COKEBANK_SALES_PREFIX); + strcat(string, Item->Handler->Name); + return Bank_GetAcctByName(string, 1); +}