X-Git-Url: https://git.ucc.asn.au/?a=blobdiff_plain;f=src%2Fserver%2Fhandler_coke.c;h=030740c45ccca92b19c26bae12ade3ae4b247691;hb=fdb872c775d0b0e17659cf8f4362952f3c537f01;hp=978e3f5fe538d00c3dba7bb5ed973decdf82eded;hpb=142d8dc0b172eac2e1a735df4bd0fe3461e41252;p=tpg%2Fopendispense2.git

diff --git a/src/server/handler_coke.c b/src/server/handler_coke.c
index 978e3f5..030740c 100644
--- a/src/server/handler_coke.c
+++ b/src/server/handler_coke.c
@@ -6,6 +6,9 @@
  *
  * This file is licenced under the 3-clause BSD Licence. See the file
  * COPYING for full details.
+ *
+ * NOTES:
+ * - Remember, the coke machine echoes your text back to you!
  */
 #include "common.h"
 #include <stdio.h>
@@ -21,6 +24,8 @@
  int	Coke_InitHandler();
  int	Coke_CanDispense(int User, int Item);
  int	Coke_DoDispense(int User, int Item);
+ int	WaitForColon();
+ int	ReadLine(int len, char *output);
 
 // === GLOBALS ===
 tHandler	gCoke_Handler = {
@@ -37,39 +42,77 @@ regex_t	gCoke_StatusRegex;
 int Coke_InitHandler()
 {
 	printf("connecting to coke machine...\n");
-	giCoke_SerialFD = open(gsCoke_SerialPort, O_RDWR);
+	
+	giCoke_SerialFD = InitSerial(gsCoke_SerialPort, 9600);
 	if( giCoke_SerialFD == -1 ) {
 		fprintf(stderr, "ERROR: Unable to open coke serial port ('%s')\n", gsCoke_SerialPort);
 	}
-	regcomp(&gCoke_StatusRegex, "^slot\\s+(\\d)\\s+([^:]+):([a-zA-Z]+)\\s*", REG_EXTENDED);
+	
+	CompileRegex(&gCoke_StatusRegex, "^slot\\s+([0-9]+)\\s+([^:]+):([a-zA-Z]+)\\s*", REG_EXTENDED);
 	return 0;
 }
 
 int Coke_CanDispense(int User, int Item)
 {
-	char	tmp[32], *status;
+	char	tmp[40], *status;
 	regmatch_t	matches[4];
+	 int	ret;
 
 	// Sanity please
-	if( Item < 0 || Item > 6 )	return -1;
+	if( Item < 0 || Item > 6 )	return -1;	// -EYOURBAD
+	
+	ret = 0;
+	do {
+		write(giCoke_SerialFD, "d7\r\n", 4);
+	} while( WaitForColon() && ret++ < 3 );
+
+	if( ret == 3 ) {
+		fprintf(stderr, "Coke machine timed out\n");
+		return -2;	// -EMYBAD
+	}
+
+	// TODO: Handle "not ok" response to D7
 	
 	// Ask the coke machine
-	sprintf(tmp, "s%i\n", Item);
-	write(giCoke_SerialFD, tmp, 2);
+	sprintf(tmp, "s%i\r\n", Item);
+	write(giCoke_SerialFD, tmp, 4);
+
+	// Read from the machine (ignoring empty lines)
+	while( (ret = ReadLine(sizeof(tmp)-1, tmp)) == 0 );
+	printf("ret = %i, tmp = '%s'\n", ret, tmp);
+	if( tmp[0] == ':' ) {
+		ret = ReadLine(sizeof(tmp)-1, tmp);
+		printf("ret = %i, tmp = '%s'\n", ret, tmp);
+	}
+
+	// Catch an error	
+	if( ret <= 0 ) {
+		fprintf(stderr, "Coke machine is not being chatty (read = %i)\n", ret);
+		if( ret == -1 ) {
+			perror("Coke Machine");
+		}
+		return -1;
+	}
 
-	// Read the response
-	read(giCoke_SerialFD, tmp, sizeof(tmp)-1);
-	regexec(&gCoke_StatusRegex, tmp, sizeof(matches)/sizeof(matches[0]), matches, 0);
+	// Eat rest of response
+	WaitForColon();
 
+	// Parse status response
+	ret = RunRegex(&gCoke_StatusRegex, tmp, sizeof(matches)/sizeof(matches[0]), matches, "Bad Response");
+	if( ret ) {
+		return -1;
+	}
+
+	// Get slot status
 	tmp[ matches[3].rm_eo ] = '\0';
 	status = &tmp[ matches[3].rm_so ];
 
 	printf("Machine responded slot status '%s'\n", status);
 
 	if( strcmp(status, "full") == 0 )
-		return 1;
+		return 0;
 
-	return 0;
+	return 1;
 }
 
 /**
@@ -77,26 +120,118 @@ int Coke_CanDispense(int User, int Item)
  */
 int Coke_DoDispense(int User, int Item)
 {
-	char	tmp[32], *status;
-	regmatch_t	matches[4];
+	char	tmp[32];
+	 int	i, ret;
 
 	// Sanity please
 	if( Item < 0 || Item > 6 )	return -1;
 
-	// Dispense
-	sprintf(tmp, "d%i\n", Item);
-	write(giCoke_SerialFD, tmp, 2);
+	// Wait for prompt
+	i = 0;
+	do {
+		write(Item, "d7\r\n", 4);
+	} while( WaitForColon() && i++ < 3 );
 
-	// Get status
-	read(giCoke_SerialFD, tmp, sizeof(tmp)-1);
-	regexec(&gCoke_StatusRegex, tmp, sizeof(matches)/sizeof(matches[0]), matches, 0);
+	// Dispense
+	sprintf(tmp, "d%i\r\n", Item);
+	write(giCoke_SerialFD, tmp, 4);
 	
-	tmp[ matches[3].rm_eo ] = '\0';
-	status = &tmp[ matches[3].rm_so ];
+	// Read empty lines
+	while( (ret = ReadLine(sizeof(tmp)-1, tmp)) == -1 );
+	if( ret == -1 )	return -1;
+	// Read d%i
+	while( tmp[0] == ':' ) {
+		ret = ReadLine(sizeof(tmp)-1, tmp);
+		if( ret == -1 )	return -1;
+	}
+	// Get status
+	ret = ReadLine(sizeof(tmp)-1, tmp);
+	if( ret == -1 )	return -1;
 
-	printf("Machine responded slot status '%s'\n", status);
+	WaitForColon();	// Eat up rest of response
+
+	// TODO: Regex
+	if( strcmp(tmp, "ok") == 0 ) {
+		// We think dispense worked
+		// - The machine returns 'ok' if an empty slot is dispensed, even if
+		//   it doesn't actually try to dispense (no sound)
+		return 0;
+	}
+
+	printf("Machine returned unknown value '%s'\n", tmp);	
 
+	return -1;
+}
+
+char ReadChar()
+{
+	fd_set	readfs;
+	char	ch = 0;
+	 int	ret;
+	struct timeval	timeout;
+	
+	timeout.tv_sec = 5;	// 5 second timeout
+	timeout.tv_usec = 0;
+	
+	FD_ZERO(&readfs);
+	FD_SET(giCoke_SerialFD, &readfs);
+	
+	ret = select(giCoke_SerialFD+1, &readfs, NULL, NULL, &timeout);
+	if( ret == 0 )	return 0;	// Timeout
+	if( ret != 1 ) {
+		printf("readchar return %i\n", ret);
+		return 0;
+	}
+	
+	ret = read(giCoke_SerialFD, &ch, 1);
+	if( ret != 1 ) {
+		printf("ret = %i\n", ret);
+		return 0;
+	}
+	
+	return ch;
+}
+
+int WaitForColon()
+{
+	fd_set	readfs;
+	char	ch = 0;
+	
+	FD_SET(giCoke_SerialFD, &readfs);
+	
+	while( (ch = ReadChar()) != ':' && ch != 0);
+	
+	if( ch == 0 )	return -1;	// Timeout
+	
 	return 0;
 }
 
+int ReadLine(int len, char *output)
+{
+	char	ch;
+	 int	i = 0;
+	
+	for(;;)
+	{
+		ch = ReadChar();
+			
+		if( i < len )
+			output[i++] = ch;
+		
+		if( ch == '\0' ) {
+			break;
+		}
+		if( ch == '\n' || ch == '\r' ) {
+			if( i < len )
+				output[--i] = '\0';
+			break;
+		}
+	}
+
+	//printf("ReadLine: output=%s\n", output);
+
+	if( !ch ) 	return -1;
+	return i;
+}
+