git.ucc.asn.au
/
tpg
/
acess2.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Correctness in ATA driver
[tpg/acess2.git]
/
Kernel
/
vfs
/
open.c
diff --git
a/Kernel/vfs/open.c
b/Kernel/vfs/open.c
index
05f7d29
..
ac47683
100644
(file)
--- a/
Kernel/vfs/open.c
+++ b/
Kernel/vfs/open.c
@@
-3,7
+3,7
@@
* - Open, Close and ChDir
*/
#define DEBUG 0
* - Open, Close and ChDir
*/
#define DEBUG 0
-#include <
common
.h>
+#include <
acess
.h>
#include "vfs.h"
#include "vfs_int.h"
#include "vfs_ext.h"
#include "vfs.h"
#include "vfs_int.h"
#include "vfs_ext.h"
@@
-269,7
+269,7
@@
tVFS_Node *VFS_ParsePath(char *Path, char **TruePath)
// Check permissions on root of filesystem
if( !VFS_CheckACL(curNode, VFS_PERM_EXECUTE) ) {
// Check permissions on root of filesystem
if( !VFS_CheckACL(curNode, VFS_PERM_EXECUTE) ) {
- curNode->Close( curNode );
+
if(curNode->Close)
curNode->Close( curNode );
if(TruePath) {
free(*TruePath);
*TruePath = NULL;
if(TruePath) {
free(*TruePath);
*TruePath = NULL;
@@
-280,7
+280,8
@@
tVFS_Node *VFS_ParsePath(char *Path, char **TruePath)
}
// Check if the node has a FindDir method
}
// Check if the node has a FindDir method
- if(!curNode->FindDir) {
+ if( !curNode->FindDir )
+ {
if(curNode->Close) curNode->Close(curNode);
if(TruePath) {
free(*TruePath);
if(curNode->Close) curNode->Close(curNode);
if(TruePath) {
free(*TruePath);
@@
-295,8
+296,7
@@
tVFS_Node *VFS_ParsePath(char *Path, char **TruePath)
// Get Child Node
tmpNode = curNode->FindDir(curNode, &Path[ofs]);
LOG("tmpNode = %p", tmpNode);
// Get Child Node
tmpNode = curNode->FindDir(curNode, &Path[ofs]);
LOG("tmpNode = %p", tmpNode);
- if(curNode->Close)
- curNode->Close(curNode);
+ if(curNode->Close) curNode->Close(curNode);
curNode = tmpNode;
// Error Check
curNode = tmpNode;
// Error Check
@@
-319,6
+319,13
@@
tVFS_Node *VFS_ParsePath(char *Path, char **TruePath)
*TruePath = NULL;
}
tmp = malloc( curNode->Size + 1 );
*TruePath = NULL;
}
tmp = malloc( curNode->Size + 1 );
+ if(!curNode->Read) {
+ Warning("VFS_ParsePath - Read of node %p is NULL (%s)",
+ curNode, Path);
+ if(curNode->Close) curNode->Close(curNode);
+ LEAVE('n');
+ return NULL;
+ }
curNode->Read( curNode, 0, curNode->Size, tmp );
tmp[ curNode->Size ] = '\0';
curNode->Read( curNode, 0, curNode->Size, tmp );
tmp[ curNode->Size ] = '\0';
@@
-471,7
+478,7
@@
int VFS_Open(char *Path, Uint Mode)
// Permissions Check
if( !VFS_CheckACL(node, i) ) {
// Permissions Check
if( !VFS_CheckACL(node, i) ) {
- node->Close( node );
+
if(node->Close)
node->Close( node );
Log("VFS_Open: Permissions Failed");
LEAVE('i', -1);
return -1;
Log("VFS_Open: Permissions Failed");
LEAVE('i', -1);
return -1;
@@
-550,17
+557,16
@@
void VFS_Close(int FD)
}
/**
}
/**
- * \fn int VFS_ChDir(char *New)
* \brief Change current working directory
*/
* \brief Change current working directory
*/
-int VFS_ChDir(char *
New
)
+int VFS_ChDir(char *
Dest
)
{
char *buf;
int fd;
tVFS_Handle *h;
// Create Absolute
{
char *buf;
int fd;
tVFS_Handle *h;
// Create Absolute
- buf = VFS_GetAbsPath(
New
);
+ buf = VFS_GetAbsPath(
Dest
);
if(buf == NULL) {
Log("VFS_ChDir: Path expansion failed");
return -1;
if(buf == NULL) {
Log("VFS_ChDir: Path expansion failed");
return -1;
UCC
git Repository :: git.ucc.asn.au