git.ucc.asn.au
/
tpg
/
acess2.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
SpiderScript - Cleaning and sorting
[tpg/acess2.git]
/
Modules
/
Network
/
RTL8139
/
rtl8139.c
diff --git
a/Modules/Network/RTL8139/rtl8139.c
b/Modules/Network/RTL8139/rtl8139.c
index
c479d62
..
707b2eb
100644
(file)
--- a/
Modules/Network/RTL8139/rtl8139.c
+++ b/
Modules/Network/RTL8139/rtl8139.c
@@
-80,8
+80,9
@@
typedef struct sCard
char *TransmitBuffers[4];
tPAddr PhysTransmitBuffers[4];
char *TransmitBuffers[4];
tPAddr PhysTransmitBuffers[4];
- BOOL TransmitInUse; // Flags for each transmit descriptor
- int CurTXDecscriptor;
+ tMutex TransmitInUse[4];
+ tMutex CurTXProtector; //!< Protects \a .CurTXDescriptor
+ int CurTXDescriptor;
char Name[2];
tVFS_Node Node;
char Name[2];
tVFS_Node Node;
@@
-160,7
+161,7
@@
int RTL8139_Install(char **Options)
// Set up recieve buffer
// - Allocate 3 pages below 4GiB for the recieve buffer (Allows 8k+16+1500)
card->ReceiveBuffer = (void*)MM_AllocDMA( 3, 32, &card->PhysReceiveBuffer );
// Set up recieve buffer
// - Allocate 3 pages below 4GiB for the recieve buffer (Allows 8k+16+1500)
card->ReceiveBuffer = (void*)MM_AllocDMA( 3, 32, &card->PhysReceiveBuffer );
- card->ReceiveBufferLength = 8*1024
+16
;
+ card->ReceiveBufferLength = 8*1024;
outd(base + RBSTART, (Uint32)card->PhysReceiveBuffer);
outd(base + CBA, 0);
outd(base + CAPR, 0);
outd(base + RBSTART, (Uint32)card->PhysReceiveBuffer);
outd(base + CBA, 0);
outd(base + CAPR, 0);
@@
-183,10
+184,10
@@
int RTL8139_Install(char **Options)
outd(base + TSAD3, card->PhysTransmitBuffers[3]);
// Set recieve buffer size and recieve mask
outd(base + TSAD3, card->PhysTransmitBuffers[3]);
// Set recieve buffer size and recieve mask
- // - Bit 7 being
un
set tells the card to overflow the recieve buffer if needed
+ // - Bit 7 being set tells the card to overflow the recieve buffer if needed
// (i.e. when the packet starts at the end of the bufffer, it overflows up
// to 1500 bytes)
// (i.e. when the packet starts at the end of the bufffer, it overflows up
// to 1500 bytes)
- outd(base + RCR, 0x
0
F);
+ outd(base + RCR, 0x
8
F);
// Recive Enable and Transmit Enable
outb(base + CMD, 0x0C);
// Recive Enable and Transmit Enable
outb(base + CMD, 0x0C);
@@
-269,7
+270,9
@@
retry:
Mutex_Acquire( &card->ReadMutex );
Mutex_Acquire( &card->ReadMutex );
- read_ofs = (inw( card->IOBase + CAPR ) + 0x10) & 0xFFFF;
+ read_ofs = inw( card->IOBase + CAPR );
+ LOG("raw read_ofs = %i", read_ofs);
+ read_ofs = (read_ofs + 0x10) & 0xFFFF;
LOG("read_ofs = %i", read_ofs);
pkt_length = *(Uint16*)&card->ReceiveBuffer[read_ofs+2];
LOG("read_ofs = %i", read_ofs);
pkt_length = *(Uint16*)&card->ReceiveBuffer[read_ofs+2];
@@
-277,13
+280,17
@@
retry:
// Calculate new read offset
new_read_ofs = read_ofs + pkt_length + 4;
new_read_ofs = (new_read_ofs + 3) & ~3; // Align
// Calculate new read offset
new_read_ofs = read_ofs + pkt_length + 4;
new_read_ofs = (new_read_ofs + 3) & ~3; // Align
- if(new_read_ofs > card->ReceiveBufferLength) new_read_ofs = 0;
+ if(new_read_ofs > card->ReceiveBufferLength) {
+ LOG("wrapping read_ofs");
+ new_read_ofs -= card->ReceiveBufferLength;
+ }
new_read_ofs -= 0x10; // I dunno
new_read_ofs -= 0x10; // I dunno
+ LOG("new_read_ofs = %i", new_read_ofs);
// Check for errors
if( *(Uint16*)&card->ReceiveBuffer[read_ofs] & 0x1E ) {
// Update CAPR
// Check for errors
if( *(Uint16*)&card->ReceiveBuffer[read_ofs] & 0x1E ) {
// Update CAPR
- out
d
(card->IOBase + CAPR, new_read_ofs);
+ out
w
(card->IOBase + CAPR, new_read_ofs);
Mutex_Release( &card->ReadMutex );
goto retry; // I feel evil
}
Mutex_Release( &card->ReadMutex );
goto retry; // I feel evil
}
@@
-313,18
+320,20
@@
Uint64 RTL8139_Write(tVFS_Node *Node, Uint64 Offset, Uint64 Length, void *Buffer
ENTER("pNode XLength pBuffer", Node, Length, Buffer);
// TODO: Implement a semaphore for avaliable transmit buffers
ENTER("pNode XLength pBuffer", Node, Length, Buffer);
// TODO: Implement a semaphore for avaliable transmit buffers
-
- td = card->CurTXDecscriptor;
-
+
// Find an avaliable descriptor
// Find an avaliable descriptor
- while( card->TransmitInUse & (1 << td) )
- Threads_Yield();
+ Mutex_Acquire(&card->CurTXProtector);
+ td = card->CurTXDescriptor;
+ card->CurTXDescriptor ++;
+ card->CurTXDescriptor %= 4;
+ Mutex_Release(&card->CurTXProtector);
+ // - Lock it
+ Mutex_Acquire( &card->TransmitInUse[td] );
LOG("td = %i", td);
// Transmit using descriptor `td`
LOG("card->PhysTransmitBuffers[td] = %P", card->PhysTransmitBuffers[td]);
LOG("td = %i", td);
// Transmit using descriptor `td`
LOG("card->PhysTransmitBuffers[td] = %P", card->PhysTransmitBuffers[td]);
- card->TransmitInUse |= (1 << td);
outd(card->IOBase + TSAD0 + td*4, card->PhysTransmitBuffers[td]);
LOG("card->TransmitBuffers[td] = %p", card->TransmitBuffers[td]);
// Copy to buffer
outd(card->IOBase + TSAD0 + td*4, card->PhysTransmitBuffers[td]);
LOG("card->TransmitBuffers[td] = %p", card->TransmitBuffers[td]);
// Copy to buffer
@@
-337,9
+346,6
@@
Uint64 RTL8139_Write(tVFS_Node *Node, Uint64 Offset, Uint64 Length, void *Buffer
LOG("status = 0x%08x", status);
outd(card->IOBase + TSD0 + td*4, status);
LOG("status = 0x%08x", status);
outd(card->IOBase + TSD0 + td*4, status);
- card->CurTXDecscriptor ++;
- card->CurTXDecscriptor %= 4;
-
LEAVE('i', (int)Length);
return Length;
LEAVE('i', (int)Length);
return Length;
@@
-388,7
+394,7
@@
void RTL8139_IRQHandler(int Num)
for( j = 0; j < 4; j ++ )
{
if( ind(card->IOBase + TSD0 + j*4) & 0x8000 ) { // TSD TOK
for( j = 0; j < 4; j ++ )
{
if( ind(card->IOBase + TSD0 + j*4) & 0x8000 ) { // TSD TOK
-
card->TransmitInUse &= ~(1 << j
);
+
Mutex_Release( &card->TransmitInUse[j]
);
// TODO: Update semaphore once implemented
}
}
// TODO: Update semaphore once implemented
}
}
@@
-400,6
+406,7
@@
void RTL8139_IRQHandler(int Num)
{
int read_ofs, end_ofs;
int packet_count = 0;
{
int read_ofs, end_ofs;
int packet_count = 0;
+ int len;
// Scan recieve buffer for packets
end_ofs = inw(card->IOBase + CBA);
// Scan recieve buffer for packets
end_ofs = inw(card->IOBase + CBA);
@@
-410,28
+417,36
@@
void RTL8139_IRQHandler(int Num)
while( read_ofs < card->ReceiveBufferLength )
{
packet_count ++;
while( read_ofs < card->ReceiveBufferLength )
{
packet_count ++;
+ len = *(Uint16*)&card->ReceiveBuffer[read_ofs+2];
LOG("%i 0x%x Pkt Hdr: 0x%04x, len: 0x%04x",
packet_count, read_ofs,
*(Uint16*)&card->ReceiveBuffer[read_ofs],
LOG("%i 0x%x Pkt Hdr: 0x%04x, len: 0x%04x",
packet_count, read_ofs,
*(Uint16*)&card->ReceiveBuffer[read_ofs],
- *(Uint16*)&card->ReceiveBuffer[read_ofs+2]
+ len
);
);
- read_ofs += *(Uint16*)&card->ReceiveBuffer[read_ofs+2] + 4;
+ if(len > 2000) {
+ Log_Warning("RTL8139", "IRQ: Packet in buffer exceeds sanity (%i>2000)", len);
+ }
+ read_ofs += len + 4;
read_ofs = (read_ofs + 3) & ~3; // Align
read_ofs = (read_ofs + 3) & ~3; // Align
-
}
}
- read_ofs = 0;
+ read_ofs -= card->ReceiveBufferLength;
+ LOG("wrapped read_ofs");
}
while( read_ofs < end_ofs )
{
}
while( read_ofs < end_ofs )
{
+ packet_count ++;
LOG("%i 0x%x Pkt Hdr: 0x%04x, len: 0x%04x",
packet_count, read_ofs,
*(Uint16*)&card->ReceiveBuffer[read_ofs],
*(Uint16*)&card->ReceiveBuffer[read_ofs+2]
);
LOG("%i 0x%x Pkt Hdr: 0x%04x, len: 0x%04x",
packet_count, read_ofs,
*(Uint16*)&card->ReceiveBuffer[read_ofs],
*(Uint16*)&card->ReceiveBuffer[read_ofs+2]
);
- packet_count ++;
read_ofs += *(Uint16*)&card->ReceiveBuffer[read_ofs+2] + 4;
read_ofs = (read_ofs + 3) & ~3; // Align
}
read_ofs += *(Uint16*)&card->ReceiveBuffer[read_ofs+2] + 4;
read_ofs = (read_ofs + 3) & ~3; // Align
}
+ if( read_ofs != end_ofs ) {
+ Log_Warning("RTL8139", "IRQ: read_ofs (%i) != end_ofs(%i)", read_ofs, end_ofs);
+ read_ofs = end_ofs;
+ }
card->SeenOfs = read_ofs;
LOG("packet_count = %i, read_ofs = 0x%x", packet_count, read_ofs);
card->SeenOfs = read_ofs;
LOG("packet_count = %i, read_ofs = 0x%x", packet_count, read_ofs);
UCC
git Repository :: git.ucc.asn.au