Kernel - Cleaning up messages
[tpg/acess2.git] / Kernel / threads.c
index b483830..4ab76ff 100644 (file)
@@ -5,12 +5,15 @@
  */
 #include <acess.h>
 #include <threads.h>
+#include <threads_int.h>
 #include <errno.h>
+#include <mutex.h>
 #include <semaphore.h>
 
 // Configuration
 #define DEBUG_TRACE_TICKETS    0       // Trace ticket counts
 #define DEBUG_TRACE_STATE      0       // Trace state changes (sleep/wake)
+#define SEMAPHORE_DEBUG        0
 
 // --- Schedulers ---
 #define SCHED_UNDEF    0
 #define SCHED_RR_SIM   2       // Single Queue Round Robin
 #define SCHED_RR_PRI   3       // Multi Queue Round Robin
 // Set scheduler type
-#define SCHEDULER_TYPE SCHED_LOTTERY
+#define SCHEDULER_TYPE SCHED_RR_PRI
 
 // === CONSTANTS ===
-#define        DEFAULT_QUANTUM 10
+#define        DEFAULT_QUANTUM 5
 #define        DEFAULT_PRIORITY        5
 #define MIN_PRIORITY           10
 const enum eConfigTypes        cCONFIG_TYPES[] = {
@@ -59,6 +62,7 @@ void  Threads_Sleep(void);
 void   Threads_AddActive(tThread *Thread);
 tThread        *Threads_RemActive(void);
 #endif
+void   Threads_ToggleTrace(int TID);
 void   Threads_Fault(int Num);
 void   Threads_SegFault(tVAddr Addr);
 #if 0
@@ -71,7 +75,6 @@ tGID  Threads_GetGID(void);
 #endif
 void   Threads_Dump(void);
 void   Threads_DumpActive(void);
-
 #if 0
  int   Mutex_Acquire(tMutex *Mutex);
 void   Mutex_Release(tMutex *Mutex);
@@ -122,6 +125,9 @@ void Threads_Init(void)
 {
        ArchThreads_Init();
        
+       Log_Debug("Threads", "Offsets of tThread");
+       Log_Debug("Threads", ".Priority = %i", offsetof(tThread, Priority));
+       
        // Create Initial Task
        #if SCHEDULER_TYPE == SCHED_RR_PRI
        gaActiveThreads[gThreadZero.Priority] = &gThreadZero;
@@ -184,6 +190,7 @@ void Threads_SetPriority(tThread *Thread, int Pri)
        if(Thread == NULL)      Thread = Proc_GetCurThread();
        // Bounds checking
        // - If < 0, set to lowest priority
+       // - Minumum priority is actualy a high number, 0 is highest
        if(Pri < 0)     Pri = MIN_PRIORITY;
        if(Pri > MIN_PRIORITY)  Pri = MIN_PRIORITY;
        
@@ -208,7 +215,9 @@ void Threads_SetPriority(tThread *Thread, int Pri)
                #if SCHEDULER_TYPE == SCHED_LOTTERY
                giFreeTickets -= caiTICKET_COUNTS[Thread->Priority] - caiTICKET_COUNTS[Pri];
                # if DEBUG_TRACE_TICKETS
-               Log("Threads_SetTickets: new giFreeTickets = %i", giFreeTickets);
+               Log("Threads_SetTickets: new giFreeTickets = %i [-%i+%i]",
+                       giFreeTickets,
+                       caiTICKET_COUNTS[Thread->Priority], caiTICKET_COUNTS[Pri]);
                # endif
                #endif
                Thread->Priority = Pri;
@@ -217,6 +226,12 @@ void Threads_SetPriority(tThread *Thread, int Pri)
        else
                Thread->Priority = Pri;
        #endif
+       
+       #if DEBUG_TRACE_STATE
+       Log("Threads_SetPriority: %p(%i %s) pri set %i",
+               Thread, Thread->TID, Thread->ThreadName,
+               Pri);
+       #endif
 }
 
 /**
@@ -233,10 +248,7 @@ tThread *Threads_CloneTCB(Uint *Err, Uint Flags)
        
        // Allocate and duplicate
        new = malloc(sizeof(tThread));
-       if(new == NULL) {
-               *Err = -ENOMEM;
-               return NULL;
-       }
+       if(new == NULL) { *Err = -ENOMEM; return NULL; }
        memcpy(new, cur, sizeof(tThread));
        
        new->CurCPU = -1;
@@ -248,6 +260,7 @@ tThread *Threads_CloneTCB(Uint *Err, Uint Flags)
        // Get Thread ID
        new->TID = giNextTID++;
        new->Parent = cur;
+       new->bInstrTrace = 0;
        
        // Clone Name
        new->ThreadName = strdup(cur->ThreadName);
@@ -334,6 +347,7 @@ tThread *Threads_CloneThreadZero(void)
        // Set State
        new->Remaining = new->Quantum = cur->Quantum;
        new->Priority = cur->Priority;
+       new->bInstrTrace = 0;
        
        // Set Signal Handlers
        new->CurFaultNum = 0;
@@ -742,6 +756,56 @@ int Threads_Wake(tThread *Thread)
                SHORTREL( &glThreadListLock );
                return -EOK;
        
+       case THREAD_STAT_SEMAPHORESLEEP: {
+               tSemaphore      *sem;
+               tThread *th, *prev=NULL;
+               
+               sem = Thread->WaitPointer;
+               
+               SHORTLOCK( &sem->Protector );
+               
+               // Remove from sleeping queue
+               for( th = sem->Waiting; th; prev = th, th = th->Next )
+                       if( th == Thread )      break;
+               if( th )
+               {
+                       if(prev)
+                               prev->Next = Thread->Next;
+                       else
+                               sem->Waiting = Thread->Next;
+                       if(sem->LastWaiting == Thread)
+                               sem->LastWaiting = prev;
+               }
+               else
+               {
+                       prev = NULL;
+                       for( th = sem->Signaling; th; prev = th, th = th->Next )
+                               if( th == Thread )      break;
+                       if( !th ) {
+                               Log_Warning("Threads", "Thread %p(%i %s) is not on semaphore %p(%s:%s)",
+                                       Thread, Thread->TID, Thread->ThreadName,
+                                       sem, sem->ModName, sem->Name);
+                               return -EINTERNAL;
+                       }
+                       
+                       if(prev)
+                               prev->Next = Thread->Next;
+                       else
+                               sem->Signaling = Thread->Next;
+                       if(sem->LastSignaling == Thread)
+                               sem->LastSignaling = prev;
+               }
+               
+               SHORTLOCK( &glThreadListLock );
+               Threads_AddActive( Thread );
+               SHORTREL( &glThreadListLock );
+               
+               #if DEBUG_TRACE_STATE
+               Log("Threads_Sleep: %p(%i %s) woken from semaphore", Thread, Thread->TID, Thread->ThreadName);
+               #endif
+               SHORTREL( &sem->Protector );
+               } return -EOK;
+       
        case THREAD_STAT_WAITING:
                Warning("Threads_Wake - Waiting threads are not currently supported");
                return -ENOTIMPL;
@@ -772,6 +836,13 @@ int Threads_WakeTID(tTID TID)
        return ret;
 }
 
+void Threads_ToggleTrace(int TID)
+{
+       tThread *thread = Threads_GetThread(TID);
+       if(!thread)     return ;
+       thread->bInstrTrace = !thread->bInstrTrace;
+}
+
 /**
  * \brief Adds a thread to the active queue
  */
@@ -789,14 +860,25 @@ void Threads_AddActive(tThread *Thread)
        
        // Set state
        Thread->Status = THREAD_STAT_ACTIVE;
+//     Thread->CurCPU = -1;
        // Add to active list
-       #if SCHEDULER_TYPE == SCHED_RR_PRI
-       Thread->Next = gaActiveThreads[Thread->Priority];
-       gaActiveThreads[Thread->Priority] = Thread;
-       #else
-       Thread->Next = gActiveThreads;
-       gActiveThreads = Thread;
-       #endif
+       {
+               tThread *tmp, *prev = NULL;
+               #if SCHEDULER_TYPE == SCHED_RR_PRI
+               for( tmp = gaActiveThreads[Thread->Priority]; tmp; prev = tmp, tmp = tmp->Next );
+               if(prev)
+                       prev->Next = Thread;
+               else
+                       gaActiveThreads[Thread->Priority] = Thread;
+               #else
+               for( tmp = gActiveThreads; tmp; prev = tmp, tmp = tmp->Next );
+               if(prev)
+                       prev->Next = Thread;
+               else
+                       gActiveThreads = Thread;
+               #endif
+               Thread->Next = NULL;
+       }
        
        // Update bookkeeping
        giNumActiveThreads ++;
@@ -842,6 +924,9 @@ tThread *Threads_RemActive(void)
        #endif
        {
                SHORTREL( &glThreadListLock );
+               Log_Warning("Threads", "Current thread %p(%i %s) is not on active queue",
+                       ret, ret->TID, ret->ThreadName
+                       );
                return NULL;
        }
        
@@ -879,8 +964,6 @@ void Threads_Fault(int Num)
 {
        tThread *thread = Proc_GetCurThread();
        
-       Log_Log("Threads", "Threads_Fault: thread = %p", thread);
-       
        if(!thread)     return ;
        
        Log_Log("Threads", "Threads_Fault: thread->FaultHandler = %p", thread->FaultHandler);
@@ -987,6 +1070,8 @@ void Threads_DumpActive(void)
                                Log("  ERROR State (%i) != THREAD_STAT_ACTIVE (%i)", thread->Status, THREAD_STAT_ACTIVE);
                        Log("  Priority %i, Quantum %i", thread->Priority, thread->Quantum);
                        Log("  KStack 0x%x", thread->KernelStack);
+                       if( thread->bInstrTrace )
+                               Log("  Tracing Enabled");
                        Proc_DumpThreadCPUState(thread);
                }
        
@@ -1031,6 +1116,9 @@ void Threads_Dump(void)
                }
                Log("  Priority %i, Quantum %i", thread->Priority, thread->Quantum);
                Log("  KStack 0x%x", thread->KernelStack);
+               if( thread->bInstrTrace )
+                       Log("  Tracing Enabled");
+               Proc_DumpThreadCPUState(thread);
        }
 }
 
@@ -1058,6 +1146,7 @@ tThread *Threads_GetNextToRun(int CPU, tThread *Last)
        // Clear Delete Queue
        // - I should probably put this in a worker thread to avoid calling free() in the scheduler
        //   DEFINITELY - free() can deadlock in this case
+       //   I'll do it when it becomes an issue
        while(gDeleteThreads)
        {
                thread = gDeleteThreads->Next;
@@ -1078,7 +1167,10 @@ tThread *Threads_GetNextToRun(int CPU, tThread *Last)
                }
                gDeleteThreads = thread;
        }
-       
+
+       // Make sure the current (well, old) thread is marked as de-scheduled   
+       if(Last)        Last->CurCPU = -1;
+
        // No active threads, just take a nap
        if(giNumActiveThreads == 0) {
                SHORTREL( &glThreadListLock );
@@ -1117,7 +1209,7 @@ tThread *Threads_GetNextToRun(int CPU, tThread *Last)
                }
                #if SCHEDULER_TYPE == SCHED_LOTTERY && DEBUG_TRACE_TICKETS
                else
-                       LogF("Log: CPU%i released %p (%i %s)->Status = %i (Released)\n",
+                       LogF("Log: CPU%i released %p (%i %s)->Status = %i (Released,not in pool)\n",
                                CPU, Last, Last->TID, Last->ThreadName, Last->Status);
                #endif
                Last->CurCPU = -1;
@@ -1255,16 +1347,7 @@ tThread *Threads_GetNextToRun(int CPU, tThread *Last)
        return thread;
 }
 
-/**
- * \brief Acquire a heavy mutex
- * \param Mutex        Mutex to acquire
- * 
- * This type of mutex checks if the mutex is avaliable, and acquires it
- * if it is. Otherwise, the current thread is added to the mutex's wait
- * queue and the thread suspends. When the holder of the mutex completes,
- * the oldest thread (top thread) on the queue is given the lock and
- * restarted.
- */
+// Acquire mutex (see mutex.h for documentation)
 int Mutex_Acquire(tMutex *Mutex)
 {
        tThread *us = Proc_GetCurThread();
@@ -1293,6 +1376,12 @@ int Mutex_Acquire(tMutex *Mutex)
                        Mutex->Waiting = us;
                        Mutex->LastWaiting = us;
                }
+               
+               #if DEBUG_TRACE_STATE
+               Log("%p (%i %s) waiting on mutex %p",
+                       us, us->TID, us->ThreadName, Mutex);
+               #endif
+               
                #if 0
                {
                         int    i = 0;
@@ -1324,11 +1413,7 @@ int Mutex_Acquire(tMutex *Mutex)
        return 0;
 }
 
-/**
- * \brief Release a held mutex
- * \param Mutex        Mutex to release
- * \note Releasing a non-held mutex has no effect
- */
+// Release a mutex
 void Mutex_Release(tMutex *Mutex)
 {
        SHORTLOCK( &Mutex->Protector );
@@ -1361,10 +1446,7 @@ void Mutex_Release(tMutex *Mutex)
        #endif
 }
 
-/**
- * \brief Is this mutex locked?
- * \param Mutex        Mutex pointer
- */
+// Check if a mutex is locked
 int Mutex_IsLocked(tMutex *Mutex)
 {
        return Mutex->Owner != NULL;
@@ -1403,7 +1485,6 @@ int Semaphore_Wait(tSemaphore *Sem, int MaxToTake)
                else
                        taken = Sem->Value;
                Sem->Value -= taken;
-               SHORTREL( &Sem->Protector );
        }
        else
        {
@@ -1427,10 +1508,16 @@ int Semaphore_Wait(tSemaphore *Sem, int MaxToTake)
                        Sem->LastWaiting = us;
                }
                
+               #if DEBUG_TRACE_STATE || SEMAPHORE_DEBUG
+               Log("%p (%i %s) waiting on semaphore %p %s:%s",
+                       us, us->TID, us->ThreadName,
+                       Sem, Sem->ModName, Sem->Name);
+               #endif
+               
+               SHORTREL( &Sem->Protector );    // Release first to make sure it is released
                SHORTREL( &glThreadListLock );  
-               SHORTREL( &Sem->Protector );
                while(us->Status == THREAD_STAT_SEMAPHORESLEEP) Threads_Yield();
-               // We're only woken when there's something avaliable
+               // We're only woken when there's something avaliable (or a signal arrives)
                us->WaitPointer = NULL;
                
                taken = us->RetStatus;
@@ -1458,6 +1545,13 @@ int Semaphore_Wait(tSemaphore *Sem, int MaxToTake)
                        given = Sem->MaxValue - Sem->Value;
                Sem->Value -= given;
                
+               
+               #if DEBUG_TRACE_STATE || SEMAPHORE_DEBUG
+               Log("%p (%i %s) woken by wait on %p %s:%s",
+                       toWake, toWake->TID, toWake->ThreadName,
+                       Sem, Sem->ModName, Sem->Name);
+               #endif
+               
                // Save the number we gave to the thread's status
                toWake->RetStatus = given;
                
@@ -1514,6 +1608,12 @@ int Semaphore_Signal(tSemaphore *Sem, int AmmountToAdd)
                        Sem->LastSignaling = us;
                }
                
+               #if DEBUG_TRACE_STATE || SEMAPHORE_DEBUG
+               Log("%p (%i %s) signaling semaphore %p %s:%s",
+                       us, us->TID, us->ThreadName,
+                       Sem, Sem->ModName, Sem->Name);
+               #endif
+               
                SHORTREL( &glThreadListLock );  
                SHORTREL( &Sem->Protector );
                while(us->Status == THREAD_STAT_SEMAPHORESLEEP) Threads_Yield();
@@ -1542,12 +1642,13 @@ int Semaphore_Signal(tSemaphore *Sem, int AmmountToAdd)
        {
                tThread *toWake = Sem->Waiting;
                
+               // Remove thread from list (double ended, so clear LastWaiting if needed)
                Sem->Waiting = Sem->Waiting->Next;
-               // Reset ->LastWaiting to NULL if we have just removed the last waiting thread
                if( Sem->Waiting == NULL )
                        Sem->LastWaiting = NULL;
                
-               // Figure out how much to give
+               // Figure out how much to give to woken thread
+               // - Requested count is stored in ->RetStatus
                if( toWake->RetStatus && Sem->Value > toWake->RetStatus )
                        given = toWake->RetStatus;
                else
@@ -1557,10 +1658,20 @@ int Semaphore_Signal(tSemaphore *Sem, int AmmountToAdd)
                // Save the number we gave to the thread's status
                toWake->RetStatus = given;
                
+               if(toWake->bInstrTrace)
+                       Log("%s(%i) given %i from %p", toWake->ThreadName, toWake->TID, given, Sem);
+               #if DEBUG_TRACE_STATE || SEMAPHORE_DEBUG
+               Log("%p (%i %s) woken by signal on %p %s:%s",
+                       toWake, toWake->TID, toWake->ThreadName,
+                       Sem, Sem->ModName, Sem->Name);
+               #endif
+               
                // Wake the sleeper
                SHORTLOCK( &glThreadListLock );
                if( toWake->Status != THREAD_STAT_ACTIVE )
                        Threads_AddActive(toWake);
+               else
+                       Warning("Thread %p (%i %s) is already awake", toWake, toWake->TID, toWake->ThreadName);
                SHORTREL( &glThreadListLock );
        }
        SHORTREL( &Sem->Protector );

UCC git Repository :: git.ucc.asn.au