Modules/IPStack - Fix UDP checksums, logging cleanup

[tpg/acess2.git] / KernelLand / Modules / IPStack / ipv4.c

diff --git a/KernelLand/Modules/IPStack/ipv4.c b/KernelLand/Modules/IPStack/ipv4.c
index 3162301..71a0533 100644 (file)
--- a/KernelLand/Modules/IPStack/ipv4.c
+++ b/KernelLand/Modules/IPStack/ipv4.c
@@ -8,7 +8,9 @@
 #include "ipv4.h"
 #include "firewall.h"
 
+// === CONSTANTS ===
 #define DEFAULT_TTL    32
+#define IPV4_TRACE     1       // set to 1 to enable packet tracing
 
 // === IMPORTS ===
 extern tInterface      *gIP_Interfaces;
@@ -118,8 +120,10 @@ int IPv4_SendPacket(tInterface *Iface, tIPv4 Address, int Protocol, int ID, tIPS
 
        IPStack_Buffer_AppendSubBuffer(Buffer, sizeof(tIPv4Header), 0, &hdr, NULL, NULL);
 
+       #if IPV4_TRACE
        Log_Log("IPv4", "Sending packet to %i.%i.%i.%i",
                Address.B[0], Address.B[1], Address.B[2], Address.B[3]);
+       #endif
        Link_SendPacket(Iface->Adapter, IPV4_ETHERNET_ID, to, Buffer);
        return 1;
 }
@@ -181,18 +185,20 @@ void IPv4_int_GetPacket(tAdapter *Adapter, tMacAddr From, int Length, void *Buff
        
        // TODO: Handle packet fragmentation
        
-       
+       #if IPV4_TRACE
        Log_Debug("IPv4", " From %i.%i.%i.%i to %i.%i.%i.%i",
                hdr->Source.B[0], hdr->Source.B[1], hdr->Source.B[2], hdr->Source.B[3],
                hdr->Destination.B[0], hdr->Destination.B[1], hdr->Destination.B[2], hdr->Destination.B[3]
                );
-
-       // TODO: Tell ARP?
-       ARP_UpdateCache4(hdr->Source, From);
+       #endif
        
        // Get Data and Data Length
        dataLength = ntohs(hdr->TotalLength) - sizeof(tIPv4Header);
        data = &hdr->Options[0];
+
+       // Populate ARP cache from sniffing.
+       // - Downside: Poisoning, polluting from routed packets
+       //ARP_UpdateCache4(hdr->Source, From);
        
        // Get Interface (allowing broadcasts)
        iface = IPv4_GetInterface(Adapter, hdr->Destination, 1);
@@ -234,9 +240,12 @@ void IPv4_int_GetPacket(tAdapter *Adapter, tMacAddr From, int Length, void *Buff
        // Routing
        if(!iface)
        {
+               #if 0
                tMacAddr        to;
                tRoute  *rt;
-               
+       
+
+               // TODO: Put this in another thread to avoid delays in the RX thread    
                Log_Debug("IPv4", "Route the packet");
                // Drop the packet if the TTL is zero
                if( hdr->TTL == 0 ) {
@@ -261,9 +270,14 @@ void IPv4_int_GetPacket(tAdapter *Adapter, tMacAddr From, int Length, void *Buff
                        ((tIPv4*)rt->NextHop)->B[2], ((tIPv4*)rt->NextHop)->B[3]);
                Log_Warning("IPv4", "TODO: Implement forwarding with tIPStackBuffer");
 //             Link_SendPacket(rt->Interface->Adapter, IPV4_ETHERNET_ID, to, Length, Buffer);
+               #endif
                
                return ;
        }
+
+       // Populate ARP cache from recieved packets
+       // - Should be safe
+       ARP_UpdateCache4(hdr->Source, From);
        
        // Send it on
        if( !gaIPv4_Callbacks[hdr->Protocol] ) {
@@ -283,7 +297,7 @@ void IPv4_int_GetPacket(tAdapter *Adapter, tMacAddr From, int Length, void *Buff
  */
 tInterface *IPv4_GetInterface(tAdapter *Adapter, tIPv4 Address, int Broadcast)
 {
-       tInterface      *iface = NULL;
+       tInterface      *iface = NULL, *zero_iface = NULL;
        Uint32  netmask;
        Uint32  addr, this;
 
@@ -301,7 +315,20 @@ tInterface *IPv4_GetInterface(tAdapter *Adapter, tIPv4 Address, int Broadcast)
                        LEAVE('p', iface);
                        return iface;
                }
-               
+
+               LOG("iface->Address = 0x%x", *(Uint32*)iface->Address);
+
+               if( *(Uint32*)iface->Address == 0 ) {
+                       if( zero_iface ) {
+                               Log_Notice("IPv4", "Multiple 0.0.0.0 interfaces on the same adapter, ignoring");
+                       }
+                       else {
+                               zero_iface = iface;
+                               LOG("Zero IF %p", iface);
+                       }
+                       continue ;
+               }               
+
                if( !Broadcast )        continue;
                
                // Check for broadcast
@@ -316,6 +343,17 @@ tInterface *IPv4_GetInterface(tAdapter *Adapter, tIPv4 Address, int Broadcast)
                        return iface;
                }
        }
+
+       // Special case for intefaces that are being DHCP configured
+       // - If the interface address is 0.0.0.0, then if there is no match for the
+       //   destination the packet is treated as if it was addressed to 0.0.0.0
+       if( zero_iface && Broadcast )
+       {
+               LOG("Using 0.0.0.0 interface with magic!");
+               LEAVE('p', zero_iface);
+               return zero_iface;
+       }
+
        LEAVE('n');
        return NULL;
 }