Modules/IPStack - Killing Threads_Yield
[tpg/acess2.git] / KernelLand / Modules / IPStack / tcp.c
index 20c22f8..8b4f99d 100644 (file)
@@ -2,7 +2,7 @@
  * Acess2 IP Stack
  * - TCP Handling
  */
-#define DEBUG  1
+#define DEBUG  0
 #include "ipstack.h"
 #include "ipv4.h"
 #include "ipv6.h"
 
 #define TCP_MAX_PACKET_SIZE    1024
 #define TCP_WINDOW_SIZE        0x2000
-#define TCP_RECIEVE_BUFFER_SIZE        0x4000
+#define TCP_RECIEVE_BUFFER_SIZE        0x8000
+#define TCP_DACK_THRESHOLD     4096
+#define TCP_DACK_TIMEOUT       500
 
 // === PROTOTYPES ===
 void   TCP_Initialise(void);
 void   TCP_StartConnection(tTCPConnection *Conn);
-void   TCP_SendPacket(tTCPConnection *Conn, size_t Length, tTCPHeader *Data);
+void   TCP_SendPacket(tTCPConnection *Conn, tTCPHeader *Header, size_t DataLen, const void *Data);
 void   TCP_GetPacket(tInterface *Interface, void *Address, int Length, void *Buffer);
 void   TCP_INT_HandleConnectionPacket(tTCPConnection *Connection, tTCPHeader *Header, int Length);
 int    TCP_INT_AppendRecieved(tTCPConnection *Connection, const void *Data, size_t Length);
 void   TCP_INT_UpdateRecievedFromFuture(tTCPConnection *Connection);
+void   TCP_INT_SendACK(tTCPConnection *Connection);
 Uint16 TCP_GetUnusedPort();
  int   TCP_AllocatePort(Uint16 Port);
  int   TCP_DeallocatePort(Uint16 Port);
 // --- Server
 tVFS_Node      *TCP_Server_Init(tInterface *Interface);
-char   *TCP_Server_ReadDir(tVFS_Node *Node, int Pos);
+ int   TCP_Server_ReadDir(tVFS_Node *Node, int Pos, char Name[FILENAME_MAX]);
 tVFS_Node      *TCP_Server_FindDir(tVFS_Node *Node, const char *Name);
  int   TCP_Server_IOCtl(tVFS_Node *Node, int ID, void *Data);
 void   TCP_Server_Close(tVFS_Node *Node);
@@ -94,30 +97,42 @@ void TCP_Initialise(void)
  * \param Length       Length of data
  * \param Data Packet data (cast as a TCP Header)
  */
-void TCP_SendPacket( tTCPConnection *Conn, size_t Length, tTCPHeader *Data )
+void TCP_SendPacket( tTCPConnection *Conn, tTCPHeader *Header, size_t Length, const void *Data )
 {
-       Uint16  checksum[2];
-       
-       Data->Checksum = 0;
-       checksum[1] = htons( ~IPv4_Checksum( (void*)Data, Length ) );   // Partial checksum
-       if(Length & 1)
-               ((Uint8*)Data)[Length] = 0;
+       tIPStackBuffer  *buffer;
+       Uint16  checksum[3];
+        int    packlen = sizeof(*Header) + Length;
+       
+       buffer = IPStack_Buffer_CreateBuffer(2 + IPV4_BUFFERS);
+       if( Data && Length )
+               IPStack_Buffer_AppendSubBuffer(buffer, Length, 0, Data, NULL, NULL);
+       IPStack_Buffer_AppendSubBuffer(buffer, sizeof(*Header), 0, Header, NULL, NULL);
+
+       LOG("Sending %i+%i to %s:%i", sizeof(*Header), Length,
+               IPStack_PrintAddress(Conn->Interface->Type, &Conn->RemoteIP),
+               Conn->RemotePort
+               );
+
+       Header->Checksum = 0;
+       checksum[1] = htons( ~IPv4_Checksum(Header, sizeof(tTCPHeader)) );
+       checksum[2] = htons( ~IPv4_Checksum(Data, Length) );
        
        // TODO: Fragment packet
        
        switch( Conn->Interface->Type )
        {
        case 4:
-               // Append IPv4 Pseudo Header
+               // Get IPv4 pseudo-header checksum
                {
                        Uint32  buf[3];
                        buf[0] = ((tIPv4*)Conn->Interface->Address)->L;
                        buf[1] = Conn->RemoteIP.v4.L;
-                       buf[2] = (htons(Length)<<16) | (6<<8) | 0;
+                       buf[2] = (htons(packlen)<<16) | (6<<8) | 0;
                        checksum[0] = htons( ~IPv4_Checksum(buf, sizeof(buf)) );        // Partial checksum
                }
-               Data->Checksum = htons( IPv4_Checksum(checksum, 2*2) ); // Combine the two
-               IPv4_SendPacket(Conn->Interface, Conn->RemoteIP.v4, IP4PROT_TCP, 0, Length, Data);
+               // - Combine checksums
+               Header->Checksum = htons( IPv4_Checksum(checksum, sizeof(checksum)) );
+               IPv4_SendPacket(Conn->Interface, Conn->RemoteIP.v4, IP4PROT_TCP, 0, buffer);
                break;
                
        case 6:
@@ -126,11 +141,11 @@ void TCP_SendPacket( tTCPConnection *Conn, size_t Length, tTCPHeader *Data )
                        Uint32  buf[4+4+1+1];
                        memcpy(buf, Conn->Interface->Address, 16);
                        memcpy(&buf[4], &Conn->RemoteIP, 16);
-                       buf[8] = htonl(Length);
+                       buf[8] = htonl(packlen);
                        buf[9] = htonl(6);
                        checksum[0] = htons( ~IPv4_Checksum(buf, sizeof(buf)) );        // Partial checksum
                }
-               Data->Checksum = htons( IPv4_Checksum(checksum, 2*2) ); // Combine the two
+               Header->Checksum = htons( IPv4_Checksum(checksum, sizeof(checksum)) );  // Combine the two
                IPv6_SendPacket(Conn->Interface, Conn->RemoteIP.v6, IP4PROT_TCP, Length, Data);
                break;
        }
@@ -149,7 +164,7 @@ void TCP_GetPacket(tInterface *Interface, void *Address, int Length, void *Buffe
        tTCPListener    *srv;
        tTCPConnection  *conn;
 
-       Log_Log("TCP", "TCP_GetPacket: <Local>:%i from [%s]:%i, Flags= %s%s%s%s%s%s%s%s",
+       Log_Log("TCP", "TCP_GetPacket: <Local>:%i from [%s]:%i, Flags = %s%s%s%s%s%s%s%s",
                ntohs(hdr->DestPort),
                IPStack_PrintAddress(Interface->Type, Address),
                ntohs(hdr->SourcePort),
@@ -165,7 +180,7 @@ void TCP_GetPacket(tInterface *Interface, void *Address, int Length, void *Buffe
 
        if( Length > (hdr->DataOffset >> 4)*4 )
        {
-               Log_Log("TCP", "TCP_GetPacket: SequenceNumber = 0x%x", ntohl(hdr->SequenceNumber));
+               LOG("SequenceNumber = 0x%x", ntohl(hdr->SequenceNumber));
 #if HEXDUMP_INCOMING
                Debug_HexDump(
                        "TCP_GetPacket: Packet Data = ",
@@ -176,107 +191,105 @@ void TCP_GetPacket(tInterface *Interface, void *Address, int Length, void *Buffe
        }
 
        // Check Servers
+       for( srv = gTCP_Listeners; srv; srv = srv->Next )
        {
-               for( srv = gTCP_Listeners; srv; srv = srv->Next )
+               // Check if the server is active
+               if(srv->Port == 0)      continue;
+               // Check the interface
+               if(srv->Interface && srv->Interface != Interface)       continue;
+               // Check the destination port
+               if(srv->Port != htons(hdr->DestPort))   continue;
+               
+               Log_Log("TCP", "TCP_GetPacket: Matches server %p", srv);
+               // Is this in an established connection?
+               for( conn = srv->Connections; conn; conn = conn->Next )
                {
-                       // Check if the server is active
-                       if(srv->Port == 0)      continue;
-                       // Check the interface
-                       if(srv->Interface && srv->Interface != Interface)       continue;
-                       // Check the destination port
-                       if(srv->Port != htons(hdr->DestPort))   continue;
-                       
-                       Log_Log("TCP", "TCP_GetPacket: Matches server %p", srv);
-                       // Is this in an established connection?
-                       for( conn = srv->Connections; conn; conn = conn->Next )
-                       {
-                               // Check that it is coming in on the same interface
-                               if(conn->Interface != Interface)        continue;
-
-                               // Check Source Port
-                               Log_Log("TCP", "TCP_GetPacket: conn->RemotePort(%i) == hdr->SourcePort(%i)",
-                                       conn->RemotePort, ntohs(hdr->SourcePort));
-                               if(conn->RemotePort != ntohs(hdr->SourcePort))  continue;
-
-                               // Check Source IP
-                               Log_Debug("TCP", "TCP_GetPacket: conn->RemoteIP(%s)",
-                                       IPStack_PrintAddress(conn->Interface->Type, &conn->RemoteIP));
-                               Log_Debug("TCP", "                == Address(%s)",
-                                       IPStack_PrintAddress(conn->Interface->Type, Address));
-                               if( IPStack_CompareAddress(conn->Interface->Type, &conn->RemoteIP, Address, -1) == 0 )
-                                       continue ;
-
-                               Log_Log("TCP", "TCP_GetPacket: Matches connection %p", conn);
-                               // We have a response!
-                               TCP_INT_HandleConnectionPacket(conn, hdr, Length);
-
-                               return;
-                       }
+                       // Check that it is coming in on the same interface
+                       if(conn->Interface != Interface)        continue;
 
-                       Log_Log("TCP", "TCP_GetPacket: Opening Connection");
-                       // Open a new connection (well, check that it's a SYN)
-                       if(hdr->Flags != TCP_FLAG_SYN) {
-                               Log_Log("TCP", "TCP_GetPacket: Packet is not a SYN");
-                               return ;
-                       }
-                       
-                       // TODO: Check for halfopen max
-                       
-                       conn = calloc(1, sizeof(tTCPConnection));
-                       conn->State = TCP_ST_SYN_RCVD;
-                       conn->LocalPort = srv->Port;
-                       conn->RemotePort = ntohs(hdr->SourcePort);
-                       conn->Interface = Interface;
-                       
-                       switch(Interface->Type)
-                       {
-                       case 4: conn->RemoteIP.v4 = *(tIPv4*)Address;   break;
-                       case 6: conn->RemoteIP.v6 = *(tIPv6*)Address;   break;
-                       }
-                       
-                       conn->RecievedBuffer = RingBuffer_Create( TCP_RECIEVE_BUFFER_SIZE );
-                       
-                       conn->NextSequenceRcv = ntohl( hdr->SequenceNumber ) + 1;
-                       conn->NextSequenceSend = rand();
-                       
-                       // Create node
-                       conn->Node.NumACLs = 1;
-                       conn->Node.ACLs = &gVFS_ACL_EveryoneRW;
-                       conn->Node.ImplPtr = conn;
-                       conn->Node.ImplInt = srv->NextID ++;
-                       conn->Node.Type = &gTCP_ClientNodeType; // TODO: Special type for the server end?
-                       
-                       // Hmm... Theoretically, this lock will never have to wait,
-                       // as the interface is locked to the watching thread, and this
-                       // runs in the watching thread. But, it's a good idea to have
-                       // it, just in case
-                       // Oh, wait, there is a case where a wildcard can be used
-                       // (srv->Interface == NULL) so having the lock is a good idea
-                       SHORTLOCK(&srv->lConnections);
-                       if( !srv->Connections )
-                               srv->Connections = conn;
-                       else
-                               srv->ConnectionsTail->Next = conn;
-                       srv->ConnectionsTail = conn;
-                       if(!srv->NewConnections)
-                               srv->NewConnections = conn;
-                       VFS_MarkAvaliable( &srv->Node, 1 );
-                       SHORTREL(&srv->lConnections);
-
-                       // Send the SYN ACK
-                       hdr->Flags |= TCP_FLAG_ACK;
-                       hdr->AcknowlegementNumber = htonl(conn->NextSequenceRcv);
-                       hdr->SequenceNumber = htonl(conn->NextSequenceSend);
-                       hdr->DestPort = hdr->SourcePort;
-                       hdr->SourcePort = htons(srv->Port);
-                       hdr->DataOffset = (sizeof(tTCPHeader)/4) << 4;
-                       TCP_SendPacket( conn, sizeof(tTCPHeader), hdr );
-                       conn->NextSequenceSend ++;
+                       // Check Source Port
+                       Log_Log("TCP", "TCP_GetPacket: conn->RemotePort(%i) == hdr->SourcePort(%i)",
+                               conn->RemotePort, ntohs(hdr->SourcePort));
+                       if(conn->RemotePort != ntohs(hdr->SourcePort))  continue;
+
+                       // Check Source IP
+                       Log_Debug("TCP", "TCP_GetPacket: conn->RemoteIP(%s)",
+                               IPStack_PrintAddress(conn->Interface->Type, &conn->RemoteIP));
+                       Log_Debug("TCP", "                == Address(%s)",
+                               IPStack_PrintAddress(conn->Interface->Type, Address));
+                       if( IPStack_CompareAddress(conn->Interface->Type, &conn->RemoteIP, Address, -1) == 0 )
+                               continue ;
+
+                       Log_Log("TCP", "TCP_GetPacket: Matches connection %p", conn);
+                       // We have a response!
+                       TCP_INT_HandleConnectionPacket(conn, hdr, Length);
+
+                       return;
+               }
+
+               Log_Log("TCP", "TCP_GetPacket: Opening Connection");
+               // Open a new connection (well, check that it's a SYN)
+               if(hdr->Flags != TCP_FLAG_SYN) {
+                       Log_Log("TCP", "TCP_GetPacket: Packet is not a SYN");
                        return ;
                }
+               
+               // TODO: Check for halfopen max
+               
+               conn = calloc(1, sizeof(tTCPConnection));
+               conn->State = TCP_ST_SYN_RCVD;
+               conn->LocalPort = srv->Port;
+               conn->RemotePort = ntohs(hdr->SourcePort);
+               conn->Interface = Interface;
+               
+               switch(Interface->Type)
+               {
+               case 4: conn->RemoteIP.v4 = *(tIPv4*)Address;   break;
+               case 6: conn->RemoteIP.v6 = *(tIPv6*)Address;   break;
+               }
+               
+               conn->RecievedBuffer = RingBuffer_Create( TCP_RECIEVE_BUFFER_SIZE );
+               
+               conn->NextSequenceRcv = ntohl( hdr->SequenceNumber ) + 1;
+               conn->NextSequenceSend = rand();
+               
+               // Create node
+               conn->Node.NumACLs = 1;
+               conn->Node.ACLs = &gVFS_ACL_EveryoneRW;
+               conn->Node.ImplPtr = conn;
+               conn->Node.ImplInt = srv->NextID ++;
+               conn->Node.Type = &gTCP_ClientNodeType; // TODO: Special type for the server end?
+               
+               // Hmm... Theoretically, this lock will never have to wait,
+               // as the interface is locked to the watching thread, and this
+               // runs in the watching thread. But, it's a good idea to have
+               // it, just in case
+               // Oh, wait, there is a case where a wildcard can be used
+               // (srv->Interface == NULL) so having the lock is a good idea
+               SHORTLOCK(&srv->lConnections);
+               if( !srv->Connections )
+                       srv->Connections = conn;
+               else
+                       srv->ConnectionsTail->Next = conn;
+               srv->ConnectionsTail = conn;
+               if(!srv->NewConnections)
+                       srv->NewConnections = conn;
+               VFS_MarkAvaliable( &srv->Node, 1 );
+               SHORTREL(&srv->lConnections);
+               Semaphore_Signal(&srv->WaitingConnections, 1);
+
+               // Send the SYN ACK
+               hdr->Flags |= TCP_FLAG_ACK;
+               hdr->AcknowlegementNumber = htonl(conn->NextSequenceRcv);
+               hdr->SequenceNumber = htonl(conn->NextSequenceSend);
+               hdr->DestPort = hdr->SourcePort;
+               hdr->SourcePort = htons(srv->Port);
+               hdr->DataOffset = (sizeof(tTCPHeader)/4) << 4;
+               TCP_SendPacket( conn, hdr, 0, NULL );
+               conn->NextSequenceSend ++;
+               return ;
        }
 
-
        // Check Open Connections
        {
                for( conn = gTCP_OutbountCons; conn; conn = conn->Next )
@@ -322,18 +335,22 @@ void TCP_INT_HandleConnectionPacket(tTCPConnection *Connection, tTCPHeader *Head
        // Syncronise sequence values
        if(Header->Flags & TCP_FLAG_SYN) {
                // TODO: What if the packet also has data?
+               if( Connection->LastACKSequence != Connection->NextSequenceRcv )
+                       TCP_INT_SendACK(Connection);
                Connection->NextSequenceRcv = ntohl(Header->SequenceNumber);
+               Connection->LastACKSequence = Connection->NextSequenceRcv;
        }
        
        // Ackowledge a sent packet
        if(Header->Flags & TCP_FLAG_ACK) {
                // TODO: Process an ACKed Packet
-               Log_Log("TCP", "Conn %p, Sent packet 0x%x ACKed", Connection, Header->AcknowlegementNumber);
+               LOG("Conn %p, Sent packet 0x%x ACKed", Connection, Header->AcknowlegementNumber);
        }
        
        // Get length of data
        dataLen = Length - (Header->DataOffset>>4)*4;
-       Log_Log("TCP", "HandleConnectionPacket - dataLen = %i", dataLen);
+       LOG("dataLen = %i", dataLen);
+//     Log_Debug("TCP", "State %i, dataLen = %x", Connection->State, dataLen);
        
        // 
        // State Machine
@@ -358,12 +375,13 @@ void TCP_INT_HandleConnectionPacket(tTCPConnection *Connection, tTCPHeader *Head
                        Header->WindowSize = htons(TCP_WINDOW_SIZE);
                        Header->Flags = TCP_FLAG_ACK;
                        Header->DataOffset = (sizeof(tTCPHeader)/4) << 4;
-                       TCP_SendPacket( Connection, sizeof(tTCPHeader), Header );
+                       TCP_SendPacket( Connection, Header, 0, NULL );
                        
                        if( Header->Flags & TCP_FLAG_ACK )
                        {       
                                Log_Log("TCP", "ACKing SYN-ACK");
                                Connection->State = TCP_ST_OPEN;
+                               VFS_MarkFull(&Connection->Node, 0);
                        }
                        else
                        {
@@ -378,8 +396,9 @@ void TCP_INT_HandleConnectionPacket(tTCPConnection *Connection, tTCPHeader *Head
                if( Header->Flags & TCP_FLAG_ACK )
                {
                        // TODO: Handle max half-open limit
-                       Connection->State = TCP_ST_OPEN;
                        Log_Log("TCP", "Connection fully opened");
+                       Connection->State = TCP_ST_OPEN;
+                       VFS_MarkFull(&Connection->Node, 0);
                }
                break;
                
@@ -412,7 +431,7 @@ void TCP_INT_HandleConnectionPacket(tTCPConnection *Connection, tTCPHeader *Head
                        Header->AcknowlegementNumber = htonl(Connection->NextSequenceRcv);
                        Header->SequenceNumber = htonl(Connection->NextSequenceSend);
                        Header->Flags |= TCP_FLAG_ACK;
-                       TCP_SendPacket( Connection, sizeof(tTCPHeader), Header );
+                       TCP_SendPacket( Connection, Header, 0, NULL );
                        return ;
                }
                
@@ -423,7 +442,7 @@ void TCP_INT_HandleConnectionPacket(tTCPConnection *Connection, tTCPHeader *Head
                
                sequence_num = ntohl(Header->SequenceNumber);
                
-               Log_Log("TCP", "0x%08x <= 0x%08x < 0x%08x",
+               LOG("TCP", "0x%08x <= 0x%08x < 0x%08x",
                        Connection->NextSequenceRcv,
                        ntohl(Header->SequenceNumber),
                        Connection->NextSequenceRcv + TCP_WINDOW_SIZE
@@ -439,9 +458,10 @@ void TCP_INT_HandleConnectionPacket(tTCPConnection *Connection, tTCPHeader *Head
                                dataLen
                                );
                        if(rv != 0) {
+                               Log_Notice("TCP", "TCP_INT_AppendRecieved rv %i", rv);
                                break;
                        }
-                       Log_Log("TCP", "0x%08x += %i", Connection->NextSequenceRcv, dataLen);
+                       LOG("0x%08x += %i", Connection->NextSequenceRcv, dataLen);
                        Connection->NextSequenceRcv += dataLen;
                        
                        // TODO: This should be moved out of the watcher thread,
@@ -449,18 +469,20 @@ void TCP_INT_HandleConnectionPacket(tTCPConnection *Connection, tTCPHeader *Head
                        // all connections on the interface to lag.
                        // - Meh, no real issue, as the cache shouldn't be that large
                        TCP_INT_UpdateRecievedFromFuture(Connection);
-               
-                       // ACK Packet
-                       Header->DestPort = Header->SourcePort;
-                       Header->SourcePort = htons(Connection->LocalPort);
-                       Header->AcknowlegementNumber = htonl(Connection->NextSequenceRcv);
-                       Header->SequenceNumber = htonl(Connection->NextSequenceSend);
-                       Header->WindowSize = htons(TCP_WINDOW_SIZE);
-                       Header->Flags &= TCP_FLAG_SYN;  // Eliminate all flags save for SYN
-                       Header->Flags |= TCP_FLAG_ACK;  // Add ACK
-                       Log_Log("TCP", "Sending ACK for 0x%08x", Connection->NextSequenceRcv);
-                       TCP_SendPacket( Connection, sizeof(tTCPHeader), Header );
-                       //Connection->NextSequenceSend ++;
+
+                       #if 1
+                       // - Only send an ACK if we've had a burst
+                       if( Connection->NextSequenceRcv > (Uint32)(TCP_DACK_THRESHOLD + Connection->LastACKSequence) )
+                       {
+                               TCP_INT_SendACK(Connection);
+                               // - Extend TCP deferred ACK timer
+                               Time_RemoveTimer(Connection->DeferredACKTimer);
+                       }
+                       // - Schedule the deferred ACK timer (if already scheduled, this is a NOP)
+                       Time_ScheduleTimer(Connection->DeferredACKTimer, TCP_DACK_TIMEOUT);
+                       #else
+                       TCP_INT_SendACK(Connection);
+                       #endif
                }
                // Check if the packet is in window
                else if( WrapBetween(Connection->NextSequenceRcv, sequence_num,
@@ -531,7 +553,8 @@ void TCP_INT_HandleConnectionPacket(tTCPConnection *Connection, tTCPHeader *Head
                {
                        Log_Log("TCP", "Fully out of sequence packet (0x%08x not between 0x%08x and 0x%08x), dropped",
                                sequence_num, Connection->NextSequenceRcv, Connection->NextSequenceRcv+TCP_WINDOW_SIZE);
-                       // TODO: Spec says we should send an empty ACK with the current state
+                       // Spec says we should send an empty ACK with the current state
+                       TCP_INT_SendACK(Connection);
                }
                break;
        
@@ -568,7 +591,7 @@ void TCP_INT_HandleConnectionPacket(tTCPConnection *Connection, tTCPHeader *Head
                        Header->SequenceNumber = htonl(Connection->NextSequenceSend);
                        Header->WindowSize = htons(TCP_WINDOW_SIZE);
                        Header->Flags = TCP_FLAG_ACK;
-                       TCP_SendPacket( Connection, sizeof(tTCPHeader), Header );
+                       TCP_SendPacket( Connection, Header, 0, NULL );
                        break ;
                }
                
@@ -594,7 +617,7 @@ void TCP_INT_HandleConnectionPacket(tTCPConnection *Connection, tTCPHeader *Head
                        Header->SequenceNumber = htonl(Connection->NextSequenceSend);
                        Header->WindowSize = htons(TCP_WINDOW_SIZE);
                        Header->Flags = TCP_FLAG_ACK;
-                       TCP_SendPacket( Connection, sizeof(tTCPHeader), Header );
+                       TCP_SendPacket( Connection, Header, 0, NULL );
                }
                break;
        
@@ -771,6 +794,25 @@ void TCP_INT_UpdateRecievedFromFuture(tTCPConnection *Connection)
        #endif
 }
 
+void TCP_INT_SendACK(tTCPConnection *Connection)
+{
+       tTCPHeader      hdr;
+       // ACK Packet
+       hdr.DataOffset = (sizeof(tTCPHeader)/4) << 4;
+       hdr.DestPort = htons(Connection->RemotePort);
+       hdr.SourcePort = htons(Connection->LocalPort);
+       hdr.AcknowlegementNumber = htonl(Connection->NextSequenceRcv);
+       hdr.SequenceNumber = htonl(Connection->NextSequenceSend);
+       hdr.WindowSize = htons(TCP_WINDOW_SIZE);
+       hdr.Flags = TCP_FLAG_ACK;       // TODO: Determine if SYN is wanted too
+       hdr.Checksum = 0;       // TODO: Checksum
+       hdr.UrgentPointer = 0;
+       Log_Debug("TCP", "Sending ACK for 0x%08x", Connection->NextSequenceRcv);
+       TCP_SendPacket( Connection, &hdr, 0, NULL );
+       //Connection->NextSequenceSend ++;
+       Connection->LastACKSequence = Connection->NextSequenceRcv;
+}
+
 /**
  * \fn Uint16 TCP_GetUnusedPort()
  * \brief Gets an unused port and allocates it
@@ -868,24 +910,17 @@ tVFS_Node *TCP_Server_Init(tInterface *Interface)
  * \param Node Server node
  * \param Pos  Position (ignored)
  */
-char *TCP_Server_ReadDir(tVFS_Node *Node, int Pos)
+int TCP_Server_ReadDir(tVFS_Node *Node, int Pos, char Dest[FILENAME_MAX])
 {
        tTCPListener    *srv = Node->ImplPtr;
        tTCPConnection  *conn;
-       char    *ret;
        
        ENTER("pNode iPos", Node, Pos);
 
        Log_Log("TCP", "Thread %i waiting for a connection", Threads_GetTID());
-       for(;;)
-       {
-               SHORTLOCK( &srv->lConnections );
-               if( srv->NewConnections != NULL )       break;
-               SHORTREL( &srv->lConnections );
-               Threads_Yield();        // TODO: Sleep until poked
-       }
+       Semaphore_Wait( &srv->WaitingConnections, 1 );
        
-
+       SHORTLOCK(&srv->lConnections);
        // Increment the new list (the current connection is still on the 
        // normal list)
        conn = srv->NewConnections;
@@ -901,11 +936,10 @@ char *TCP_Server_ReadDir(tVFS_Node *Node, int Pos)
        LOG("srv->NewConnections = %p", srv->NewConnections);
        LOG("srv->ConnectionsTail = %p", srv->ConnectionsTail);
 
-       ret = malloc(9);
-       itoa(ret, conn->Node.ImplInt, 16, 8, '0');
-       Log_Log("TCP", "Thread %i got '%s'", Threads_GetTID(), ret);
-       LEAVE('s', ret);
-       return ret;
+       itoa(Dest, conn->Node.ImplInt, 16, 8, '0');
+       Log_Log("TCP", "Thread %i got connection '%s'", Threads_GetTID(), Dest);
+       LEAVE('i', 0);
+       return 0;
 }
 
 /**
@@ -1039,6 +1073,7 @@ tVFS_Node *TCP_Client_Init(tInterface *Interface)
        conn->Node.NumACLs = 1;
        conn->Node.ACLs = &gVFS_ACL_EveryoneRW;
        conn->Node.Type = &gTCP_ClientNodeType;
+       conn->Node.BufferFull = 1;      // Cleared when connection opens
 
        conn->RecievedBuffer = RingBuffer_Create( TCP_RECIEVE_BUFFER_SIZE );
        #if 0
@@ -1052,6 +1087,8 @@ tVFS_Node *TCP_Client_Init(tInterface *Interface)
        conn->FuturePacketValidBytes = conn->FuturePacketData + TCP_WINDOW_SIZE;
        #endif
 
+       conn->DeferredACKTimer = Time_AllocateTimer( (void(*)(void*)) TCP_INT_SendACK, conn);
+
        SHORTLOCK(&glTCP_OutbountCons);
        conn->Next = gTCP_OutbountCons;
        gTCP_OutbountCons = conn;
@@ -1073,14 +1110,9 @@ size_t TCP_Client_Read(tVFS_Node *Node, off_t Offset, size_t Length, void *Buffe
        ENTER("pNode XOffset XLength pBuffer", Node, Offset, Length, Buffer);
        LOG("conn = %p {State:%i}", conn, conn->State);
        
-       // Check if connection is estabilishing
-       // - TODO: Sleep instead (maybe using VFS_SelectNode to wait for the
-       //   data to be availiable
-       while( conn->State == TCP_ST_SYN_RCVD || conn->State == TCP_ST_SYN_SENT )
-               Threads_Yield();
-       
-       // If the conneciton is not open, then clean out the recieved buffer
-       if( conn->State != TCP_ST_OPEN )
+       // If the connection has been closed (state > ST_OPEN) then clear
+       // any stale data in the buffer (until it is empty (until it is empty))
+       if( conn->State > TCP_ST_OPEN )
        {
                Mutex_Acquire( &conn->lRecievedPackets );
                len = RingBuffer_Read( Buffer, conn->RecievedBuffer, Length );
@@ -1139,7 +1171,7 @@ void TCP_INT_SendDataPacket(tTCPConnection *Connection, size_t Length, const voi
        Debug_HexDump("TCP_INT_SendDataPacket: Data = ", Data, Length);
 #endif
        
-       TCP_SendPacket( Connection, sizeof(tTCPHeader)+Length, packet );
+       TCP_SendPacket( Connection, packet, Length, Data );
        
        Connection->NextSequenceSend += Length;
 }
@@ -1159,16 +1191,16 @@ size_t TCP_Client_Write(tVFS_Node *Node, off_t Offset, size_t Length, const void
 //             Buffer, Length);
 //     #endif
        
-       // Check if connection is open
-       while( conn->State == TCP_ST_SYN_RCVD || conn->State == TCP_ST_SYN_SENT )
-               Threads_Yield();
-       
-       if( conn->State != TCP_ST_OPEN ) {
+       // Don't allow a write to a closed connection
+       if( conn->State > TCP_ST_OPEN ) {
                VFS_MarkError(Node, 1);
                LEAVE('i', -1);
                return -1;
        }
        
+       // Wait
+       VFS_SelectNode(Node, VFS_SELECT_WRITE|VFS_SELECT_ERROR, NULL, "TCP_Client_Write");
+       
        do
        {
                 int    len = (rem < TCP_MAX_PACKET_SIZE) ? rem : TCP_MAX_PACKET_SIZE;
@@ -1211,7 +1243,7 @@ void TCP_StartConnection(tTCPConnection *Conn)
        hdr.WindowSize = htons(TCP_WINDOW_SIZE);        // Max
        hdr.Checksum = 0;       // TODO
        
-       TCP_SendPacket( Conn, sizeof(tTCPHeader), &hdr );
+       TCP_SendPacket( Conn, &hdr, 0, NULL );
        
        Conn->NextSequenceSend ++;
        Conn->State = TCP_ST_SYN_SENT;
@@ -1273,13 +1305,10 @@ int TCP_Client_IOCtl(tVFS_Node *Node, int ID, void *Data)
                        LEAVE_RET('i', 0);
 
                {
-                       tTime   timeout_end = now() + conn->Interface->TimeoutDelay;
+                       tTime   timeout = conn->Interface->TimeoutDelay;
        
                        TCP_StartConnection(conn);
-                       // TODO: Wait for connection to open
-                       while( conn->State == TCP_ST_SYN_SENT && timeout_end > now() ) {
-                               Threads_Yield();
-                       }
+                       VFS_SelectNode(&conn->Node, VFS_SELECT_WRITE, &timeout, "TCP Connection");
                        if( conn->State == TCP_ST_SYN_SENT )
                                LEAVE_RET('i', 0);
                }
@@ -1312,7 +1341,7 @@ void TCP_Client_Close(tVFS_Node *Node)
                packet.SequenceNumber = htonl(conn->NextSequenceSend);
                packet.Flags = TCP_FLAG_FIN;
                
-               TCP_SendPacket( conn, sizeof(tTCPHeader), &packet );
+               TCP_SendPacket( conn, &packet, 0, NULL );
        }
        
        switch( conn->State )
@@ -1329,6 +1358,8 @@ void TCP_Client_Close(tVFS_Node *Node)
                break;
        }
        
+       Time_RemoveTimer(conn->DeferredACKTimer);
+       Time_FreeTimer(conn->DeferredACKTimer);
        free(conn);
        
        LEAVE('-');

UCC git Repository :: git.ucc.asn.au