git.ucc.asn.au / matches / MCTX3420.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 2ca86f4) | patch
Remove misleading bounds check
authorJeremy Tan <[email protected]>
Thu, 3 Oct 2013 06:19:38 +0000 (14:19 +0800)
committerJeremy Tan <[email protected]>
Thu, 3 Oct 2013 06:19:38 +0000 (14:19 +0800)
commite2c333035c595ef6e48ff66d46a811ca17f97a26
tree24d30dc140a8ee762bf85ee8e68bd5a4e4687226tree | snapshot
parent2ca86f48743a695437aebd7ebe1304118e5bc4bfcommit | diff
Remove misleading bounds check

(1) Length of user is not guaranteed (and in this case definitely < BUFSIZ)
(2) Because of (1), a buffer overflow is possible anyway
(3) Sure, a BUFSIZ limit will prevent an 'infinite' loop, but this may just make it more difficult to track down the buffer overflow.
server/login.c diff | blob | history
Repository for MCTX3420 2013 Project, Team 4

UCC git Repository :: git.ucc.asn.au