Fixed kernel segfault in VTerm (referenced possible NULL value)
[tpg/acess2.git] / Kernel / drv / vterm.c
index b7e7a8b..252f292 100644 (file)
@@ -39,6 +39,9 @@ enum eVT_InModes {
 typedef struct {
         int    Mode;   //!< Current Mode (see ::eTplTerminal_Modes)
         int    Flags;  //!< Flags (see VT_FLAG_*)
+       
+       short   NewWidth;       //!< Un-applied dimensions (Width)
+       short   NewHeight;      //!< Un-applied dimensions (Height)
        short   Width;  //!< Virtual Width
        short   Height; //!< Virtual Height
        short   TextWidth;      //!< Text Virtual Width
@@ -48,6 +51,8 @@ typedef struct {
         int    WritePos;       //!< Write Buffer Offset (Text Only)
        Uint32  CurColour;      //!< Current Text Colour
        
+       tMutex  ReadingLock;    //!< Lock the VTerm when a process is reading from it
+       tTID    ReadingThread;  //!< Owner of the lock
         int    InputRead;      //!< Input buffer read position
         int    InputWrite;     //!< Input buffer write position
        char    InputBuffer[MAX_INPUT_CHARS8];
@@ -67,7 +72,7 @@ extern void   Debug_SetKTerminal(char *File);
 void   VT_InitOutput(void);
 void   VT_InitInput(void);
 char   *VT_ReadDir(tVFS_Node *Node, int Pos);
-tVFS_Node      *VT_FindDir(tVFS_Node *Node, char *Name);
+tVFS_Node      *VT_FindDir(tVFS_Node *Node, const char *Name);
  int   VT_Root_IOCtl(tVFS_Node *Node, int Id, void *Data);
 Uint64 VT_Read(tVFS_Node *Node, Uint64 Offset, Uint64 Length, void *Buffer);
 Uint64 VT_Write(tVFS_Node *Node, Uint64 Offset, Uint64 Length, void *Buffer);
@@ -81,8 +86,7 @@ void  VT_int_PutString(tVTerm *Term, Uint8 *Buffer, Uint Count);
 void   VT_int_PutChar(tVTerm *Term, Uint32 Ch);
 void   VT_int_ScrollFramebuffer( tVTerm *Term );
 void   VT_int_UpdateScreen( tVTerm *Term, int UpdateAll );
-void   VT_int_ChangeMode(tVTerm *Term, int NewMode);
-void   VT_int_UpdateResolution(tVTerm *Term, int NewWidth, int NewHeight);
+void   VT_int_ChangeMode(tVTerm *Term, int NewMode, int NewWidth, int NewHeight);
 
 // === CONSTANTS ===
 const Uint16   caVT100Colours[] = {
@@ -145,12 +149,10 @@ int VT_Install(char **Arguments)
                        val = arg + strpos(arg, '=');   *val++ = '\0';
                        
                        if( strcmp(opt, "Video") == 0 ) {
-                               if(gsVT_OutputDevice)   free(gsVT_OutputDevice);
-                               gsVT_OutputDevice = strdup(val);
+                               gsVT_OutputDevice = val;
                        }
                        else if( strcmp(opt, "Input") == 0 ) {
-                               if(gsVT_InputDevice)    free(gsVT_InputDevice);
-                               gsVT_InputDevice = strdup(val);
+                               gsVT_InputDevice = val;
                        }
                        else if( strcmp(opt, "Width") == 0 ) {
                                giVT_RealWidth = atoi( val );
@@ -164,9 +166,25 @@ int VT_Install(char **Arguments)
                }
        }
        
+       if(gsVT_OutputDevice)   Modules_InitialiseBuiltin( gsVT_OutputDevice );
+       if(gsVT_InputDevice)    Modules_InitialiseBuiltin( gsVT_InputDevice );
+       
        // Apply Defaults
-       if(!gsVT_OutputDevice)  gsVT_OutputDevice = "/Devices/"DEFAULT_OUTPUT;
-       if(!gsVT_InputDevice)   gsVT_InputDevice = "/Devices/"DEFAULT_INPUT;
+       if(!gsVT_OutputDevice)  gsVT_OutputDevice = DEFAULT_OUTPUT;
+       if(!gsVT_InputDevice)   gsVT_InputDevice = DEFAULT_INPUT;
+       
+       // Create paths
+       {
+               char    *tmp;
+               tmp = malloc( 9 + strlen(gsVT_OutputDevice) + 1 );
+               strcpy(tmp, "/Devices/");
+               strcpy(&tmp[9], gsVT_OutputDevice);
+               gsVT_OutputDevice = tmp;
+               tmp = malloc( 9 + strlen(gsVT_InputDevice) + 1 );
+               strcpy(tmp, "/Devices/");
+               strcpy(&tmp[9], gsVT_InputDevice);
+               gsVT_InputDevice = tmp;
+       }
        
        Log_Log("VTerm", "Using '%s' as output", gsVT_OutputDevice);
        Log_Log("VTerm", "Using '%s' as input", gsVT_InputDevice);
@@ -180,7 +198,9 @@ int VT_Install(char **Arguments)
                gVT_Terminals[i].WritePos = 0;
                gVT_Terminals[i].ViewPos = 0;
                
-               VT_int_UpdateResolution( &gVT_Terminals[i], giVT_RealWidth, giVT_RealHeight );
+               // Initialise
+               VT_int_ChangeMode( &gVT_Terminals[i],
+                       TERM_MODE_TEXT, giVT_RealWidth, giVT_RealHeight );
                
                gVT_Terminals[i].Name[0] = '0'+i;
                gVT_Terminals[i].Name[1] = '\0';
@@ -217,7 +237,7 @@ void VT_InitOutput()
                Log_Warning("VTerm", "Oh F**k, I can't open the video device '%s'", gsVT_OutputDevice);
                return ;
        }
-       VT_SetResolution(giVT_RealWidth, giVT_RealHeight);
+       VT_SetResolution( giVT_RealWidth, giVT_RealHeight );
        VT_SetTerminal( 0 );
        VT_SetMode( VIDEO_BUFFMT_TEXT );
 }
@@ -233,6 +253,66 @@ void VT_InitInput()
        VFS_IOCtl(giVT_InputDevHandle, KB_IOCTL_SETCALLBACK, VT_KBCallBack);
 }
 
+/**
+ * \brief Set the video resolution
+ * \param Width        New screen width
+ * \param Height       New screen height
+ */
+void VT_SetResolution(int Width, int Height)
+{
+       tVideo_IOCtl_Mode       mode = {0};
+        int    tmp;
+        int    i;
+       
+       // Create the video mode
+       mode.width = Width;
+       mode.height = Height;
+       mode.bpp = 32;
+       mode.flags = 0;
+       
+       // Set video mode
+       VFS_IOCtl( giVT_OutputDevHandle, VIDEO_IOCTL_FINDMODE, &mode );
+       tmp = mode.id;
+       if( Width != mode.width || Height != mode.height )
+       {
+               Log_Warning("VTerm",
+                       "Selected resolution (%ix%i is not supported) by the device, using (%ix%i)",
+                       giVT_RealWidth, giVT_RealHeight,
+                       mode.width, mode.height
+                       );
+       }
+       VFS_IOCtl( giVT_OutputDevHandle, VIDEO_IOCTL_GETSETMODE, &tmp );
+       
+       // Resize text terminals if needed
+       if( giVT_RealWidth != mode.width || giVT_RealHeight != mode.height )
+       {
+                int    newBufSize = (giVT_RealWidth/giVT_CharWidth)
+                                       *(giVT_RealHeight/giVT_CharHeight)
+                                       *(giVT_Scrollback+1);
+               //tVT_Char      *tmp;
+               // Resize the text terminals
+               giVT_RealWidth = mode.width;
+               giVT_RealHeight = mode.height;
+               for( i = 0; i < NUM_VTS; i ++ )
+               {
+                       if( gVT_Terminals[i].Mode != TERM_MODE_TEXT )   continue;
+                       
+                       gVT_Terminals[i].Text = realloc(
+                               gVT_Terminals[i].Text,
+                               newBufSize*sizeof(tVT_Char)
+                               );
+               }
+       }
+}
+
+/**
+ * \brief Set video output buffer mode
+ */
+void VT_SetMode(int Mode)
+{
+       VFS_IOCtl( giVT_OutputDevHandle, VIDEO_IOCTL_SETBUFFORMAT, &Mode );
+}
+
 /**
  * \fn char *VT_ReadDir(tVFS_Node *Node, int Pos)
  * \brief Read from the VTerm Directory
@@ -245,10 +325,12 @@ char *VT_ReadDir(tVFS_Node *Node, int Pos)
 }
 
 /**
- * \fn tVFS_Node *VT_FindDir(tVFS_Node *Node, char *Name)
+ * \fn tVFS_Node *VT_FindDir(tVFS_Node *Node, const char *Name)
  * \brief Find an item in the VTerm directory
+ * \param Node Root node
+ * \param Name Name (number) of the terminal
  */
-tVFS_Node *VT_FindDir(tVFS_Node *Node, char *Name)
+tVFS_Node *VT_FindDir(tVFS_Node *Node, const char *Name)
 {
         int    num;
        
@@ -321,13 +403,18 @@ Uint64 VT_Read(tVFS_Node *Node, Uint64 Offset, Uint64 Length, void *Buffer)
         int    pos = 0;
        tVTerm  *term = &gVT_Terminals[ Node->Inode ];
        
+       Mutex_Acquire( &term->ReadingLock );
+       term->ReadingThread = Threads_GetTID();
+       
        // Check current mode
        switch(term->Mode)
        {
+       // Text Mode (UTF-8)
        case TERM_MODE_TEXT:
                while(pos < Length)
                {
-                       while(term->InputRead == term->InputWrite)      Threads_Yield();
+                       //TODO: Sleep instead
+                       while(term->InputRead == term->InputWrite)      Threads_Sleep();
                        
                        ((char*)Buffer)[pos] = term->InputBuffer[term->InputRead];
                        pos ++;
@@ -337,10 +424,11 @@ Uint64 VT_Read(tVFS_Node *Node, Uint64 Offset, Uint64 Length, void *Buffer)
                break;
        
        //case TERM_MODE_FB:
+       // Other - UCS-4
        default:
                while(pos < Length)
                {
-                       while(term->InputRead == term->InputWrite)      Threads_Yield();
+                       while(term->InputRead == term->InputWrite)      Threads_Sleep();
                        ((Uint32*)Buffer)[pos] = ((Uint32*)term->InputBuffer)[term->InputRead];
                        pos ++;
                        term->InputRead ++;
@@ -348,6 +436,10 @@ Uint64 VT_Read(tVFS_Node *Node, Uint64 Offset, Uint64 Length, void *Buffer)
                }
                break;
        }
+       
+       term->ReadingThread = -1;
+       Mutex_Release( &term->ReadingLock );
+       
        return 0;
 }
 
@@ -363,29 +455,36 @@ Uint64 VT_Write(tVFS_Node *Node, Uint64 Offset, Uint64 Length, void *Buffer)
        // Write
        switch( term->Mode )
        {
+       // Print Text
        case TERM_MODE_TEXT:
                VT_int_PutString(term, Buffer, Length);
                break;
+       // Framebuffer :)
        case TERM_MODE_FB:
+       
+               // - Sanity Checking
                size = term->Width*term->Height*4;
                if( Offset > size ) {
                        Log_Notice("VTerm", "VT_Write: Offset (0x%llx) > FBSize (0x%x)",
                                Offset, size);
                        return 0;
                }
-               
                if( Offset + Length > size ) {
                        Log_Notice("VTerm", "VT_Write: Offset+Length (0x%llx) > FBSize (0x%x)",
                                Offset+Length, size);
                        Length = size - Offset;
                }
                
+               // Copy to the local cache
                memcpy( (void*)((Uint)term->Buffer + (Uint)Offset), Buffer, Length );
                
+               // Update screen if needed
                if( Node->Inode == giVT_CurrentTerminal )
                {
+                       // Fill entire screen?
                        if( giVT_RealWidth > term->Width || giVT_RealHeight > term->Height )
                        {
+                               // No? :( Well, just center it
                                 int    x, y, w, h;
                                x = Offset/4;   y = x / term->Width;    x %= term->Width;
                                w = Length/4+x; h = w / term->Width;    w %= term->Width;
@@ -409,6 +508,8 @@ Uint64 VT_Write(tVFS_Node *Node, Uint64 Offset, Uint64 Length, void *Buffer)
                        }
                }
        // Just pass on (for now)
+       // TODO: Handle locally too to ensure no information is lost on
+       //       VT Switch (and to isolate terminals from each other)
        case TERM_MODE_2DACCEL:
        //case TERM_MODE_3DACCEL:
                if( Node->Inode == giVT_CurrentTerminal )
@@ -466,8 +567,24 @@ int VT_Terminal_IOCtl(tVFS_Node *Node, int Id, void *Data)
                        Log_Log("VTerm", "VTerm %i mode set to %i", (int)Node->Inode, *iData);
                        
                        // Update mode if needed
-                       if(term->Mode != *iData)
-                               VT_int_ChangeMode(term, *iData);
+                       if( term->Mode != *iData
+                        || term->NewWidth
+                        || term->NewHeight)
+                       {
+                               // Adjust for text mode
+                               if( *iData == TERM_MODE_TEXT ) {
+                                       term->NewHeight *= giVT_CharHeight;
+                                       term->NewWidth *= giVT_CharWidth;
+                               }
+                               // Fill unchanged dimensions
+                               if(term->NewHeight == 0)        term->NewHeight = term->Height;
+                               if(term->NewWidth == 0) term->NewWidth = term->Width;
+                               // Set new mode
+                               VT_int_ChangeMode(term, *iData, term->NewWidth, term->NewHeight);
+                               // Clear unapplied dimensions
+                               term->NewWidth = 0;
+                               term->NewHeight = 0;
+                       }
                        
                        // Update the screen dimensions
                        if(Node->Inode == giVT_CurrentTerminal)
@@ -483,14 +600,11 @@ int VT_Terminal_IOCtl(tVFS_Node *Node, int Id, void *Data)
                                LEAVE('i', -1);
                                return -1;
                        }
-                       if( term->Mode == TERM_MODE_TEXT ) {
-                               VT_int_UpdateResolution(term, *iData * giVT_CharWidth, term->Height);
-                       }
-                       else {
-                               VT_int_UpdateResolution(term, *iData, term->Height);
-                       }
+                       term->NewWidth = *iData;
                }
-               if( term->Mode == TERM_MODE_TEXT )
+               if( term->NewWidth )
+                       ret = term->NewWidth;
+               else if( term->Mode == TERM_MODE_TEXT )
                        ret = term->TextWidth;
                else
                        ret = term->Width;
@@ -504,15 +618,12 @@ int VT_Terminal_IOCtl(tVFS_Node *Node, int Id, void *Data)
                                LEAVE('i', -1);
                                return -1;
                        }
-                       if( term->Mode == TERM_MODE_TEXT ) {
-                               VT_int_UpdateResolution(term, term->Width, *iData * giVT_CharWidth);
-                       }
-                       else {
-                               VT_int_UpdateResolution(term, term->Width, *iData);
-                       }
+                       term->NewHeight = *iData;
                }
-               if( term->Mode == TERM_MODE_TEXT )
-                       ret = term->TextHeight = *iData;
+               if( term->NewHeight )
+                       ret = term->NewHeight;
+               else if( term->Mode == TERM_MODE_TEXT )
+                       ret = term->TextHeight;
                else
                        ret = term->Height;
                LEAVE('i', ret);
@@ -529,58 +640,6 @@ int VT_Terminal_IOCtl(tVFS_Node *Node, int Id, void *Data)
        return -1;
 }
 
-void VT_SetResolution(int Width, int Height)
-{
-       tVideo_IOCtl_Mode       mode = {0};
-        int    tmp;
-        int    i;
-       
-       // Create the video mode
-       mode.width = Width;
-       mode.height = Height;
-       mode.bpp = 32;
-       mode.flags = 0;
-       
-       // Set video mode
-       VFS_IOCtl( giVT_OutputDevHandle, VIDEO_IOCTL_FINDMODE, &mode );
-       tmp = mode.id;
-       if( Width != mode.width || Height != mode.height )
-       {
-               Log_Warning("VTerm",
-                       "Selected resolution (%ix%i is not supported) by the device, using (%ix%i)",
-                       giVT_RealWidth, giVT_RealHeight,
-                       mode.width, mode.height
-                       );
-       }
-       VFS_IOCtl( giVT_OutputDevHandle, VIDEO_IOCTL_GETSETMODE, &tmp );
-       
-       // Resize text terminals if needed
-       if( giVT_RealWidth != mode.width || giVT_RealHeight != mode.height )
-       {
-                int    newBufSize = (giVT_RealWidth/giVT_CharWidth)
-                                       *(giVT_RealHeight/giVT_CharHeight)
-                                       *(giVT_Scrollback+1);
-               //tVT_Char      *tmp;
-               // Resize the text terminals
-               giVT_RealWidth = mode.width;
-               giVT_RealHeight = mode.height;
-               for( i = 0; i < NUM_VTS; i ++ )
-               {
-                       if( gVT_Terminals[i].Mode != TERM_MODE_TEXT )   continue;
-                       
-                       gVT_Terminals[i].Text = realloc(
-                               gVT_Terminals[i].Text,
-                               newBufSize*sizeof(tVT_Char)
-                               );
-               }
-       }
-}
-
-void VT_SetMode(int Mode)
-{
-       VFS_IOCtl( giVT_OutputDevHandle, VIDEO_IOCTL_SETBUFFORMAT, &Mode );
-}
-
 /**
  * \fn void VT_SetTerminal(int ID)
  * \brief Set the current terminal
@@ -596,9 +655,10 @@ void VT_SetTerminal(int ID)
        if( gpVT_CurTerm->Mode == TERM_MODE_TEXT && !(gpVT_CurTerm->Flags & VT_FLAG_HIDECSR) )
        {
                tVideo_IOCtl_Pos        pos;
-               pos.x = gpVT_CurTerm->WritePos % gpVT_CurTerm->TextWidth;
-               pos.y = gpVT_CurTerm->WritePos / gpVT_CurTerm->TextWidth;
-               VFS_IOCtl(giVT_OutputDevHandle, VIDEO_IOCTL_SETCURSOR, &pos);
+               pos.x = (gpVT_CurTerm->WritePos - gpVT_CurTerm->ViewPos) % gpVT_CurTerm->TextWidth;
+               pos.y = (gpVT_CurTerm->WritePos - gpVT_CurTerm->ViewPos) / gpVT_CurTerm->TextWidth;
+               if( pos.x < gpVT_CurTerm->TextHeight )
+                       VFS_IOCtl(giVT_OutputDevHandle, VIDEO_IOCTL_SETCURSOR, &pos);
        }
        
        if( gpVT_CurTerm->Mode == TERM_MODE_TEXT )
@@ -768,6 +828,11 @@ void VT_KBCallBack(Uint32 Codepoint)
                        term->InputRead %= MAX_INPUT_CHARS32;
                }
        }
+       
+       // Wake up the thread waiting on us
+       if( term->ReadingThread >= 0 ) {
+               Threads_WakeTID(term->ReadingThread);
+       }
 }
 
 /**
@@ -778,7 +843,7 @@ void VT_int_ClearLine(tVTerm *Term, int Num)
 {
         int    i;
        tVT_Char        *cell = &Term->Text[ Num*Term->TextWidth ];
-       if( Num < 0 || Num >= Term->TextHeight )        return ;
+       if( Num < 0 || Num >= Term->TextHeight * (giVT_Scrollback + 1) )        return ;
        //ENTER("pTerm iNum", Term, Num);
        for( i = Term->TextWidth; i--; )
        {
@@ -818,17 +883,6 @@ int VT_int_ParseEscape(tVTerm *Term, char *Buffer)
                        } while(c == ';');
                }
                
-               /*
-               // Get string (what does this do?)
-               if(c == '"') {
-                       c = Buffer[j++];
-                       while(c != '"')
-                               c = Buffer[j++];
-               }
-               */
-               
-               //Log_Debug("VTerm", "argc = %i", argc);
-               
                // Get Command
                if(     ('a' <= c && c <= 'z') || ('A' <= c && c <= 'Z'))
                {
@@ -952,8 +1006,8 @@ void VT_int_PutString(tVTerm *Term, Uint8 *Buffer, Uint Count)
        if( Term == gpVT_CurTerm && !(Term->Flags & VT_FLAG_HIDECSR) )
        {
                tVideo_IOCtl_Pos        pos;
-               pos.x = Term->WritePos % Term->TextWidth;
-               pos.y = Term->WritePos / Term->TextWidth;
+               pos.x = (Term->WritePos - Term->ViewPos) % Term->TextWidth;
+               pos.y = (Term->WritePos - Term->ViewPos) / Term->TextWidth;
                VFS_IOCtl(giVT_OutputDevHandle, VIDEO_IOCTL_SETCURSOR, &pos);
        }
 }
@@ -1019,8 +1073,6 @@ void VT_int_PutChar(tVTerm *Term, Uint32 Ch)
        {
                 int    base, i;
                
-               //Debug("Scrolling entire buffer");
-               
                // Move back by one
                Term->WritePos -= Term->TextWidth;
                // Update the scren
@@ -1064,6 +1116,7 @@ void VT_int_PutChar(tVTerm *Term, Uint32 Ch)
                Term->WritePos -= Term->TextWidth;
                VT_int_UpdateScreen( Term, 0 );
                Term->WritePos += Term->TextWidth;
+               VT_int_ClearLine(Term, Term->WritePos / Term->TextWidth);
                
                // Scroll
                Term->ViewPos += Term->TextWidth;
@@ -1153,29 +1206,13 @@ void VT_int_UpdateScreen( tVTerm *Term, int UpdateAll )
 }
 
 /**
- * \fn void VT_int_ChangeMode(tVTerm *Term, int NewMode)
- * \brief Change the mode of a VTerm
+ * \brief Update the screen mode
+ * \param Term Terminal to update
+ * \param NewMode      New mode to set
+ * \param NewWidth     New framebuffer width
+ * \param NewHeight    New framebuffer height
  */
-void VT_int_ChangeMode(tVTerm *Term, int NewMode)
-{      
-       switch(NewMode)
-       {
-       case TERM_MODE_TEXT:
-               Log_Log("VTerm", "Set VT %p to text mode", Term);
-               break;
-       case TERM_MODE_FB:
-               Log_Log("VTerm", "Set VT %p to framebuffer mode (%ix%i)",
-                       Term, Term->Width, Term->Height);
-               break;
-       //case TERM_MODE_2DACCEL:
-       //case TERM_MODE_3DACCEL:
-       //      return;
-       }
-       
-       Term->Mode = NewMode;
-}
-
-void VT_int_UpdateResolution(tVTerm *Term, int NewWidth, int NewHeight)
+void VT_int_ChangeMode(tVTerm *Term, int NewMode, int NewWidth, int NewHeight)
 {
         int    oldW = Term->Width;
         int    oldTW = oldW / giVT_CharWidth;
@@ -1194,6 +1231,7 @@ void VT_int_UpdateResolution(tVTerm *Term, int NewWidth, int NewHeight)
        Term->TextHeight = NewHeight / giVT_CharHeight;
        Term->Width = NewWidth;
        Term->Height = NewHeight;
+       Term->Mode = NewMode;
        
        // Allocate new buffers
        // - Text
@@ -1236,6 +1274,23 @@ void VT_int_UpdateResolution(tVTerm *Term, int NewWidth, int NewHeight)
                                );
                }
        }
+       
+       
+       // Debug
+       switch(NewMode)
+       {
+       case TERM_MODE_TEXT:
+               Log_Log("VTerm", "Set VT %p to text mode (%ix%i)",
+                       Term, Term->TextWidth, Term->TextHeight);
+               break;
+       case TERM_MODE_FB:
+               Log_Log("VTerm", "Set VT %p to framebuffer mode (%ix%i)",
+                       Term, Term->Width, Term->Height);
+               break;
+       //case TERM_MODE_2DACCEL:
+       //case TERM_MODE_3DACCEL:
+       //      return;
+       }
 }
 
 // ---

UCC git Repository :: git.ucc.asn.au