client - Bugfixes (-u silently failed, and dispensed as the actual user)
[tpg/opendispense2.git] / src / client / main.c
index c5f335b..a675cfe 100644 (file)
 #define DEBUG_TRACE_SERVER     0
 #define USE_AUTOAUTH   1
 
+#define MAX_TXT_ARGS   5       // Maximum number of textual arguments (including command)
+#define DISPENSE_MULTIPLE_MAX  20      // Maximum argument to -c
+
+enum eUI_Modes
+{
+       UI_MODE_BASIC,  // Non-NCurses
+       UI_MODE_STANDARD,
+       UI_MODE_DRINKSONLY,
+       UI_MODE_ALL,
+       NUM_UI_MODES
+};
+
+enum eReturnValues
+{
+       RV_SUCCESS,
+       RV_BAD_ITEM,
+       RV_INVALID_USER,
+       RV_PERMISSIONS,
+       RV_ARGUMENTS,
+       RV_BALANCE,
+       RV_UNKNOWN_ERROR = -1,
+       RV_SOCKET_ERROR = -2
+};
+
 // === TYPES ===
 typedef struct sItem {
        char    *Type;
         int    ID;
+        int    Status; // 0: Availiable, 1: Sold out, -1: Error
        char    *Desc;
         int    Price;
 }      tItem;
@@ -42,7 +67,7 @@ typedef struct sItem {
 void   ShowUsage(void);
 // --- GUI ---
  int   ShowNCursesUI(void);
-void   ShowItemAt(int Row, int Col, int Width, int Index);
+ int   ShowItemAt(int Row, int Col, int Width, int Index, int bHilighted);
 void   PrintAlign(int Row, int Col, int Width, const char *Left, char Pad1, const char *Mid, char Pad2, const char *Right, ...);
 // --- Coke Server Communication ---
  int   OpenConnection(const char *Host, int Port);
@@ -78,26 +103,31 @@ regex_t    gArrayRegex, gItemRegex, gSaltRegex, gUserInfoRegex, gUserItemIdentRegex
 
 char   *gsItemPattern; //!< Item pattern
 char   *gsEffectiveUser;       //!< '-u' Dispense as another user
- int   gbUseNCurses = 0;       //!< '-G' Use the NCurses GUI?
+ int   giUIMode = UI_MODE_STANDARD;
  int   gbDryRun = 0;   //!< '-n' Read-only
  int   giMinimumBalance = INT_MIN;     //!< '-m' Minumum balance for `dispense acct`
  int   giMaximumBalance = INT_MAX;     //!< '-M' Maximum balance for `dispense acct`
 char   *gsUserName;    //!< User that dispense will happen as
 char   *gsUserFlags;   //!< User's flag set
  int   giUserBalance=-1;       //!< User balance (set by Authenticate)
+ int   giDispenseCount = 1;    //!< Number of dispenses to do
 
 // === CODE ===
 int main(int argc, char *argv[])
 {
         int    sock;
-        int    i;
+        int    i, ret = 0;
        char    buffer[BUFSIZ];
+       char    *text_args[MAX_TXT_ARGS];       // Non-flag arguments
+        int    text_argc = 0;
        
+       text_args[0] = "";
+
        // -- Create regular expressions
        // > Code Type Count ...
        CompileRegex(&gArrayRegex, "^([0-9]{3})\\s+([A-Za-z]+)\\s+([0-9]+)", REG_EXTENDED);     //
-       // > Code Type Ident Price Desc
-       CompileRegex(&gItemRegex, "^([0-9]{3})\\s+([A-Za-z]+)\\s+([A-Za-z]+):([0-9]+)\\s+([0-9]+)\\s+(.+)$", REG_EXTENDED);
+       // > Code Type Ident Status Price Desc
+       CompileRegex(&gItemRegex, "^([0-9]{3})\\s+([A-Za-z]+)\\s+([A-Za-z]+):([0-9]+)\\s+(avail|sold|error)\\s+([0-9]+)\\s+(.+)$", REG_EXTENDED);
        // > Code 'SALT' salt
        CompileRegex(&gSaltRegex, "^([0-9]{3})\\s+([A-Za-z]+)\\s+(.+)$", REG_EXTENDED);
        // > Code 'User' Username Balance Flags
@@ -118,11 +148,26 @@ int main(int argc, char *argv[])
                        case '?':
                                ShowUsage();
                                return 0;
-                       
+                                       
+                       case 'c':
+                               if( i + 1 >= argc ) {
+                                       fprintf(stderr, "%s: -c takes an argument\n", argv[0]);
+                                       ShowUsage();
+                                       return -1;
+                               }
+                               giDispenseCount = atoi(argv[++i]);
+                               if( giDispenseCount < 1 || giDispenseCount > DISPENSE_MULTIPLE_MAX ) {
+                                       fprintf(stderr, "Sorry, only 1-20 can be passed to -c (safety)\n");
+                                       return -1;
+                               }
+                               
+                               break ;
+       
                        case 'm':       // Minimum balance
                                if( i + 1 >= argc ) {
                                        fprintf(stderr, "%s: -m takes an argument\n", argv[0]);
                                        ShowUsage();
+                                       return RV_ARGUMENTS;
                                }
                                giMinimumBalance = atoi(argv[++i]);
                                break;
@@ -130,6 +175,7 @@ int main(int argc, char *argv[])
                                if( i + 1 >= argc ) {
                                        fprintf(stderr, "%s: -M takes an argument\n", argv[0]);
                                        ShowUsage();
+                                       return RV_ARGUMENTS;
                                }
                                giMaximumBalance = atoi(argv[++i]);
                                break;
@@ -138,6 +184,7 @@ int main(int argc, char *argv[])
                                if( i + 1 >= argc ) {
                                        fprintf(stderr, "%s: -u takes an argument\n", argv[0]);
                                        ShowUsage();
+                                       return RV_ARGUMENTS;
                                }
                                gsEffectiveUser = argv[++i];
                                break;
@@ -146,6 +193,7 @@ int main(int argc, char *argv[])
                                if( i + 1 >= argc ) {
                                        fprintf(stderr, "%s: -H takes an argument\n", argv[0]);
                                        ShowUsage();
+                                       return RV_ARGUMENTS;
                                }
                                gsDispenseServer = argv[++i];
                                break;
@@ -153,189 +201,260 @@ int main(int argc, char *argv[])
                                if( i + 1 >= argc ) {
                                        fprintf(stderr, "%s: -P takes an argument\n", argv[0]);
                                        ShowUsage();
+                                       return RV_ARGUMENTS;
                                }
                                giDispensePort = atoi(argv[++i]);
                                break;
                        
-                       case 'G':       // Use GUI
-                               gbUseNCurses = 1;
+                       case 'G':       // Don't use GUI
+                               giUIMode = UI_MODE_BASIC;
+                               break;
+                       case 'D':       // Drinks only
+                               giUIMode = UI_MODE_DRINKSONLY;
                                break;
                        case 'n':       // Dry Run / read-only
                                gbDryRun = 1;
                                break;
+                       default:
+                               if( text_argc + 1 ==  MAX_TXT_ARGS )
+                               {
+                                       fprintf(stderr, "ERROR: Too many arguments\n");
+                                       return RV_ARGUMENTS;
+                               }
+                               text_args[text_argc++] = argv[i];
+                               break;
                        }
 
                        continue;
                }
-               
-               //
-               // `dispense acct`
-               // - 
-               if( strcmp(arg, "acct") == 0 )
+
+               if( text_argc + 1 == MAX_TXT_ARGS )
                {
-                       // Connect to server
-                       sock = OpenConnection(gsDispenseServer, giDispensePort);
-                       if( sock < 0 )  return -1;
+                       fprintf(stderr, "ERROR: Too many arguments\n");
+                       return RV_ARGUMENTS;
+               }
+       
+               text_args[text_argc++] = argv[i];
+       
+       }
 
-                       // List accounts?
-                       if( i + 1 == argc ) {
-                               Dispense_EnumUsers(sock);
-                               return 0;
-                       }
-                       
-                       // argv[i+1]: Username
-                       
-                       // Alter account?
-                       if( i + 2 < argc )
-                       {
-                               if( i + 3 >= argc ) {
-                                       fprintf(stderr, "Error: `dispense acct' needs a reason\n");
-                                       exit(1);
-                               }
-                               
-                               // Authentication required
-                               if( Authenticate(sock) )
-                                       return -1;
-                               
-                               // argv[i+1]: Username
-                               // argv[i+2]: Ammount
-                               // argv[i+3]: Reason
-                               
-                               if( argv[i+2][0] == '=' ) {
-                                       // Set balance
-                                       if( argv[i+2][1] != '0' && atoi(&argv[i+2][1]) == 0 ) {
-                                               fprintf(stderr, "Error: Invalid balance to be set\n");
-                                               exit(1);
-                                       }
-                                       
-                                       Dispense_SetBalance(sock, argv[i+1], atoi(argv[i+2]+1), argv[i+3]);
-                               }
-                               else {
-                                       // Alter balance
-                                       Dispense_AlterBalance(sock, argv[i+1], atoi(argv[i+2]), argv[i+3]);
-                               }
-                       }
-                       
-                       // Show user information
-                       Dispense_ShowUser(sock, argv[i+1]);
-                       
+       //
+       // `dispense acct`
+       // - 
+       if( strcmp(text_args[0], "acct") == 0 )
+       {
+               // Connect to server
+               sock = OpenConnection(gsDispenseServer, giDispensePort);
+               if( sock < 0 )  return RV_SOCKET_ERROR;
+               // List accounts?
+               if( text_argc == 1 ) {
+                       ret = Dispense_EnumUsers(sock);
                        close(sock);
-                       return 0;
+                       return ret;
                }
-               //
-               // `dispense give`
-               // - "Here, have some money."
-               if( strcmp(arg, "give") == 0 )
-               {
-                       if( i + 3 >= argc ) {
-                               fprintf(stderr, "`dispense give` takes three arguments\n");
-                               ShowUsage();
-                               return -1;
-                       }
-                       
-                       // argv[i+1]: Destination
-                       // argv[i+2]: Ammount
-                       // argv[i+3]: Reason
                        
-                       // Connect to server
-                       sock = OpenConnection(gsDispenseServer, giDispensePort);
-                       if( sock < 0 )  return -1;
-                       
-                       // Authenticate
-                       if( Authenticate(sock) )
-                               return -1;
-                       
-                       Dispense_Give(sock, argv[i+1], atoi(argv[i+2]), argv[i+3]);
-                       return 0;
-               }
-               // 
-               // `dispense user`
-               // - User administration (Admin Only)
-               if( strcmp(arg, "user") == 0 )
+               // text_args[1]: Username
+               
+               // Alter account?
+               if( text_argc == 4 )
                {
-                       // Check argument count
-                       if( i + 1 >= argc ) {
-                               fprintf(stderr, "Error: `dispense user` requires arguments\n");
-                               ShowUsage();
-                               exit(1);
-                       }
-                       
-                       // Connect to server
-                       sock = OpenConnection(gsDispenseServer, giDispensePort);
-                       if( sock < 0 )  return -1;
+                       // Authentication required
+                       ret = Authenticate(sock);
+                       if(ret) return ret;
                        
-                       // Attempt authentication
-                       if( Authenticate(sock) )
-                               return -1;
+                       // text_args[1]: Username
+                       // text_args[2]: Ammount
+                       // text_args[3]: Reason
                        
-                       // Add new user?
-                       if( strcmp(argv[i+1], "add") == 0 )
-                       {
-                               if( i + 2 >= argc ) {
-                                       fprintf(stderr, "Error: `dispense user add` requires an argument\n");
-                                       ShowUsage();
-                                       exit(1);
-                               }
-                               
-                               Dispense_AddUser(sock, argv[i+2]);
-                       }
-                       // Update a user
-                       else if( strcmp(argv[i+1], "type") == 0 )
-                       {
-                               if( i + 3 >= argc ) {
-                                       fprintf(stderr, "Error: `dispense user type` requires two arguments\n");
-                                       ShowUsage();
+                       if( text_args[2][0] == '=' ) {
+                               // Set balance
+                               if( text_args[2][1] != '0' && atoi(text_args[2]+1) == 0 ) {
+                                       fprintf(stderr, "Error: Invalid balance to be set\n");
                                        exit(1);
                                }
                                
-                               Dispense_SetUserType(sock, argv[i+2], argv[i+3]);
+                               ret = Dispense_SetBalance(sock, text_args[1], atoi(text_args[2]+1), text_args[3]);
                        }
-                       else
-                       {
-                               fprintf(stderr, "Error: Unknown sub-command for `dispense user`\n");
-                               ShowUsage();
-                               exit(1);
+                       else {
+                               // Alter balance
+                               ret = Dispense_AlterBalance(sock, text_args[1], atoi(text_args[2]), text_args[3]);
                        }
-                       return 0;
+               }
+               // TODO: Preserve ret if non-zero
+               
+               // Show user information
+               ret = Dispense_ShowUser(sock, text_args[1]);
+               
+               close(sock);
+               return ret;
+       }
+       //
+       // `dispense give`
+       // - "Here, have some money."
+       if( strcmp(text_args[0], "give") == 0 )
+       {
+               if( text_argc != 4 ) {
+                       fprintf(stderr, "`dispense give` takes three arguments\n");
+                       ShowUsage();
+                       return RV_ARGUMENTS;
                }
                
-               // Donation!
-               if( strcmp(arg, "donate") == 0 )
+               // text_args[1]: Destination
+               // text_args[2]: Ammount
+               // text_args[3]: Reason
+               
+               // Connect to server
+               sock = OpenConnection(gsDispenseServer, giDispensePort);
+               if( sock < 0 )  return RV_SOCKET_ERROR;
+               
+               // Authenticate
+               ret = Authenticate(sock);
+               if(ret) return ret;
+               
+               ret = Dispense_Give(sock, text_args[1], atoi(text_args[2]), text_args[3]);
+
+               close(sock);
+       
+               return ret;
+       }
+       // 
+       // `dispense user`
+       // - User administration (Admin Only)
+       if( strcmp(text_args[0], "user") == 0 )
+       {
+               // Check argument count
+               if( text_argc == 1 ) {
+                       fprintf(stderr, "Error: `dispense user` requires arguments\n");
+                       ShowUsage();
+                       return RV_ARGUMENTS;
+               }
+               
+               // Connect to server
+               sock = OpenConnection(gsDispenseServer, giDispensePort);
+               if( sock < 0 )  return RV_SOCKET_ERROR;
+               
+               // Attempt authentication
+               ret = Authenticate(sock);
+               if(ret) return ret;
+               
+               // Add new user?
+               if( strcmp(text_args[1], "add") == 0 )
                {
-                       // Check argument count
-                       if( i + 2 >= argc ) {
-                               fprintf(stderr, "Error: `dispense donate` requires two arguments\n");
+                       if( text_argc != 3 ) {
+                               fprintf(stderr, "Error: `dispense user add` requires an argument\n");
                                ShowUsage();
-                               exit(1);
+                               return RV_ARGUMENTS;
                        }
                        
-                       // Connect to server
-                       sock = OpenConnection(gsDispenseServer, giDispensePort);
-                       if( sock < 0 )  return -1;
-                       
-                       // Attempt authentication
-                       if( Authenticate(sock) )
-                               return -1;
-                       
-                       // Do donation
-                       Dispense_Donate(sock, atoi(argv[i+1]), argv[i+1]);
+                       ret = Dispense_AddUser(sock, text_args[2]);
+               }
+               // Update a user
+               else if( strcmp(text_args[1], "type") == 0 || strcmp(text_args[1], "flags") == 0 )
+               {
+                       if( text_argc != 4 ) {
+                               fprintf(stderr, "Error: `dispense user flags` requires two arguments\n");
+                               ShowUsage();
+                               return RV_ARGUMENTS;
+                       }
                        
-                       return 0;
+                       ret = Dispense_SetUserType(sock, text_args[2], text_args[3]);
+               }
+               else
+               {
+                       fprintf(stderr, "Error: Unknown sub-command for `dispense user`\n");
+                       ShowUsage();
+                       return RV_ARGUMENTS;
+               }
+               close(sock);
+               return ret;
+       }
+       // Donation!
+       else if( strcmp(text_args[0], "donate") == 0 )
+       {
+               // Check argument count
+               if( text_argc != 3 ) {
+                       fprintf(stderr, "Error: `dispense donate` requires two arguments\n");
+                       ShowUsage();
+                       return RV_ARGUMENTS;
                }
                
-               else {
-                       // Item name / pattern
-                       gsItemPattern = arg;
-                       break;
+               // Connect to server
+               sock = OpenConnection(gsDispenseServer, giDispensePort);
+               if( sock < 0 )  return RV_SOCKET_ERROR;
+               
+               // Attempt authentication
+               ret = Authenticate(sock);
+               if(ret) return ret;
+               
+               // Do donation
+               ret = Dispense_Donate(sock, atoi(text_args[1]), text_args[2]);
+                               
+               close(sock);
+
+               return ret;
+       }
+       // Refund an item
+       else if( strcmp(text_args[0], "refund") == 0 )
+       {
+               // Check argument count
+               if( text_argc != 3 && text_argc != 4 ) {
+                       fprintf(stderr, "Error: `dispense refund` takes 2 or 3 arguments\n");
+                       ShowUsage();
+                       return RV_ARGUMENTS;
                }
+       
+               // Connect to server
+               sock = OpenConnection(gsDispenseServer, giDispensePort);
+               if(sock < 0)    return RV_SOCKET_ERROR; 
+
+               // Attempt authentication
+               ret = Authenticate(sock);
+               if(ret) return ret;
+
+               // TODO: More
+               close(ret);
+               return RV_UNKNOWN_ERROR;
+       }
+       // Query an item price
+       else if( strcmp(text_args[0], "iteminfo") == 0 )
+       {
+               regmatch_t matches[3];
+               char    *type;
+                int    id;
+               // Check argument count
+               if( text_argc != 2 ) {
+                       fprintf(stderr, "Error: `dispense iteminfo` requires an argument\n");
+                       ShowUsage();
+                       return RV_ARGUMENTS;
+               }
+               // Parse item ID
+               if( RunRegex(&gUserItemIdentRegex, text_args[1], 3, matches, NULL) != 0 ) {
+                       fprintf(stderr, "Error: Invalid item ID passed (<type>:<id> expected)\n");
+                       return RV_ARGUMENTS;
+               }
+               type = text_args[1] + matches[1].rm_so;
+               text_args[1][ matches[1].rm_eo ] = '\0';
+               id = atoi( text_args[1] + matches[2].rm_so );
+
+               sock = OpenConnection(gsDispenseServer, giDispensePort);
+               if( sock < 0 )  return RV_SOCKET_ERROR;
+               
+               ret = Dispense_ItemInfo(sock, type, id);
+               close(sock);
+               return ret;
+       }
+       // Item name / pattern
+       else {
+               gsItemPattern = text_args[0];
        }
        
        // Connect to server
        sock = OpenConnection(gsDispenseServer, giDispensePort);
-       if( sock < 0 )  return -1;
+       if( sock < 0 )  return RV_SOCKET_ERROR;
 
        // Get the user's balance
-       GetUserBalance(sock);
+       ret = GetUserBalance(sock);
+       if(ret) return ret;
 
        // Get items
        PopulateItemList(sock);
@@ -343,7 +462,7 @@ int main(int argc, char *argv[])
        // Disconnect from server
        close(sock);
        
-       if( gsItemPattern )
+       if( gsItemPattern && gsItemPattern[0] )
        {
                regmatch_t matches[3];
                // Door (hard coded)
@@ -351,11 +470,12 @@ int main(int argc, char *argv[])
                {
                        // Connect, Authenticate, dispense and close
                        sock = OpenConnection(gsDispenseServer, giDispensePort);
-                       if( sock < 0 )  return -1;
-                       Authenticate(sock);
-                       DispenseItem(sock, "door", 0);
+                       if( sock < 0 )  return RV_SOCKET_ERROR;
+                       ret = Authenticate(sock);
+                       if(ret) return ret;
+                       ret = DispenseItem(sock, "door", 0);
                        close(sock);
-                       return 0;
+                       return ret;
                }
                // Item id (<type>:<num>)
                else if( RunRegex(&gUserItemIdentRegex, gsItemPattern, 3, matches, NULL) == 0 )
@@ -371,14 +491,15 @@ int main(int argc, char *argv[])
                        
                        // Connect, Authenticate, dispense and close
                        sock = OpenConnection(gsDispenseServer, giDispensePort);
-                       if( sock < 0 )  return -1;
+                       if( sock < 0 )  return RV_SOCKET_ERROR;
                        
                        Dispense_ItemInfo(sock, ident, id);
                        
-                       Authenticate(sock);
-                       DispenseItem(sock, ident, id);
+                       ret = Authenticate(sock);
+                       if(ret) return ret;
+                       ret = DispenseItem(sock, ident, id);
                        close(sock);
-                       return 0;
+                       return ret;
                }
                // Item number (6 = coke)
                else if( strcmp(gsItemPattern, "0") == 0 || atoi(gsItemPattern) > 0 )
@@ -419,7 +540,7 @@ int main(int argc, char *argv[])
                                        // TODO: Allow ambiguous matches?
                                        // or just print a wanrning
                                        printf("Warning - Ambiguous pattern, stopping\n");
-                                       return 1;
+                                       return RV_BAD_ITEM;
                                }
                        }
                        
@@ -427,13 +548,13 @@ int main(int argc, char *argv[])
                        if( best == -1 )
                        {
                                fprintf(stderr, "No item matches the passed string\n");
-                               return 1;
+                               return RV_BAD_ITEM;
                        }
                        
                        i = best;
                }
        }
-       else if( gbUseNCurses )
+       else if( giUIMode != UI_MODE_BASIC )
        {
                i = ShowNCursesUI();
        }
@@ -441,6 +562,10 @@ int main(int argc, char *argv[])
        {
                // Very basic dispense interface
                for( i = 0; i < giNumItems; i ++ ) {
+                       // Add a separator
+                       if( i && strcmp(gaItems[i].Type, gaItems[i-1].Type) != 0 )
+                               printf("   ---\n");
+                       
                        printf("%2i %s:%i\t%3i %s\n", i, gaItems[i].Type, gaItems[i].ID,
                                gaItems[i].Price, gaItems[i].Desc);
                }
@@ -474,18 +599,28 @@ int main(int argc, char *argv[])
        // Check for a valid item ID
        if( i >= 0 )
        {
+                int j;
                // Connect, Authenticate, dispense and close
                sock = OpenConnection(gsDispenseServer, giDispensePort);
-               if( sock < 0 )  return -1;
+               if( sock < 0 )  return RV_SOCKET_ERROR;
                        
-               Dispense_ItemInfo(sock, gaItems[i].Type, gaItems[i].ID);
+               ret = Dispense_ItemInfo(sock, gaItems[i].Type, gaItems[i].ID);
+               if(ret) return ret;
+               
+               ret = Authenticate(sock);
+               if(ret) return ret;
                
-               Authenticate(sock);
-               DispenseItem(sock, gaItems[i].Type, gaItems[i].ID);
+               for( j = 0; j < giDispenseCount; j ++ ) {
+                       ret = DispenseItem(sock, gaItems[i].Type, gaItems[i].ID);
+                       if( ret )       break;
+               }
+               if( j > 1 ) {
+                       printf("%i items dispensed\n", j);
+               }
                close(sock);
        }
 
-       return 0;
+       return ret;
 }
 
 void ShowUsage(void)
@@ -495,12 +630,14 @@ void ShowUsage(void)
                "  == Everyone ==\n"
                "    dispense\n"
                "        Show interactive list\n"
-               "    dispense <item>\n"
-               "        Dispense named item\n"
+               "    dispense <name>|<index>|<itemid>\n"
+               "        Dispense named item (<name> matches if it is a unique prefix)\n"
                "    dispense give <user> <ammount> \"<reason>\"\n"
                "        Give money to another user\n"
                "    dispense donate <ammount> \"<reason>\"\n"
                "        Donate to the club\n"
+               "    dispense iteminfo <type>:<id>\n"
+               "        Get the name and price for an item\n"
                "  == Coke members == \n"
                "    dispense acct [<user>]\n"
                "        Show user balances\n"
@@ -517,6 +654,8 @@ void ShowUsage(void)
                "        Flags are removed by preceding the name with '-' or '!'\n"
                "\n"
                "General Options:\n"
+               "    -c <count>\n"
+               "        Dispense multiple times\n"
                "    -u <username>\n"
                "        Set a different user (Coke members only)\n"
                "    -h / -?\n"
@@ -544,11 +683,11 @@ int ShowNCursesUI(void)
         int    i, times;
         int    xBase, yBase;
        const int       displayMinWidth = 40;
-       const int       displayMinItems = 8;
        char    *titleString = "Dispense";
-        int    itemCount = displayMinItems;
+        int    itemCount;
+        int    maxItemIndex;
         int    itemBase = 0;
-        int    currentItem = 0;
+        int    currentItem;
         int    ret = -2;       // -2: Used for marking "no return yet"
        
        char    balance_str[5+1+2+1];   // If $9999.99 is too little, something's wrong
@@ -565,17 +704,24 @@ int ShowNCursesUI(void)
                username = pwd->pw_name;
        }
        // Get balance
-       snprintf(balance_str, sizeof balance_str, "$%i.%02i", giUserBalance/100, giUserBalance%100);
+       snprintf(balance_str, sizeof balance_str, "$%i.%02i", giUserBalance/100, abs(giUserBalance)%100);
        
        // Enter curses mode
        initscr();
-       raw(); noecho();
+       cbreak(); noecho();
        
-       // Get item count
+       // Get max index
+       maxItemIndex = ShowItemAt(0, 0, 0, -1, 0);
+       // Get item count per screen
        // - 6: randomly chosen (Need at least 3)
        itemCount = LINES - 6;
-       if( itemCount > giNumItems )
-               itemCount = giNumItems;
+       if( itemCount > maxItemIndex )
+               itemCount = maxItemIndex;
+       // Get first index
+       currentItem = 0;
+       while( ShowItemAt(0, 0, 0, currentItem, 0) == -1 )
+               currentItem ++;
+       
        
        // Get dimensions
        height = itemCount + 3;
@@ -593,35 +739,35 @@ int ShowNCursesUI(void)
                // Items
                for( i = 0; i < itemCount; i ++ )
                {
+                        int    pos = 0;
+                       
                        move( yBase + 1 + i, xBase );
+                       printw("| ");
                        
-                       if( currentItem == itemBase + i ) {
-                               printw("| -> ");
-                       }
-                       else {
-                               printw("|    ");
-                       }
+                       pos += 2;
                        
-                       // Check for ... row
+                       // Check for the '...' row
                        // - Oh god, magic numbers!
-                       if( i == 0 && itemBase > 0 ) {
-                               printw("   ...");
-                               times = width-1 - 8 - 3;
-                               while(times--)  addch(' ');
-                       }
-                       else if( i == itemCount - 1 && itemBase < giNumItems - itemCount ) {
-                               printw("   ...");
-                               times = width-1 - 8 - 3;
+                       if( (i == 0 && itemBase > 0)
+                        || (i == itemCount - 1 && itemBase < maxItemIndex - itemCount) )
+                       {
+                               printw("     ...");     pos += 8;
+                               times = (width - pos) - 1;
                                while(times--)  addch(' ');
                        }
                        // Show an item
                        else {
-                               ShowItemAt( yBase + 1 + i, xBase + 5, width - 7, itemBase + i);
-                               addch(' ');
+                               ShowItemAt(
+                                       yBase + 1 + i, xBase + pos,     // Position
+                                       (width - pos) - 3,      // Width
+                                       itemBase + i,   // Index
+                                       !!(currentItem == itemBase + i) // Hilighted
+                                       );
+                               printw("  ");
                        }
                        
                        // Scrollbar (if needed)
-                       if( giNumItems > itemCount ) {
+                       if( maxItemIndex > itemCount ) {
                                if( i == 0 ) {
                                        addch('A');
                                }
@@ -629,7 +775,7 @@ int ShowNCursesUI(void)
                                        addch('V');
                                }
                                else {
-                                        int    percentage = itemBase * 100 / (giNumItems-itemCount);
+                                        int    percentage = itemBase * 100 / (maxItemIndex-itemCount);
                                        if( i-1 == percentage*(itemCount-3)/100 ) {
                                                addch('#');
                                        }
@@ -663,32 +809,47 @@ int ShowNCursesUI(void)
                                switch(ch)
                                {
                                case 'B':
-                                       //if( itemBase < giNumItems - (itemCount) )
-                                       //      itemBase ++;
-                                       if( currentItem < giNumItems - 1 )
+                                       currentItem ++;
+                                       // Skip over spacers
+                                       while( ShowItemAt(0, 0, 0, currentItem, 0) == -1 )
                                                currentItem ++;
-                                       if( itemBase + itemCount - 1 <= currentItem && itemBase + itemCount < giNumItems )
-                                               itemBase ++;
+                                       
+                                       if( currentItem >= maxItemIndex ) {
+                                               currentItem = 0;
+                                               // Skip over spacers
+                                               while( ShowItemAt(0, 0, 0, currentItem, 0) == -1 )
+                                                       currentItem ++;
+                                       }
                                        break;
                                case 'A':
-                                       //if( itemBase > 0 )
-                                       //      itemBase --;
-                                       if( currentItem > 0 )
+                                       currentItem --;
+                                       // Skip over spacers
+                                       while( ShowItemAt(0, 0, 0, currentItem, 0) == -1 )
                                                currentItem --;
-                                       if( itemBase + 1 > currentItem && itemBase > 0 )
-                                               itemBase --;
+                                       
+                                       if( currentItem < 0 ) {
+                                               currentItem = maxItemIndex - 1;
+                                               // Skip over spacers
+                                               while( ShowItemAt(0, 0, 0, currentItem, 0) == -1 )
+                                                       currentItem --;
+                                       }
                                        break;
                                }
                        }
                        else {
                                
                        }
+                       
+                       if( itemCount > maxItemIndex && currentItem < itemBase + 2 && itemBase > 0 )
+                               itemBase = currentItem - 2;
+                       if( itemCount > maxItemIndex && currentItem > itemBase + itemCount - 2 && itemBase < maxItemIndex-1 )
+                               itemBase = currentItem - itemCount + 2;
                }
                else {
                        switch(ch)
                        {
                        case '\n':
-                               ret = currentItem;
+                               ret = ShowItemAt(0, 0, 0, currentItem, 0);
                                break;
                        case 'q':
                                ret = -1;       // -1: Return with no dispense
@@ -709,32 +870,113 @@ int ShowNCursesUI(void)
 
 /**
  * \brief Show item \a Index at (\a Col, \a Row)
+ * \return Dispense index of item
  * \note Part of the NCurses UI
  */
-void ShowItemAt(int Row, int Col, int Width, int Index)
+int ShowItemAt(int Row, int Col, int Width, int Index, int bHilighted)
 {
         int    _x, _y, times;
-       char    *name;
-        int    price;
-       
-       move( Row, Col );
+       char    *name = NULL;
+        int    price = 0;
+        int    status = -1;
        
-       if( Index < 0 || Index >= giNumItems ) {
-               name = "OOR";
-               price = 0;
-       }
-       else {
+       switch(giUIMode)
+       {
+       // Standard UI
+       // - This assumes that 
+       case UI_MODE_STANDARD:
+               // Bounds check
+               // Index = -1, request limit
+               if( Index < 0 || Index >= giNumItems+2 )
+                       return giNumItems+2;
+               // Drink label
+               if( Index == 0 )
+               {
+                       price = 0;
+                       name = "Coke Machine";
+                       Index = -1;     // -1 indicates a label
+                       break;
+               }
+               Index --;
+               // Drinks 0 - 6
+               if( Index <= 6 )
+               {
+                       name = gaItems[Index].Desc;
+                       price = gaItems[Index].Price;
+                       status = gaItems[Index].Status;
+                       break;
+               }
+               Index -= 7;
+               // EPS label
+               if( Index == 0 )
+               {
+                       price = 0;
+                       name = "Electronic Payment System";
+                       Index = -1;     // -1 indicates a label
+                       break;
+               }
+               Index --;
+               Index += 7;
                name = gaItems[Index].Desc;
                price = gaItems[Index].Price;
+               status = gaItems[Index].Status;
+               break;
+       default:
+               return -1;
        }
-
-       printw("%02i %s", Index, name);
        
-       getyx(stdscr, _y, _x);
-       // Assumes max 4 digit prices
-       times = Width - 4 - (_x - Col); // TODO: Better handling for large prices
-       while(times--)  addch(' ');
-       printw("%4i", price);
+       // Width = 0, don't print
+       if( Width > 0 )
+       {
+               // 4 preceding, 5 price
+               int nameWidth = Width - 4 - 5;
+               move( Row, Col );
+               
+               if( Index >= 0 )
+               {
+                       // Show hilight and status
+                       switch( status )
+                       {
+                       case 0:
+                               if( bHilighted )
+                                       printw("->  ");
+                               else
+                                       printw("    ");
+                               break;
+                       case 1:
+                               printw("SLD ");
+                               break;
+                       
+                       default:
+                       case -1:
+                               printw("ERR ");
+                               break;
+                       }
+                       
+                       printw("%-*.*s", nameWidth, nameWidth, name);
+               
+//                     getyx(stdscr, _y, _x);
+                       // Assumes max 4 digit prices
+//                     times = Width - 5 - (_x - Col); // TODO: Better handling for large prices
+//                     while(times--)  addch(' ');
+                       
+                       printw(" %4i", price);
+               }
+               else
+               {
+                       printw("-- %s", name);
+                       getyx(stdscr, _y, _x);
+                       times = Width - 4 - (_x - Col);
+                       while(times--)  addch(' ');
+                       printw("    ");
+               }
+       }
+       
+       // If the item isn't availiable for sale, return -1 (so it's skipped)
+       if( status )
+               Index = -1;
+       
+       return Index;
 }
 
 /**
@@ -826,8 +1068,10 @@ int OpenConnection(const char *Host, int Port)
                fprintf(stderr, "Failed to create socket\n");
                return -1;
        }
+
+//     printf("geteuid() = %i, getuid() = %i\n", geteuid(), getuid());
        
-       if( geteuid() == 0 )
+       if( geteuid() == 0 || getuid() == 0 )
        {
                 int    i;
                struct sockaddr_in      localAddr;
@@ -835,7 +1079,7 @@ int OpenConnection(const char *Host, int Port)
                localAddr.sin_family = AF_INET; // IPv4
                
                // Loop through all the top ports until one is avaliable
-               for( i = 1001; i < 1024; i ++)
+               for( i = 512; i < 1024; i ++)
                {
                        localAddr.sin_port = htons(i);  // IPv4
                        // Attempt to bind to low port for autoauth
@@ -844,6 +1088,8 @@ int OpenConnection(const char *Host, int Port)
                }
                if( i == 1024 )
                        printf("Warning: AUTOAUTH unavaliable\n");
+//             else
+//                     printf("Bound to 0.0.0.0:%i\n", i);
        }
        
        if( connect(sock, (struct sockaddr *) &serverAddr, sizeof(serverAddr)) < 0 ) {
@@ -901,7 +1147,7 @@ int Authenticate(int Socket)
                if( responseCode != 100 ) {
                        fprintf(stderr, "Unknown repsonse code %i from server\n%s\n", responseCode, buf);
                        free(buf);
-                       return -1;      // ERROR
+                       return RV_UNKNOWN_ERROR;        // ERROR
                }
                
                // Check for salt
@@ -947,23 +1193,23 @@ int Authenticate(int Socket)
                        
                        fprintf(stderr, "Unknown repsonse code %i from server\n%s\n", responseCode, buf);
                        free(buf);
-                       return -1;
+                       return RV_UNKNOWN_ERROR;
                }
                free(buf);
                if( i == 3 )
-                       return 2;       // 2 = Bad Password
+                       return RV_INVALID_USER; // 2 = Bad Password
                break;
        
        case 404:       // Bad Username
                fprintf(stderr, "Bad Username '%s'\n", pwd->pw_name);
                free(buf);
-               return 1;
+               return RV_INVALID_USER;
        
        default:
                fprintf(stderr, "Unkown response code %i from server\n", responseCode);
                printf("%s\n", buf);
                free(buf);
-               return -1;
+               return RV_UNKNOWN_ERROR;
        }
        
        // Set effective user
@@ -982,18 +1228,18 @@ int Authenticate(int Socket)
                case 403:
                        printf("Only coke members can use `dispense -u`\n");
                        free(buf);
-                       return -1;
+                       return RV_PERMISSIONS;
                
                case 404:
                        printf("Invalid user selected\n");
                        free(buf);
-                       return -1;
+                       return RV_INVALID_USER;
                
                default:
                        fprintf(stderr, "Unkown response code %i from server\n", responseCode);
                        printf("%s\n", buf);
                        free(buf);
-                       exit(-1);
+                       return RV_UNKNOWN_ERROR;
                }
                
                free(buf);
@@ -1032,13 +1278,13 @@ int GetUserBalance(int Socket)
        case 404:
                printf("Invalid user? (USER_INFO failed)\n");
                free(buf);
-               return -1;
+               return RV_INVALID_USER;
        
        default:
                fprintf(stderr, "Unkown response code %i from server\n", responseCode);
                printf("%s\n", buf);
                free(buf);
-               exit(-1);
+               return RV_UNKNOWN_ERROR;
        }
 
        RunRegex(&gUserInfoRegex, buf, 6, matches, "Malformed server response");
@@ -1051,6 +1297,73 @@ int GetUserBalance(int Socket)
        return 0;
 }
 
+/**
+ * \brief Read an item info response from the server
+ * \param Dest Destination for the read item (strings will be on the heap)
+ */
+int ReadItemInfo(int Socket, tItem *Dest)
+{
+       char    *buf;
+        int    responseCode;
+       
+       regmatch_t      matches[8];
+       char    *statusStr;
+       
+       // Get item info
+       buf = ReadLine(Socket);
+       responseCode = atoi(buf);
+       
+       switch(responseCode)
+       {
+       case 202:       break;
+       
+       case 406:
+               printf("Bad item name\n");
+               free(buf);
+               return RV_BAD_ITEM;
+       
+       default:
+               fprintf(stderr, "Unknown response from dispense server (Response Code %i)\n%s", responseCode, buf);
+               free(buf);
+               return RV_UNKNOWN_ERROR;
+       }
+       
+       RunRegex(&gItemRegex, buf, 8, matches, "Malformed server response");
+       
+       buf[ matches[3].rm_eo ] = '\0';
+       buf[ matches[5].rm_eo ] = '\0';
+       buf[ matches[7].rm_eo ] = '\0';
+       
+       statusStr = &buf[ matches[5].rm_so ];
+       
+       Dest->ID = atoi( buf + matches[4].rm_so );
+       
+       if( strcmp(statusStr, "avail") == 0 )
+               Dest->Status = 0;
+       else if( strcmp(statusStr, "sold") == 0 )
+               Dest->Status = 1;
+       else if( strcmp(statusStr, "error") == 0 )
+               Dest->Status = -1;
+       else {
+               fprintf(stderr, "Unknown response from dispense server (status '%s')\n",
+                       statusStr);
+               return RV_UNKNOWN_ERROR;
+       }
+       Dest->Price = atoi( buf + matches[6].rm_so );
+       
+       // Hack a little to reduce heap fragmentation
+       {
+               char    tmpType[strlen(buf + matches[3].rm_so) + 1];
+               char    tmpDesc[strlen(buf + matches[7].rm_so) + 1];
+               strcpy(tmpType, buf + matches[3].rm_so);
+               strcpy(tmpDesc, buf + matches[7].rm_so);
+               free(buf);
+               Dest->Type = strdup( tmpType );
+               Dest->Desc = strdup( tmpDesc );
+       }
+       
+       return 0;
+}
 
 /**
  * \brief Fill the item information structure
@@ -1074,7 +1387,7 @@ void PopulateItemList(int Socket)
        responseCode = atoi(buf);
        if( responseCode != 201 ) {
                fprintf(stderr, "Unknown response from dispense server (Response Code %i)\n", responseCode);
-               exit(-1);
+               exit(RV_UNKNOWN_ERROR);
        }
        
        // - Get item list -
@@ -1092,7 +1405,7 @@ void PopulateItemList(int Socket)
                // What the?!
                fprintf(stderr, "Unexpected array type, expected 'Items', got '%s'\n",
                        itemType);
-               exit(-1);
+               exit(RV_UNKNOWN_ERROR);
        }
                
        itemStart = &buf[ matches[3].rm_eo ];
@@ -1105,27 +1418,7 @@ void PopulateItemList(int Socket)
        // Fetch item information
        for( i = 0; i < giNumItems; i ++ )
        {
-               regmatch_t      matches[7];
-               
-               // Get item info
-               buf = ReadLine(Socket);
-               responseCode = atoi(buf);
-               
-               if( responseCode != 202 ) {
-                       fprintf(stderr, "Unknown response from dispense server (Response Code %i)\n", responseCode);
-                       exit(-1);
-               }
-               
-               RunRegex(&gItemRegex, buf, 7, matches, "Malformed server response");
-               
-               buf[ matches[3].rm_eo ] = '\0';
-               
-               gaItems[i].Type = strdup( buf + matches[3].rm_so );
-               gaItems[i].ID = atoi( buf + matches[4].rm_so );
-               gaItems[i].Price = atoi( buf + matches[5].rm_so );
-               gaItems[i].Desc = strdup( buf + matches[6].rm_so );
-               
-               free(buf);
+               ReadItemInfo( Socket, &gaItems[i] );
        }
        
        // Read end of list
@@ -1149,46 +1442,22 @@ void PopulateItemList(int Socket)
  */
 int Dispense_ItemInfo(int Socket, const char *Type, int ID)
 {
-        int    responseCode;
-       char    *buf;
-       regmatch_t matches[7];
-       char    *type, *desc;
-        int    id, price;
+       tItem   item;
+        int    ret;
        
-       // Dispense!
+       // Query
        sendf(Socket, "ITEM_INFO %s:%i\n", Type, ID);
-       buf = ReadLine(Socket);
-       
-       responseCode = atoi(buf);
-       switch( responseCode )
-       {
-       case 202:
-               break;
-       
-       case 406:
-               printf("Bad item name\n");
-               free(buf);
-               return 1;
        
-       default:
-               printf("Unknown response code %i ('%s')\n", responseCode, buf);
-               free(buf);
-               return -1;
-       }
-       
-               
-       RunRegex(&gItemRegex, buf, 7, matches, "Malformed server response");
+       ret = ReadItemInfo(Socket, &item);
+       if(ret) return ret;
        
-       buf[ matches[3].rm_eo ] = '\0';
+       printf("%8s:%-2i %2i.%02i %s\n",
+               item.Type, item.ID,
+               item.Price/100, item.Price%100,
+               item.Desc);
        
-       type = buf + matches[3].rm_so;  buf[matches[3].rm_eo] = '\0';
-       id = atoi( buf + matches[4].rm_so );
-       price = atoi( buf + matches[5].rm_so );
-       desc = buf + matches[6].rm_so;  buf[matches[6].rm_eo] = '\0';
-       
-       printf("%8s:%-2i %2i.%02i %s\n", type, id, price/100, price%100, desc);
-       
-       free(buf);
+       free(item.Type);
+       free(item.Desc);
        
        return 0;
 }
@@ -1221,15 +1490,15 @@ int DispenseItem(int Socket, const char *Type, int ID)
                break;
        case 401:
                printf("Not authenticated\n");
-               ret = 1;
+               ret = RV_PERMISSIONS;
                break;
        case 402:
                printf("Insufficient balance\n");
-               ret = 1;
+               ret = RV_BALANCE;
                break;
        case 406:
                printf("Bad item name\n");
-               ret = 1;
+               ret = RV_BAD_ITEM;
                break;
        case 500:
                printf("Item failed to dispense, is the slot empty?\n");
@@ -1241,7 +1510,7 @@ int DispenseItem(int Socket, const char *Type, int ID)
                break;
        default:
                printf("Unknown response code %i ('%s')\n", responseCode, buf);
-               ret = -2;
+               ret = RV_UNKNOWN_ERROR;
                break;
        }
        
@@ -1262,6 +1531,12 @@ int Dispense_AlterBalance(int Socket, const char *Username, int Ammount, const c
                printf("Dry Run - No action\n");
                return 0;
        }
+
+       // Sanity
+       if( Ammount == 0 ) {
+               printf("An ammount would be nice\n");
+               return RV_ARGUMENTS;
+       }
        
        sendf(Socket, "ADD %s %i %s\n", Username, Ammount, Reason);
        buf = ReadLine(Socket);
@@ -1337,13 +1612,13 @@ int Dispense_Give(int Socket, const char *Username, int Ammount, const char *Rea
        
        if( Ammount < 0 ) {
                printf("Sorry, you can only give, you can't take.\n");
-               return -1;
+               return 1;
        }
        
        // Fast return on zero
        if( Ammount == 0 ) {
                printf("Are you actually going to give any?\n");
-               return 0;
+               return 1;
        }
        
        // Check for a dry run
@@ -1360,7 +1635,9 @@ int Dispense_Give(int Socket, const char *Username, int Ammount, const char *Rea
        
        switch(responseCode)
        {
-       case 200:       return 0;       // OK
+       case 200:
+               printf("Give succeeded\n");
+               return 0;       // OK
        
        case 402:       
                fprintf(stderr, "Insufficient balance\n");
@@ -1395,7 +1672,7 @@ int Dispense_Donate(int Socket, int Ammount, const char *Reason)
        // Fast return on zero
        if( Ammount == 0 ) {
                printf("Are you actually going to give any?\n");
-               return 0;
+               return 1;
        }
        
        // Check for a dry run

UCC git Repository :: git.ucc.asn.au