Item statuses
[tpg/opendispense2.git] / src / client / main.c
index 46e1259..aa62471 100644 (file)
 #define DEBUG_TRACE_SERVER     0
 #define USE_AUTOAUTH   1
 
+enum eUI_Modes
+{
+       UI_MODE_BASIC,  // Non-NCurses
+       UI_MODE_STANDARD,
+       UI_MODE_DRINKSONLY,
+       UI_MODE_ALL,
+       NUM_UI_MODES
+};
+
 // === TYPES ===
 typedef struct sItem {
        char    *Type;
         int    ID;
+        int    Status; // 0: Availiable, 1: Sold out, -1: Error
        char    *Desc;
         int    Price;
 }      tItem;
@@ -42,13 +52,15 @@ typedef struct sItem {
 void   ShowUsage(void);
 // --- GUI ---
  int   ShowNCursesUI(void);
-void   ShowItemAt(int Row, int Col, int Width, int Index);
+ int   ShowItemAt(int Row, int Col, int Width, int Index, int bHilighted);
 void   PrintAlign(int Row, int Col, int Width, const char *Left, char Pad1, const char *Mid, char Pad2, const char *Right, ...);
 // --- Coke Server Communication ---
  int   OpenConnection(const char *Host, int Port);
  int   Authenticate(int Socket);
+ int   GetUserBalance(int Socket);
 void   PopulateItemList(int Socket);
- int   DispenseItem(int Socket, int ItemID);
+ int   Dispense_ItemInfo(int Socket, const char *Type, int ID);
+ int   DispenseItem(int Socket, const char *Type, int ID);
  int   Dispense_AlterBalance(int Socket, const char *Username, int Ammount, const char *Reason);
  int   Dispense_SetBalance(int Socket, const char *Username, int Balance, const char *Reason);
  int   Dispense_Give(int Socket, const char *Username, int Ammount, const char *Reason);
@@ -71,14 +83,18 @@ char        *gsDispenseServer = "heathred";
 
 tItem  *gaItems;
  int   giNumItems;
-regex_t        gArrayRegex, gItemRegex, gSaltRegex, gUserInfoRegex;
+regex_t        gArrayRegex, gItemRegex, gSaltRegex, gUserInfoRegex, gUserItemIdentRegex;
  int   gbIsAuthenticated = 0;
 
 char   *gsItemPattern; //!< Item pattern
 char   *gsEffectiveUser;       //!< '-u' Dispense as another user
- int   gbUseNCurses = 0;       //!< '-G' Use the NCurses GUI?
+ int   giUIMode = UI_MODE_STANDARD;
+ int   gbDryRun = 0;   //!< '-n' Read-only
  int   giMinimumBalance = INT_MIN;     //!< '-m' Minumum balance for `dispense acct`
  int   giMaximumBalance = INT_MAX;     //!< '-M' Maximum balance for `dispense acct`
+char   *gsUserName;    //!< User that dispense will happen as
+char   *gsUserFlags;   //!< User's flag set
+ int   giUserBalance=-1;       //!< User balance (set by Authenticate)
 
 // === CODE ===
 int main(int argc, char *argv[])
@@ -90,12 +106,14 @@ int main(int argc, char *argv[])
        // -- Create regular expressions
        // > Code Type Count ...
        CompileRegex(&gArrayRegex, "^([0-9]{3})\\s+([A-Za-z]+)\\s+([0-9]+)", REG_EXTENDED);     //
-       // > Code Type Ident Price Desc
-       CompileRegex(&gItemRegex, "^([0-9]{3})\\s+([A-Za-z]+)\\s+([A-Za-z]+):([0-9]+)\\s+([0-9]+)\\s+(.+)$", REG_EXTENDED);
+       // > Code Type Ident Status Price Desc
+       CompileRegex(&gItemRegex, "^([0-9]{3})\\s+([A-Za-z]+)\\s+([A-Za-z]+):([0-9]+)\\s+(avail|sold|error)\\s+([0-9]+)\\s+(.+)$", REG_EXTENDED);
        // > Code 'SALT' salt
        CompileRegex(&gSaltRegex, "^([0-9]{3})\\s+([A-Za-z]+)\\s+(.+)$", REG_EXTENDED);
        // > Code 'User' Username Balance Flags
        CompileRegex(&gUserInfoRegex, "^([0-9]{3})\\s+([A-Za-z]+)\\s+([^ ]+)\\s+(-?[0-9]+)\\s+(.+)$", REG_EXTENDED);
+       // > Item Ident
+       CompileRegex(&gUserItemIdentRegex, "^([A-Za-z]+):([0-9]+)$", REG_EXTENDED);
 
        // Parse Arguments
        for( i = 1; i < argc; i ++ )
@@ -112,18 +130,51 @@ int main(int argc, char *argv[])
                                return 0;
                        
                        case 'm':       // Minimum balance
+                               if( i + 1 >= argc ) {
+                                       fprintf(stderr, "%s: -m takes an argument\n", argv[0]);
+                                       ShowUsage();
+                               }
                                giMinimumBalance = atoi(argv[++i]);
                                break;
                        case 'M':       // Maximum balance
+                               if( i + 1 >= argc ) {
+                                       fprintf(stderr, "%s: -M takes an argument\n", argv[0]);
+                                       ShowUsage();
+                               }
                                giMaximumBalance = atoi(argv[++i]);
                                break;
                        
                        case 'u':       // Override User
+                               if( i + 1 >= argc ) {
+                                       fprintf(stderr, "%s: -u takes an argument\n", argv[0]);
+                                       ShowUsage();
+                               }
                                gsEffectiveUser = argv[++i];
                                break;
                        
-                       case 'G':       // Use GUI
-                               gbUseNCurses = 1;
+                       case 'H':       // Override remote host
+                               if( i + 1 >= argc ) {
+                                       fprintf(stderr, "%s: -H takes an argument\n", argv[0]);
+                                       ShowUsage();
+                               }
+                               gsDispenseServer = argv[++i];
+                               break;
+                       case 'P':       // Override remote port
+                               if( i + 1 >= argc ) {
+                                       fprintf(stderr, "%s: -P takes an argument\n", argv[0]);
+                                       ShowUsage();
+                               }
+                               giDispensePort = atoi(argv[++i]);
+                               break;
+                       
+                       case 'G':       // Don't use GUI
+                               giUIMode = UI_MODE_BASIC;
+                               break;
+                       case 'D':       // Drinks only
+                               giUIMode = UI_MODE_DRINKSONLY;
+                               break;
+                       case 'n':       // Dry Run / read-only
+                               gbDryRun = 1;
                                break;
                        }
 
@@ -194,7 +245,6 @@ int main(int argc, char *argv[])
                                ShowUsage();
                                return -1;
                        }
-                       // TODO: `dispense give`
                        
                        // argv[i+1]: Destination
                        // argv[i+2]: Ammount
@@ -297,6 +347,9 @@ int main(int argc, char *argv[])
        sock = OpenConnection(gsDispenseServer, giDispensePort);
        if( sock < 0 )  return -1;
 
+       // Get the user's balance
+       GetUserBalance(sock);
+
        // Get items
        PopulateItemList(sock);
        
@@ -305,18 +358,106 @@ int main(int argc, char *argv[])
        
        if( gsItemPattern )
        {
-               // TODO: Implement `dispense <name>`
-               printf("TODO: Implement `dispense <name>`\n");
-               i = -1;
+               regmatch_t matches[3];
+               // Door (hard coded)
+               if( strcmp(gsItemPattern, "door") == 0 )
+               {
+                       // Connect, Authenticate, dispense and close
+                       sock = OpenConnection(gsDispenseServer, giDispensePort);
+                       if( sock < 0 )  return -1;
+                       Authenticate(sock);
+                       DispenseItem(sock, "door", 0);
+                       close(sock);
+                       return 0;
+               }
+               // Item id (<type>:<num>)
+               else if( RunRegex(&gUserItemIdentRegex, gsItemPattern, 3, matches, NULL) == 0 )
+               {
+                       char    *ident;
+                        int    id;
+                       
+                       // Get and finish ident
+                       ident = gsItemPattern + matches[1].rm_so;
+                       gsItemPattern[matches[1].rm_eo] = '\0';
+                       // Get ID
+                       id = atoi( gsItemPattern + matches[2].rm_so );
+                       
+                       // Connect, Authenticate, dispense and close
+                       sock = OpenConnection(gsDispenseServer, giDispensePort);
+                       if( sock < 0 )  return -1;
+                       
+                       Dispense_ItemInfo(sock, ident, id);
+                       
+                       Authenticate(sock);
+                       DispenseItem(sock, ident, id);
+                       close(sock);
+                       return 0;
+               }
+               // Item number (6 = coke)
+               else if( strcmp(gsItemPattern, "0") == 0 || atoi(gsItemPattern) > 0 )
+               {
+                       i = atoi(gsItemPattern);
+               }
+               // Item prefix
+               else
+               {
+                        int    j;
+                        int    best = -1;
+                       for( i = 0; i < giNumItems; i ++ )
+                       {
+                               // Prefix match (with case-insensitive match)
+                               for( j = 0; gsItemPattern[j]; j ++ )
+                               {
+                                       if( gaItems[i].Desc[j] == gsItemPattern[j] )
+                                               continue;
+                                       if( tolower(gaItems[i].Desc[j]) == tolower(gsItemPattern[j]) )
+                                               continue;
+                                       break;
+                               }
+                               // Check if the prefix matched
+                               if( gsItemPattern[j] != '\0' )
+                                       continue;
+                               
+                               // Prefect match
+                               if( gaItems[i].Desc[j] == '\0' ) {
+                                       best = i;
+                                       break;
+                               }
+                               
+                               // Only one match allowed
+                               if( best == -1 ) {
+                                       best = i;
+                               }
+                               else {
+                                       // TODO: Allow ambiguous matches?
+                                       // or just print a wanrning
+                                       printf("Warning - Ambiguous pattern, stopping\n");
+                                       return 1;
+                               }
+                       }
+                       
+                       // Was a match found?
+                       if( best == -1 )
+                       {
+                               fprintf(stderr, "No item matches the passed string\n");
+                               return 1;
+                       }
+                       
+                       i = best;
+               }
        }
-       else if( gbUseNCurses )
+       else if( giUIMode != UI_MODE_BASIC )
        {
                i = ShowNCursesUI();
        }
        else
        {
                // Very basic dispense interface
-               for( i = 0; i < giNumItems; i ++ ) {            
+               for( i = 0; i < giNumItems; i ++ ) {
+                       // Add a separator
+                       if( i && strcmp(gaItems[i].Type, gaItems[i-1].Type) != 0 )
+                               printf("   ---\n");
+                       
                        printf("%2i %s:%i\t%3i %s\n", i, gaItems[i].Type, gaItems[i].ID,
                                gaItems[i].Price, gaItems[i].Desc);
                }
@@ -353,8 +494,11 @@ int main(int argc, char *argv[])
                // Connect, Authenticate, dispense and close
                sock = OpenConnection(gsDispenseServer, giDispensePort);
                if( sock < 0 )  return -1;
+                       
+               Dispense_ItemInfo(sock, gaItems[i].Type, gaItems[i].ID);
+               
                Authenticate(sock);
-               DispenseItem(sock, i);
+               DispenseItem(sock, gaItems[i].Type, gaItems[i].ID);
                close(sock);
        }
 
@@ -417,24 +561,45 @@ int ShowNCursesUI(void)
         int    i, times;
         int    xBase, yBase;
        const int       displayMinWidth = 40;
-       const int       displayMinItems = 8;
        char    *titleString = "Dispense";
-        int    itemCount = displayMinItems;
+        int    itemCount;
+        int    maxItemIndex;
         int    itemBase = 0;
-        int    currentItem = 0;
+        int    currentItem;
         int    ret = -2;       // -2: Used for marking "no return yet"
+       
+       char    balance_str[5+1+2+1];   // If $9999.99 is too little, something's wrong
+       char    *username;
+       struct passwd *pwd;
         
         int    height, width;
         
+       // Get Username
+       if( gsEffectiveUser )
+               username = gsEffectiveUser;
+       else {
+               pwd = getpwuid( getuid() );
+               username = pwd->pw_name;
+       }
+       // Get balance
+       snprintf(balance_str, sizeof balance_str, "$%i.%02i", giUserBalance/100, giUserBalance%100);
+       
        // Enter curses mode
        initscr();
        raw(); noecho();
        
-       // Get item count
+       // Get max index
+       maxItemIndex = ShowItemAt(0, 0, 0, -1, 0);
+       // Get item count per screen
        // - 6: randomly chosen (Need at least 3)
        itemCount = LINES - 6;
-       if( itemCount > giNumItems )
-               itemCount = giNumItems;
+       if( itemCount > maxItemIndex )
+               itemCount = maxItemIndex;
+       // Get first index
+       currentItem = 0;
+       while( ShowItemAt(0, 0, 0, currentItem, 0) == -1 )
+               currentItem ++;
+       
        
        // Get dimensions
        height = itemCount + 3;
@@ -452,35 +617,35 @@ int ShowNCursesUI(void)
                // Items
                for( i = 0; i < itemCount; i ++ )
                {
+                        int    pos = 0;
+                       
                        move( yBase + 1 + i, xBase );
+                       printw("| ");
                        
-                       if( currentItem == itemBase + i ) {
-                               printw("| -> ");
-                       }
-                       else {
-                               printw("|    ");
-                       }
+                       pos += 2;
                        
-                       // Check for ... row
+                       // Check for the '...' row
                        // - Oh god, magic numbers!
-                       if( i == 0 && itemBase > 0 ) {
-                               printw("   ...");
-                               times = width-1 - 8 - 3;
-                               while(times--)  addch(' ');
-                       }
-                       else if( i == itemCount - 1 && itemBase < giNumItems - itemCount ) {
-                               printw("   ...");
-                               times = width-1 - 8 - 3;
+                       if( (i == 0 && itemBase > 0)
+                        || (i == itemCount - 1 && itemBase < maxItemIndex - itemCount) )
+                       {
+                               printw("     ...");     pos += 8;
+                               times = (width - pos) - 1;
                                while(times--)  addch(' ');
                        }
                        // Show an item
                        else {
-                               ShowItemAt( yBase + 1 + i, xBase + 5, width - 7, itemBase + i);
-                               addch(' ');
+                               ShowItemAt(
+                                       yBase + 1 + i, xBase + pos,     // Position
+                                       (width - pos) - 3,      // Width
+                                       itemBase + i,   // Index
+                                       !!(currentItem == itemBase + i) // Hilighted
+                                       );
+                               printw("  ");
                        }
                        
                        // Scrollbar (if needed)
-                       if( giNumItems > itemCount ) {
+                       if( maxItemIndex > itemCount ) {
                                if( i == 0 ) {
                                        addch('A');
                                }
@@ -488,7 +653,7 @@ int ShowNCursesUI(void)
                                        addch('V');
                                }
                                else {
-                                        int    percentage = itemBase * 100 / (giNumItems-itemCount);
+                                        int    percentage = itemBase * 100 / (maxItemIndex-itemCount);
                                        if( i-1 == percentage*(itemCount-3)/100 ) {
                                                addch('#');
                                        }
@@ -505,6 +670,12 @@ int ShowNCursesUI(void)
                // Footer
                PrintAlign(yBase+height-2, xBase, width, "\\", '-', "", '-', "/");
                
+               // User line
+               // - Username, balance, flags
+               PrintAlign(yBase+height-1, xBase+1, width-2,
+                       username, ' ', balance_str, ' ', gsUserFlags);
+               
+               
                // Get input
                ch = getch();
                
@@ -516,32 +687,47 @@ int ShowNCursesUI(void)
                                switch(ch)
                                {
                                case 'B':
-                                       //if( itemBase < giNumItems - (itemCount) )
-                                       //      itemBase ++;
-                                       if( currentItem < giNumItems - 1 )
+                                       currentItem ++;
+                                       // Skip over spacers
+                                       while( ShowItemAt(0, 0, 0, currentItem, 0) == -1 )
                                                currentItem ++;
-                                       if( itemBase + itemCount - 1 <= currentItem && itemBase + itemCount < giNumItems )
-                                               itemBase ++;
+                                       
+                                       if( currentItem >= maxItemIndex ) {
+                                               currentItem = 0;
+                                               // Skip over spacers
+                                               while( ShowItemAt(0, 0, 0, currentItem, 0) == -1 )
+                                                       currentItem ++;
+                                       }
                                        break;
                                case 'A':
-                                       //if( itemBase > 0 )
-                                       //      itemBase --;
-                                       if( currentItem > 0 )
+                                       currentItem --;
+                                       // Skip over spacers
+                                       while( ShowItemAt(0, 0, 0, currentItem, 0) == -1 )
                                                currentItem --;
-                                       if( itemBase + 1 > currentItem && itemBase > 0 )
-                                               itemBase --;
+                                       
+                                       if( currentItem < 0 ) {
+                                               currentItem = maxItemIndex - 1;
+                                               // Skip over spacers
+                                               while( ShowItemAt(0, 0, 0, currentItem, 0) == -1 )
+                                                       currentItem --;
+                                       }
                                        break;
                                }
                        }
                        else {
                                
                        }
+                       
+                       if( itemCount > maxItemIndex && currentItem < itemBase + 2 && itemBase > 0 )
+                               itemBase = currentItem - 2;
+                       if( itemCount > maxItemIndex && currentItem > itemBase + itemCount - 2 && itemBase < maxItemIndex-1 )
+                               itemBase = currentItem - itemCount + 2;
                }
                else {
                        switch(ch)
                        {
                        case '\n':
-                               ret = currentItem;
+                               ret = ShowItemAt(0, 0, 0, currentItem, 0);
                                break;
                        case 'q':
                                ret = -1;       // -1: Return with no dispense
@@ -562,32 +748,111 @@ int ShowNCursesUI(void)
 
 /**
  * \brief Show item \a Index at (\a Col, \a Row)
+ * \return Dispense index of item
  * \note Part of the NCurses UI
  */
-void ShowItemAt(int Row, int Col, int Width, int Index)
+int ShowItemAt(int Row, int Col, int Width, int Index, int bHilighted)
 {
         int    _x, _y, times;
-       char    *name;
-        int    price;
-       
-       move( Row, Col );
+       char    *name = NULL;
+        int    price = 0;
+        int    status = -1;
        
-       if( Index < 0 || Index >= giNumItems ) {
-               name = "OOR";
-               price = 0;
-       }
-       else {
+       switch(giUIMode)
+       {
+       // Standard UI
+       // - This assumes that 
+       case UI_MODE_STANDARD:
+               // Bounds check
+               // Index = -1, request limit
+               if( Index < 0 || Index >= giNumItems+2 )
+                       return giNumItems+2;
+               // Drink label
+               if( Index == 0 )
+               {
+                       price = 0;
+                       name = "Coke Machine";
+                       Index = -1;     // -1 indicates a label
+                       break;
+               }
+               Index --;
+               // Drinks 0 - 6
+               if( Index <= 6 )
+               {
+                       name = gaItems[Index].Desc;
+                       price = gaItems[Index].Price;
+                       status = gaItems[Index].Status;
+                       break;
+               }
+               Index -= 7;
+               // EPS label
+               if( Index == 0 )
+               {
+                       price = 0;
+                       name = "Electronic Payment System";
+                       Index = -1;     // -1 indicates a label
+                       break;
+               }
+               Index --;
+               Index += 7;
                name = gaItems[Index].Desc;
                price = gaItems[Index].Price;
+               status = gaItems[Index].Status;
+               break;
+       default:
+               return -1;
        }
-
-       printw("%02i %s", Index, name);
        
-       getyx(stdscr, _y, _x);
-       // Assumes max 4 digit prices
-       times = Width - 4 - (_x - Col); // TODO: Better handling for large prices
-       while(times--)  addch(' ');
-       printw("%4i", price);
+       // Width = 0, don't print
+       if( Width > 0 )
+       {
+               move( Row, Col );
+               
+               if( Index >= 0 )
+               {
+                       // Show hilight and status
+                       switch( status )
+                       {
+                       case 0:
+                               if( bHilighted )
+                                       printw("-> ");
+                               else
+                                       printw("   ");
+                               break;
+                       case 1:
+                               printw("SLD");
+                               break;
+                       
+                       default:
+                       case -1:
+                               printw("ERR");
+                               break;
+                       }
+                       
+                       printw(" %s", name);
+               
+                       getyx(stdscr, _y, _x);
+                       // Assumes max 4 digit prices
+                       times = Width - 5 - (_x - Col); // TODO: Better handling for large prices
+                       while(times--)  addch(' ');
+                       
+                       printw(" %4i", price);
+               }
+               else
+               {
+                       printw("-- %s", name);
+                       getyx(stdscr, _y, _x);
+                       times = Width - 4 - (_x - Col);
+                       while(times--)  addch(' ');
+                       printw("    ");
+               }
+       }
+       
+       // If the item isn't availiable for sale, return -1 (so it's skipped)
+       if( status )
+               Index = -1;
+       
+       return Index;
 }
 
 /**
@@ -632,7 +897,7 @@ void PrintAlign(int Row, int Col, int Width, const char *Left, char Pad1,
                addstr(tmp);
        }
        // - Left padding
-       times = Width/2 - mLen/2 - lLen;
+       times = (Width - mLen)/2 - lLen;
        while(times--)  addch(Pad1);
        // - Middle
        {
@@ -641,7 +906,8 @@ void PrintAlign(int Row, int Col, int Width, const char *Left, char Pad1,
                addstr(tmp);
        }
        // - Right Padding
-       times = Width/2 - mLen/2 - rLen;
+       times = (Width - mLen)/2 - rLen;
+       if( (Width - mLen) % 2 )        times ++;
        while(times--)  addch(Pad2);
        // - Right
        {
@@ -856,6 +1122,119 @@ int Authenticate(int Socket)
        return 0;
 }
 
+int GetUserBalance(int Socket)
+{
+       regmatch_t      matches[6];
+       struct passwd   *pwd;
+       char    *buf;
+        int    responseCode;
+       
+       if( !gsUserName )
+       {
+               if( gsEffectiveUser ) {
+                       gsUserName = gsEffectiveUser;
+               }
+               else {
+                       pwd = getpwuid( getuid() );
+                       gsUserName = strdup(pwd->pw_name);
+               }
+       }
+       
+       sendf(Socket, "USER_INFO %s\n", gsUserName);
+       buf = ReadLine(Socket);
+       responseCode = atoi(buf);
+       switch(responseCode)
+       {
+       case 202:       break;  // Ok
+       
+       case 404:
+               printf("Invalid user? (USER_INFO failed)\n");
+               free(buf);
+               return -1;
+       
+       default:
+               fprintf(stderr, "Unkown response code %i from server\n", responseCode);
+               printf("%s\n", buf);
+               free(buf);
+               exit(-1);
+       }
+
+       RunRegex(&gUserInfoRegex, buf, 6, matches, "Malformed server response");
+       
+       giUserBalance = atoi( buf + matches[4].rm_so );
+       gsUserFlags = strdup( buf + matches[5].rm_so );
+       
+       free(buf);
+       
+       return 0;
+}
+
+/**
+ * \brief Read an item info response from the server
+ * \param Dest Destination for the read item (strings will be on the heap)
+ */
+int ReadItemInfo(int Socket, tItem *Dest)
+{
+       char    *buf;
+        int    responseCode;
+       
+       regmatch_t      matches[8];
+       char    *statusStr;
+       
+       // Get item info
+       buf = ReadLine(Socket);
+       responseCode = atoi(buf);
+       
+       switch(responseCode)
+       {
+       case 202:       break;
+       
+       case 406:
+               printf("Bad item name\n");
+               free(buf);
+               return 1;
+       
+       default:
+               fprintf(stderr, "Unknown response from dispense server (Response Code %i)\n%s", responseCode, buf);
+               exit(-1);
+       }
+       
+       RunRegex(&gItemRegex, buf, 8, matches, "Malformed server response");
+       
+       buf[ matches[3].rm_eo ] = '\0';
+       buf[ matches[5].rm_eo ] = '\0';
+       buf[ matches[7].rm_eo ] = '\0';
+       
+       statusStr = &buf[ matches[5].rm_so ];
+       
+       Dest->ID = atoi( buf + matches[4].rm_so );
+       
+       if( strcmp(statusStr, "avail") == 0 )
+               Dest->Status = 0;
+       else if( strcmp(statusStr, "sold") == 0 )
+               Dest->Status = 1;
+       else if( strcmp(statusStr, "error") == 0 )
+               Dest->Status = -1;
+       else {
+               fprintf(stderr, "Unknown response from dispense server (status '%s')\n",
+                       statusStr);
+               return 1;
+       }
+       Dest->Price = atoi( buf + matches[6].rm_so );
+       
+       // Hack a little to reduce heap fragmentation
+       {
+               char    tmpType[strlen(buf + matches[3].rm_so) + 1];
+               char    tmpDesc[strlen(buf + matches[7].rm_so) + 1];
+               strcpy(tmpType, buf + matches[3].rm_so);
+               strcpy(tmpDesc, buf + matches[7].rm_so);
+               free(buf);
+               Dest->Type = strdup( tmpType );
+               Dest->Desc = strdup( tmpDesc );
+       }
+       
+       return 0;
+}
 
 /**
  * \brief Fill the item information structure
@@ -910,27 +1289,7 @@ void PopulateItemList(int Socket)
        // Fetch item information
        for( i = 0; i < giNumItems; i ++ )
        {
-               regmatch_t      matches[7];
-               
-               // Get item info
-               buf = ReadLine(Socket);
-               responseCode = atoi(buf);
-               
-               if( responseCode != 202 ) {
-                       fprintf(stderr, "Unknown response from dispense server (Response Code %i)\n", responseCode);
-                       exit(-1);
-               }
-               
-               RunRegex(&gItemRegex, buf, 7, matches, "Malformed server response");
-               
-               buf[ matches[3].rm_eo ] = '\0';
-               
-               gaItems[i].Type = strdup( buf + matches[3].rm_so );
-               gaItems[i].ID = atoi( buf + matches[4].rm_so );
-               gaItems[i].Price = atoi( buf + matches[5].rm_so );
-               gaItems[i].Desc = strdup( buf + matches[6].rm_so );
-               
-               free(buf);
+               ReadItemInfo( Socket, &gaItems[i] );
        }
        
        // Read end of list
@@ -947,19 +1306,51 @@ void PopulateItemList(int Socket)
        free(buf);
 }
 
+
+/**
+ * \brief Get information on an item
+ * \return Boolean Failure
+ */
+int Dispense_ItemInfo(int Socket, const char *Type, int ID)
+{
+       tItem   item;
+       
+       // Query
+       sendf(Socket, "ITEM_INFO %s:%i\n", Type, ID);
+       
+       if( ReadItemInfo(Socket, &item) )
+       {
+               return -1;
+       }
+       
+       printf("%8s:%-2i %2i.%02i %s\n",
+               item.Type, item.ID,
+               item.Price/100, item.Price%100,
+               item.Desc);
+       
+       free(item.Type);
+       free(item.Desc);
+       
+       return 0;
+}
+
 /**
  * \brief Dispense an item
  * \return Boolean Failure
  */
-int DispenseItem(int Socket, int ItemID)
+int DispenseItem(int Socket, const char *Type, int ID)
 {
         int    ret, responseCode;
        char    *buf;
        
-       if( ItemID < 0 || ItemID > giNumItems ) return -1;
+       // Check for a dry run
+       if( gbDryRun ) {
+               printf("Dry Run - No action\n");
+               return 0;
+       }
        
        // Dispense!
-       sendf(Socket, "DISPENSE %s:%i\n", gaItems[ItemID].Type, gaItems[ItemID].ID);
+       sendf(Socket, "DISPENSE %s:%i\n", Type, ID);
        buf = ReadLine(Socket);
        
        responseCode = atoi(buf);
@@ -978,7 +1369,7 @@ int DispenseItem(int Socket, int ItemID)
                ret = 1;
                break;
        case 406:
-               printf("Bad item name, bug report\n");
+               printf("Bad item name\n");
                ret = 1;
                break;
        case 500:
@@ -1007,6 +1398,12 @@ int Dispense_AlterBalance(int Socket, const char *Username, int Ammount, const c
        char    *buf;
         int    responseCode;
        
+       // Check for a dry run
+       if( gbDryRun ) {
+               printf("Dry Run - No action\n");
+               return 0;
+       }
+       
        sendf(Socket, "ADD %s %i %s\n", Username, Ammount, Reason);
        buf = ReadLine(Socket);
        
@@ -1042,6 +1439,12 @@ int Dispense_SetBalance(int Socket, const char *Username, int Balance, const cha
        char    *buf;
         int    responseCode;
        
+       // Check for a dry run
+       if( gbDryRun ) {
+               printf("Dry Run - No action\n");
+               return 0;
+       }
+       
        sendf(Socket, "SET %s %i %s\n", Username, Balance, Reason);
        buf = ReadLine(Socket);
        
@@ -1084,6 +1487,12 @@ int Dispense_Give(int Socket, const char *Username, int Ammount, const char *Rea
                return 0;
        }
        
+       // Check for a dry run
+       if( gbDryRun ) {
+               printf("Dry Run - No action\n");
+               return 0;
+       }
+       
        sendf(Socket, "GIVE %s %i %s\n", Username, Ammount, Reason);
        buf = ReadLine(Socket);
        
@@ -1130,6 +1539,12 @@ int Dispense_Donate(int Socket, int Ammount, const char *Reason)
                return 0;
        }
        
+       // Check for a dry run
+       if( gbDryRun ) {
+               printf("Dry Run - No action\n");
+               return 0;
+       }
+       
        sendf(Socket, "DONATE %i %s\n", Ammount, Reason);
        buf = ReadLine(Socket);
        
@@ -1285,6 +1700,12 @@ int Dispense_AddUser(int Socket, const char *Username)
        char    *buf;
         int    responseCode, ret;
        
+       // Check for a dry run
+       if( gbDryRun ) {
+               printf("Dry Run - No action\n");
+               return 0;
+       }
+       
        sendf(Socket, "USER_ADD %s\n", Username);
        
        buf = ReadLine(Socket);
@@ -1323,6 +1744,12 @@ int Dispense_SetUserType(int Socket, const char *Username, const char *TypeStrin
        char    *buf;
         int    responseCode, ret;
        
+       // Check for a dry run
+       if( gbDryRun ) {
+               printf("Dry Run - No action\n");
+               return 0;
+       }
+       
        // TODO: Pre-validate the string
        
        sendf(Socket, "USER_FLAGS %s %s\n", Username, TypeString);
@@ -1463,7 +1890,7 @@ int RunRegex(regex_t *regex, const char *string, int nMatches, regmatch_t *match
         int    ret;
        
        ret = regexec(regex, string, nMatches, matches, 0);
-       if( ret ) {
+       if( ret && errorMessage ) {
                size_t  len = regerror(ret, regex, NULL, 0);
                char    errorStr[len];
                regerror(ret, regex, errorStr, len);

UCC git Repository :: git.ucc.asn.au