Implemented `dispense <item>`
[tpg/opendispense2.git] / src / client / main.c
index d3adeee..f30ce43 100644 (file)
 
 #define        USE_NCURSES_INTERFACE   0
 #define DEBUG_TRACE_SERVER     0
+#define USE_AUTOAUTH   1
 
 // === TYPES ===
 typedef struct sItem {
-       char    *Ident;
+       char    *Type;
+        int    ID;
        char    *Desc;
         int    Price;
 }      tItem;
@@ -46,9 +48,12 @@ void PrintAlign(int Row, int Col, int Width, const char *Left, char Pad1, const
  int   OpenConnection(const char *Host, int Port);
  int   Authenticate(int Socket);
 void   PopulateItemList(int Socket);
- int   DispenseItem(int Socket, int ItemID);
+ int   Dispense_ItemInfo(int Socket, const char *Type, int ID);
+ int   DispenseItem(int Socket, const char *Type, int ID);
  int   Dispense_AlterBalance(int Socket, const char *Username, int Ammount, const char *Reason);
- int   Dispense_SetBalance(int Socket, const char *Username, int Ammount, const char *Reason);
+ int   Dispense_SetBalance(int Socket, const char *Username, int Balance, const char *Reason);
+ int   Dispense_Give(int Socket, const char *Username, int Ammount, const char *Reason);
+ int   Dispense_Donate(int Socket, int Ammount, const char *Reason);
  int   Dispense_EnumUsers(int Socket);
  int   Dispense_ShowUser(int Socket, const char *Username);
 void   _PrintUserLine(const char *Line);
@@ -62,17 +67,18 @@ char        *trim(char *string);
 void   CompileRegex(regex_t *regex, const char *pattern, int flags);
 
 // === GLOBALS ===
-char   *gsDispenseServer = "localhost";
+char   *gsDispenseServer = "heathred";
  int   giDispensePort = 11020;
 
 tItem  *gaItems;
  int   giNumItems;
-regex_t        gArrayRegex, gItemRegex, gSaltRegex, gUserInfoRegex;
+regex_t        gArrayRegex, gItemRegex, gSaltRegex, gUserInfoRegex, gUserItemIdentRegex;
  int   gbIsAuthenticated = 0;
 
 char   *gsItemPattern; //!< Item pattern
-char   *gsOverrideUser;        //!< '-u' Dispense as another user
+char   *gsEffectiveUser;       //!< '-u' Dispense as another user
  int   gbUseNCurses = 0;       //!< '-G' Use the NCurses GUI?
+ int   gbDryRun = 0;   //!< '-n' Read-only
  int   giMinimumBalance = INT_MIN;     //!< '-m' Minumum balance for `dispense acct`
  int   giMaximumBalance = INT_MAX;     //!< '-M' Maximum balance for `dispense acct`
 
@@ -87,11 +93,13 @@ int main(int argc, char *argv[])
        // > Code Type Count ...
        CompileRegex(&gArrayRegex, "^([0-9]{3})\\s+([A-Za-z]+)\\s+([0-9]+)", REG_EXTENDED);     //
        // > Code Type Ident Price Desc
-       CompileRegex(&gItemRegex, "^([0-9]{3})\\s+([A-Za-z]+)\\s+([A-Za-z0-9:]+?)\\s+([0-9]+)\\s+(.+)$", REG_EXTENDED);
+       CompileRegex(&gItemRegex, "^([0-9]{3})\\s+([A-Za-z]+)\\s+([A-Za-z]+):([0-9]+)\\s+([0-9]+)\\s+(.+)$", REG_EXTENDED);
        // > Code 'SALT' salt
        CompileRegex(&gSaltRegex, "^([0-9]{3})\\s+([A-Za-z]+)\\s+(.+)$", REG_EXTENDED);
        // > Code 'User' Username Balance Flags
        CompileRegex(&gUserInfoRegex, "^([0-9]{3})\\s+([A-Za-z]+)\\s+([^ ]+)\\s+(-?[0-9]+)\\s+(.+)$", REG_EXTENDED);
+       // > Item Ident
+       CompileRegex(&gUserItemIdentRegex, "^([A-Za-z]+):([0-9]+)$", REG_EXTENDED);
 
        // Parse Arguments
        for( i = 1; i < argc; i ++ )
@@ -108,24 +116,57 @@ int main(int argc, char *argv[])
                                return 0;
                        
                        case 'm':       // Minimum balance
+                               if( i + 1 >= argc ) {
+                                       fprintf(stderr, "%s: -m takes an argument\n", argv[0]);
+                                       ShowUsage();
+                               }
                                giMinimumBalance = atoi(argv[++i]);
                                break;
                        case 'M':       // Maximum balance
+                               if( i + 1 >= argc ) {
+                                       fprintf(stderr, "%s: -M takes an argument\n", argv[0]);
+                                       ShowUsage();
+                               }
                                giMaximumBalance = atoi(argv[++i]);
                                break;
                        
                        case 'u':       // Override User
-                               gsOverrideUser = argv[++i];
+                               if( i + 1 >= argc ) {
+                                       fprintf(stderr, "%s: -u takes an argument\n", argv[0]);
+                                       ShowUsage();
+                               }
+                               gsEffectiveUser = argv[++i];
+                               break;
+                       
+                       case 'H':       // Override remote host
+                               if( i + 1 >= argc ) {
+                                       fprintf(stderr, "%s: -H takes an argument\n", argv[0]);
+                                       ShowUsage();
+                               }
+                               gsDispenseServer = argv[++i];
+                               break;
+                       case 'P':       // Override remote port
+                               if( i + 1 >= argc ) {
+                                       fprintf(stderr, "%s: -P takes an argument\n", argv[0]);
+                                       ShowUsage();
+                               }
+                               giDispensePort = atoi(argv[++i]);
                                break;
                        
                        case 'G':       // Use GUI
                                gbUseNCurses = 1;
                                break;
+                       case 'n':       // Dry Run / read-only
+                               gbDryRun = 1;
+                               break;
                        }
 
                        continue;
                }
                
+               //
+               // `dispense acct`
+               // - 
                if( strcmp(arg, "acct") == 0 )
                {
                        // Connect to server
@@ -158,7 +199,12 @@ int main(int argc, char *argv[])
                                
                                if( argv[i+2][0] == '=' ) {
                                        // Set balance
-                                       Dispense_SetBalance(sock, argv[i+1], atoi(argv[i+2] + 1), argv[i+3]);
+                                       if( argv[i+2][1] != '0' && atoi(&argv[i+2][1]) == 0 ) {
+                                               fprintf(stderr, "Error: Invalid balance to be set\n");
+                                               exit(1);
+                                       }
+                                       
+                                       Dispense_SetBalance(sock, argv[i+1], atoi(argv[i+2]+1), argv[i+3]);
                                }
                                else {
                                        // Alter balance
@@ -166,12 +212,42 @@ int main(int argc, char *argv[])
                                }
                        }
                        
+                       // Show user information
                        Dispense_ShowUser(sock, argv[i+1]);
                        
                        close(sock);
                        return 0;
                }
-               else if( strcmp(arg, "user") == 0 )
+               //
+               // `dispense give`
+               // - "Here, have some money."
+               if( strcmp(arg, "give") == 0 )
+               {
+                       if( i + 3 >= argc ) {
+                               fprintf(stderr, "`dispense give` takes three arguments\n");
+                               ShowUsage();
+                               return -1;
+                       }
+                       
+                       // argv[i+1]: Destination
+                       // argv[i+2]: Ammount
+                       // argv[i+3]: Reason
+                       
+                       // Connect to server
+                       sock = OpenConnection(gsDispenseServer, giDispensePort);
+                       if( sock < 0 )  return -1;
+                       
+                       // Authenticate
+                       if( Authenticate(sock) )
+                               return -1;
+                       
+                       Dispense_Give(sock, argv[i+1], atoi(argv[i+2]), argv[i+3]);
+                       return 0;
+               }
+               // 
+               // `dispense user`
+               // - User administration (Admin Only)
+               if( strcmp(arg, "user") == 0 )
                {
                        // Check argument count
                        if( i + 1 >= argc ) {
@@ -218,6 +294,31 @@ int main(int argc, char *argv[])
                        }
                        return 0;
                }
+               
+               // Donation!
+               if( strcmp(arg, "donate") == 0 )
+               {
+                       // Check argument count
+                       if( i + 2 >= argc ) {
+                               fprintf(stderr, "Error: `dispense donate` requires two arguments\n");
+                               ShowUsage();
+                               exit(1);
+                       }
+                       
+                       // Connect to server
+                       sock = OpenConnection(gsDispenseServer, giDispensePort);
+                       if( sock < 0 )  return -1;
+                       
+                       // Attempt authentication
+                       if( Authenticate(sock) )
+                               return -1;
+                       
+                       // Do donation
+                       Dispense_Donate(sock, atoi(argv[i+1]), argv[i+1]);
+                       
+                       return 0;
+               }
+               
                else {
                        // Item name / pattern
                        gsItemPattern = arg;
@@ -228,16 +329,98 @@ int main(int argc, char *argv[])
        // Connect to server
        sock = OpenConnection(gsDispenseServer, giDispensePort);
        if( sock < 0 )  return -1;
-       
-       // Authenticate
-       Authenticate(sock);
 
        // Get items
        PopulateItemList(sock);
        
+       // Disconnect from server
+       close(sock);
+       
        if( gsItemPattern )
        {
-               
+               regmatch_t matches[3];
+               // Door (hard coded)
+               if( strcmp(gsItemPattern, "door") == 0 )
+               {
+                       // Connect, Authenticate, dispense and close
+                       sock = OpenConnection(gsDispenseServer, giDispensePort);
+                       if( sock < 0 )  return -1;
+                       Authenticate(sock);
+                       DispenseItem(sock, "door", 0);
+                       close(sock);
+                       return 0;
+               }
+               // Item id (<type>:<num>)
+               else if( RunRegex(&gUserItemIdentRegex, gsItemPattern, 3, matches, NULL) == 0 )
+               {
+                       char    *ident;
+                        int    id;
+                       
+                       // Get and finish ident
+                       ident = gsItemPattern + matches[1].rm_so;
+                       gsItemPattern[matches[1].rm_eo] = '\0';
+                       // Get ID
+                       id = atoi( gsItemPattern + matches[2].rm_so );
+                       
+                       // Connect, Authenticate, dispense and close
+                       sock = OpenConnection(gsDispenseServer, giDispensePort);
+                       if( sock < 0 )  return -1;
+                       
+                       Dispense_ItemInfo(sock, ident, id);
+                       
+                       Authenticate(sock);
+                       DispenseItem(sock, ident, id);
+                       close(sock);
+                       return 0;
+               }
+               // Item number (6 = coke)
+               else if( strcmp(gsItemPattern, "0") == 0 || atoi(gsItemPattern) > 0 )
+               {
+                       i = atoi(gsItemPattern);
+               }
+               // Item prefix
+               else
+               {
+                        int    j;
+                        int    best = -1;
+                       for( i = 0; i < giNumItems; i ++ )
+                       {
+                               // Prefix match (with case-insensitive match)
+                               for( j = 0; gsItemPattern[j]; j ++ )
+                               {
+                                       if( gaItems[i].Desc[j] == gsItemPattern[j] )
+                                               continue;
+                                       if( tolower(gaItems[i].Desc[j]) == tolower(gsItemPattern[j]) )
+                                               continue;
+                                       break;
+                               }
+                               // Check if the prefix matched
+                               if( gsItemPattern[j] != '\0' )
+                                       continue;
+                               
+                               // Prefect match
+                               if( gaItems[i].Desc[j] == '\0' ) {
+                                       best = i;
+                                       break;
+                               }
+                               
+                               // Only one match allowed
+                               if( best == -1 ) {
+                                       best = i;
+                               }
+                               else {
+                                       // TODO: Allow ambiguous matches?
+                               }
+                       }
+                       
+                       if( best == -1 )
+                       {
+                               fprintf(stderr, "No item matches the passed string\n");
+                               return 1;
+                       }
+                       
+                       i = best;
+               }
        }
        else if( gbUseNCurses )
        {
@@ -245,8 +428,10 @@ int main(int argc, char *argv[])
        }
        else
        {
-               for( i = 0; i < giNumItems; i ++ ) {            
-                       printf("%2i %s\t%3i %s\n", i, gaItems[i].Ident, gaItems[i].Price, gaItems[i].Desc);
+               // Very basic dispense interface
+               for( i = 0; i < giNumItems; i ++ ) {
+                       printf("%2i %s:%i\t%3i %s\n", i, gaItems[i].Type, gaItems[i].ID,
+                               gaItems[i].Price, gaItems[i].Desc);
                }
                printf(" q Quit\n");
                for(;;)
@@ -274,11 +459,20 @@ int main(int argc, char *argv[])
                }
        }
        
+       
        // Check for a valid item ID
        if( i >= 0 )
-               DispenseItem(sock, i);
-
-       close(sock);
+       {
+               // Connect, Authenticate, dispense and close
+               sock = OpenConnection(gsDispenseServer, giDispensePort);
+               if( sock < 0 )  return -1;
+                       
+               Dispense_ItemInfo(sock, gaItems[i].Type, gaItems[i].ID);
+               
+               Authenticate(sock);
+               DispenseItem(sock, gaItems[i].Type, gaItems[i].ID);
+               close(sock);
+       }
 
        return 0;
 }
@@ -287,27 +481,40 @@ void ShowUsage(void)
 {
        printf(
                "Usage:\n"
-               "\tdispense\n"
-               "\t\tShow interactive list\n"
-               "\tdispense <item>\n"
-               "\t\tDispense named item\n"
-               "\tdispense give <user> <ammount> \"<reason>\"\n"
-               "\t\tGive some of your money away\n"
-               "\tdispense acct [<user>]\n"
-               "\t\tShow user balances\n"
-               "\tdispense acct <user> [+-=]<ammount> \"<reason>\"\n"
-               "\t\tAlter a account value (Coke members only)\n"
+               "  == Everyone ==\n"
+               "    dispense\n"
+               "        Show interactive list\n"
+               "    dispense <item>\n"
+               "        Dispense named item\n"
+               "    dispense give <user> <ammount> \"<reason>\"\n"
+               "        Give money to another user\n"
+               "    dispense donate <ammount> \"<reason>\"\n"
+               "        Donate to the club\n"
+               "  == Coke members == \n"
+               "    dispense acct [<user>]\n"
+               "        Show user balances\n"
+               "    dispense acct <user> [+-]<ammount> \"<reason>\"\n"
+               "        Alter a account value\n"
+               "  == Dispense administrators ==\n"
+               "    dispense acct <user> =<ammount> \"<reason>\"\n"
+               "        Set an account balance\n"
+               "    dispense user add <user>\n"
+               "        Create new coke account (Admins only)\n"
+               "    dispense user type <user> <flags>\n"
+               "        Alter a user's flags\n"
+               "        <flags> is a comma-separated list of user, coke, admin or disabled\n"
+               "        Flags are removed by preceding the name with '-' or '!'\n"
                "\n"
                "General Options:\n"
-               "\t-u <username>\n"
-               "\t\tSet a different user (Coke members only)\n"
-               "\t-h / -?\n"
-               "\t\tShow help text\n"
-               "\t-G\n"
-               "\t\tUse alternate GUI\n"
-               "\t-m <min balance>\n"
-               "\t-M <max balance>\n"
-               "\t\tSet the Maximum/Minimum balances shown in `dispense acct`\n"
+               "    -u <username>\n"
+               "        Set a different user (Coke members only)\n"
+               "    -h / -?\n"
+               "        Show help text\n"
+               "    -G\n"
+               "        Use alternate GUI\n"
+               "    -m <min balance>\n"
+               "    -M <max balance>\n"
+               "        Set the Maximum/Minimum balances shown in `dispense acct`\n"
                );
 }
 
@@ -588,16 +795,24 @@ int OpenConnection(const char *Host, int Port)
                return -1;
        }
        
-       #if USE_AUTOAUTH
+       if( geteuid() == 0 )
        {
+                int    i;
                struct sockaddr_in      localAddr;
                memset(&localAddr, 0, sizeof(localAddr));
                localAddr.sin_family = AF_INET; // IPv4
-               localAddr.sin_port = 1023;      // IPv4
-               // Attempt to bind to low port for autoauth
-               bind(sock, &localAddr, sizeof(localAddr));
+               
+               // Loop through all the top ports until one is avaliable
+               for( i = 1001; i < 1024; i ++)
+               {
+                       localAddr.sin_port = htons(i);  // IPv4
+                       // Attempt to bind to low port for autoauth
+                       if( bind(sock, (struct sockaddr*)&localAddr, sizeof(localAddr)) == 0 )
+                               break;
+               }
+               if( i == 1024 )
+                       printf("Warning: AUTOAUTH unavaliable\n");
        }
-       #endif
        
        if( connect(sock, (struct sockaddr *) &serverAddr, sizeof(serverAddr)) < 0 ) {
                fprintf(stderr, "Failed to connect to server\n");
@@ -634,11 +849,9 @@ int Authenticate(int Socket)
        responseCode = atoi(buf);
        switch( responseCode )
        {
-       
-       case 200:       // Authenticated, return :)
-               gbIsAuthenticated = 1;
+       case 200:       // Autoauth succeeded, return
                free(buf);
-               return 0;
+               break;
        
        case 401:       // Untrusted, attempt password authentication
                free(buf);
@@ -705,12 +918,9 @@ int Authenticate(int Socket)
                        return -1;
                }
                free(buf);
-               if( i < 3 ) {
-                       gbIsAuthenticated = 1;
-                       return 0;
-               }
-               else
+               if( i == 3 )
                        return 2;       // 2 = Bad Password
+               break;
        
        case 404:       // Bad Username
                fprintf(stderr, "Bad Username '%s'\n", pwd->pw_name);
@@ -723,6 +933,43 @@ int Authenticate(int Socket)
                free(buf);
                return -1;
        }
+       
+       // Set effective user
+       if( gsEffectiveUser ) {
+               sendf(Socket, "SETEUSER %s\n", gsEffectiveUser);
+               
+               buf = ReadLine(Socket);
+               responseCode = atoi(buf);
+               
+               switch(responseCode)
+               {
+               case 200:
+                       printf("Running as '%s' by '%s'\n", gsEffectiveUser, pwd->pw_name);
+                       break;
+               
+               case 403:
+                       printf("Only coke members can use `dispense -u`\n");
+                       free(buf);
+                       return -1;
+               
+               case 404:
+                       printf("Invalid user selected\n");
+                       free(buf);
+                       return -1;
+               
+               default:
+                       fprintf(stderr, "Unkown response code %i from server\n", responseCode);
+                       printf("%s\n", buf);
+                       free(buf);
+                       exit(-1);
+               }
+               
+               free(buf);
+       }
+       
+       gbIsAuthenticated = 1;
+       
+       return 0;
 }
 
 
@@ -779,7 +1026,7 @@ void PopulateItemList(int Socket)
        // Fetch item information
        for( i = 0; i < giNumItems; i ++ )
        {
-               regmatch_t      matches[6];
+               regmatch_t      matches[7];
                
                // Get item info
                buf = ReadLine(Socket);
@@ -790,13 +1037,14 @@ void PopulateItemList(int Socket)
                        exit(-1);
                }
                
-               RunRegex(&gItemRegex, buf, 6, matches, "Malformed server response");
+               RunRegex(&gItemRegex, buf, 7, matches, "Malformed server response");
                
                buf[ matches[3].rm_eo ] = '\0';
                
-               gaItems[i].Ident = strdup( buf + matches[3].rm_so );
-               gaItems[i].Price = atoi( buf + matches[4].rm_so );
-               gaItems[i].Desc = strdup( buf + matches[5].rm_so );
+               gaItems[i].Type = strdup( buf + matches[3].rm_so );
+               gaItems[i].ID = atoi( buf + matches[4].rm_so );
+               gaItems[i].Price = atoi( buf + matches[5].rm_so );
+               gaItems[i].Desc = strdup( buf + matches[6].rm_so );
                
                free(buf);
        }
@@ -815,19 +1063,74 @@ void PopulateItemList(int Socket)
        free(buf);
 }
 
+
+/**
+ * \brief Get information on an item
+ * \return Boolean Failure
+ */
+int Dispense_ItemInfo(int Socket, const char *Type, int ID)
+{
+        int    responseCode;
+       char    *buf;
+       regmatch_t matches[7];
+       char    *type, *desc;
+        int    id, price;
+       
+       // Dispense!
+       sendf(Socket, "ITEM_INFO %s:%i\n", Type, ID);
+       buf = ReadLine(Socket);
+       
+       responseCode = atoi(buf);
+       switch( responseCode )
+       {
+       case 202:
+               break;
+       
+       case 406:
+               printf("Bad item name\n");
+               free(buf);
+               return 1;
+       
+       default:
+               printf("Unknown response code %i ('%s')\n", responseCode, buf);
+               free(buf);
+               return -1;
+       }
+       
+               
+       RunRegex(&gItemRegex, buf, 7, matches, "Malformed server response");
+       
+       buf[ matches[3].rm_eo ] = '\0';
+       
+       type = buf + matches[3].rm_so;  buf[matches[3].rm_eo] = '\0';
+       id = atoi( buf + matches[4].rm_so );
+       price = atoi( buf + matches[5].rm_so );
+       desc = buf + matches[6].rm_so;  buf[matches[6].rm_eo] = '\0';
+       
+       printf("%8s:%-2i %2i.%02i %s\n", type, id, price/100, price%100, desc);
+       
+       free(buf);
+       
+       return 0;
+}
+
 /**
  * \brief Dispense an item
  * \return Boolean Failure
  */
-int DispenseItem(int Socket, int ItemID)
+int DispenseItem(int Socket, const char *Type, int ID)
 {
         int    ret, responseCode;
        char    *buf;
        
-       if( ItemID < 0 || ItemID > giNumItems ) return -1;
+       // Check for a dry run
+       if( gbDryRun ) {
+               printf("Dry Run - No action\n");
+               return 0;
+       }
        
        // Dispense!
-       sendf(Socket, "DISPENSE %s\n", gaItems[ItemID].Ident);
+       sendf(Socket, "DISPENSE %s:%i\n", Type, ID);
        buf = ReadLine(Socket);
        
        responseCode = atoi(buf);
@@ -846,7 +1149,7 @@ int DispenseItem(int Socket, int ItemID)
                ret = 1;
                break;
        case 406:
-               printf("Bad item name, bug report\n");
+               printf("Bad item name\n");
                ret = 1;
                break;
        case 500:
@@ -875,6 +1178,12 @@ int Dispense_AlterBalance(int Socket, const char *Username, int Ammount, const c
        char    *buf;
         int    responseCode;
        
+       // Check for a dry run
+       if( gbDryRun ) {
+               printf("Dry Run - No action\n");
+               return 0;
+       }
+       
        sendf(Socket, "ADD %s %i %s\n", Username, Ammount, Reason);
        buf = ReadLine(Socket);
        
@@ -884,6 +1193,9 @@ int Dispense_AlterBalance(int Socket, const char *Username, int Ammount, const c
        switch(responseCode)
        {
        case 200:       return 0;       // OK
+       case 402:
+               fprintf(stderr, "Insufficient balance\n");
+               return 1;
        case 403:       // Not in coke
                fprintf(stderr, "You are not in coke (sucker)\n");
                return 1;
@@ -899,14 +1211,21 @@ int Dispense_AlterBalance(int Socket, const char *Username, int Ammount, const c
 }
 
 /**
- * \brief Alter a user's balance
+ * \brief Set a user's balance
+ * \note Only avaliable to dispense admins
  */
-int Dispense_SetBalance(int Socket, const char *Username, int Ammount, const char *Reason)
+int Dispense_SetBalance(int Socket, const char *Username, int Balance, const char *Reason)
 {
        char    *buf;
         int    responseCode;
        
-       sendf(Socket, "SET %s %i %s\n", Username, Ammount, Reason);
+       // Check for a dry run
+       if( gbDryRun ) {
+               printf("Dry Run - No action\n");
+               return 0;
+       }
+       
+       sendf(Socket, "SET %s %i %s\n", Username, Balance, Reason);
        buf = ReadLine(Socket);
        
        responseCode = atoi(buf);
@@ -916,11 +1235,110 @@ int Dispense_SetBalance(int Socket, const char *Username, int Ammount, const cha
        {
        case 200:       return 0;       // OK
        case 403:       // Not in coke
-               fprintf(stderr, "You are not in coke (sucker)\n");
+               fprintf(stderr, "You are not an admin\n");
+               return 1;
+       case 404:       // Unknown user
+               fprintf(stderr, "Unknown user '%s'\n", Username);
+               return 2;
+       default:
+               fprintf(stderr, "Unknown response code %i\n", responseCode);
+               return -1;
+       }
+       
+       return -1;
+}
+
+/**
+ * \brief Give money to another user
+ */
+int Dispense_Give(int Socket, const char *Username, int Ammount, const char *Reason)
+{
+       char    *buf;
+        int    responseCode;
+       
+       if( Ammount < 0 ) {
+               printf("Sorry, you can only give, you can't take.\n");
+               return -1;
+       }
+       
+       // Fast return on zero
+       if( Ammount == 0 ) {
+               printf("Are you actually going to give any?\n");
+               return 0;
+       }
+       
+       // Check for a dry run
+       if( gbDryRun ) {
+               printf("Dry Run - No action\n");
+               return 0;
+       }
+       
+       sendf(Socket, "GIVE %s %i %s\n", Username, Ammount, Reason);
+       buf = ReadLine(Socket);
+       
+       responseCode = atoi(buf);
+       free(buf);
+       
+       switch(responseCode)
+       {
+       case 200:       return 0;       // OK
+       
+       case 402:       
+               fprintf(stderr, "Insufficient balance\n");
                return 1;
+       
        case 404:       // Unknown user
                fprintf(stderr, "Unknown user '%s'\n", Username);
                return 2;
+       
+       default:
+               fprintf(stderr, "Unknown response code %i\n", responseCode);
+               return -1;
+       }
+       
+       return -1;
+}
+
+
+/**
+ * \brief Donate money to the club
+ */
+int Dispense_Donate(int Socket, int Ammount, const char *Reason)
+{
+       char    *buf;
+        int    responseCode;
+       
+       if( Ammount < 0 ) {
+               printf("Sorry, you can only give, you can't take.\n");
+               return -1;
+       }
+       
+       // Fast return on zero
+       if( Ammount == 0 ) {
+               printf("Are you actually going to give any?\n");
+               return 0;
+       }
+       
+       // Check for a dry run
+       if( gbDryRun ) {
+               printf("Dry Run - No action\n");
+               return 0;
+       }
+       
+       sendf(Socket, "DONATE %i %s\n", Ammount, Reason);
+       buf = ReadLine(Socket);
+       
+       responseCode = atoi(buf);
+       free(buf);
+       
+       switch(responseCode)
+       {
+       case 200:       return 0;       // OK
+       
+       case 402:       
+               fprintf(stderr, "Insufficient balance\n");
+               return 1;
+       
        default:
                fprintf(stderr, "Unknown response code %i\n", responseCode);
                return -1;
@@ -929,6 +1347,9 @@ int Dispense_SetBalance(int Socket, const char *Username, int Ammount, const cha
        return -1;
 }
 
+/**
+ * \brief Enumerate users
+ */
 int Dispense_EnumUsers(int Socket)
 {
        char    *buf;
@@ -938,15 +1359,15 @@ int Dispense_EnumUsers(int Socket)
        
        if( giMinimumBalance != INT_MIN ) {
                if( giMaximumBalance != INT_MAX ) {
-                       sendf(Socket, "ENUM_USERS %i %i\n", giMinimumBalance, giMaximumBalance);
+                       sendf(Socket, "ENUM_USERS min_balance:%i max_balance:%i\n", giMinimumBalance, giMaximumBalance);
                }
                else {
-                       sendf(Socket, "ENUM_USERS %i\n", giMinimumBalance);
+                       sendf(Socket, "ENUM_USERS min_balance:%i\n", giMinimumBalance);
                }
        }
        else {
                if( giMaximumBalance != INT_MAX ) {
-                       sendf(Socket, "ENUM_USERS %i\n", giMaximumBalance);
+                       sendf(Socket, "ENUM_USERS max_balance:%i\n", giMaximumBalance);
                }
                else {
                        sendf(Socket, "ENUM_USERS\n");
@@ -1050,7 +1471,7 @@ void _PrintUserLine(const char *Line)
                flags[flagsLen] = '\0';
                
                bal = atoi(Line + matches[4].rm_so);
-               printf("%-15s: $%4i.%02i (%s)\n", username, bal/100, bal%100, flags);
+               printf("%-15s: $%4i.%02i (%s)\n", username, bal/100, abs(bal)%100, flags);
        }
 }
 
@@ -1059,6 +1480,12 @@ int Dispense_AddUser(int Socket, const char *Username)
        char    *buf;
         int    responseCode, ret;
        
+       // Check for a dry run
+       if( gbDryRun ) {
+               printf("Dry Run - No action\n");
+               return 0;
+       }
+       
        sendf(Socket, "USER_ADD %s\n", Username);
        
        buf = ReadLine(Socket);
@@ -1097,6 +1524,12 @@ int Dispense_SetUserType(int Socket, const char *Username, const char *TypeStrin
        char    *buf;
         int    responseCode, ret;
        
+       // Check for a dry run
+       if( gbDryRun ) {
+               printf("Dry Run - No action\n");
+               return 0;
+       }
+       
        // TODO: Pre-validate the string
        
        sendf(Socket, "USER_FLAGS %s %s\n", Username, TypeString);
@@ -1237,7 +1670,7 @@ int RunRegex(regex_t *regex, const char *string, int nMatches, regmatch_t *match
         int    ret;
        
        ret = regexec(regex, string, nMatches, matches, 0);
-       if( ret ) {
+       if( ret && errorMessage ) {
                size_t  len = regerror(ret, regex, NULL, 0);
                char    errorStr[len];
                regerror(ret, regex, errorStr, len);

UCC git Repository :: git.ucc.asn.au