void Server_Cmd_USERFLAGS(tClient *Client, char *Args);
// --- Helpers ---
void Debug(tClient *Client, const char *Format, ...);
- int Server_int_ParseFlags(tClient *Client, const char *Str, int *Mask, int *Value);
int sendf(int Socket, const char *Format, ...);
+ int Server_int_ParseArgs(int bUseLongArg, char *ArgStr, ...);
+ int Server_int_ParseFlags(tClient *Client, const char *Str, int *Mask, int *Value);
// === CONSTANTS ===
// - Commands
#define NUM_COMMANDS ((int)(sizeof(gaServer_Commands)/sizeof(gaServer_Commands[0])))
// === GLOBALS ===
- int giServer_Port = 1020;
+ int giServer_Port = 11020;
int giServer_NextClientID = 1;
int giServer_Socket;
printf("Listening on 0.0.0.0:%i\n", giServer_Port);
+ // write pidfile
+// {
+// FILE *fp = fopen("/var/run/dispsrv.pid", "w");
+// fprintf(fp, "%i", getpid());
+// fclose(fp);
+// }
+
for(;;)
{
uint len = sizeof(client_addr);
switch( ntohl( client_addr.sin_addr.s_addr ) )
{
case 0x7F000001: // 127.0.0.1 localhost
- //case 0x825E0D00: // 130.95.13.0
- case 0x825E0D07: // 130.95.13.7 motsugo
- case 0x825E0D12: // 130.95.13.18 mussel
- case 0x825E0D17: // 130.95.13.23 martello
+ // case 0x825F0D00: // 130.95.13.0
+ case 0x825F0D07: // 130.95.13.7 motsugo
+ case 0x825F0D11: // 130.95.13.17 mermaid
+ case 0x825F0D12: // 130.95.13.18 mussel
+ case 0x825F0D17: // 130.95.13.23 martello
+ case 0x825F0D42: // 130.95.13.66 heathred
bTrusted = 1;
break;
default:
*/
void Server_ParseClientCommand(tClient *Client, char *CommandString)
{
- char *space, *args;
+ char *command, *args;
int i;
- #if 0
- char **argList;
- int numArgs = 0;
- #endif
- // Split at first space
- space = strchr(CommandString, ' ');
- if(space == NULL) {
- args = NULL;
- }
- else {
- *space = '\0';
- args = space + 1;
- while( *space == ' ' ) space ++;
-
- #if 0
- // Count arguments
- numArgs = 1;
- for( i = 0; args[i]; )
- {
- while( CommandString[i] != ' ' ) {
- if( CommandString[i] == '"' ) {
- while( !(CommandString[i] != '\\' CommandString[i+1] == '"' ) )
- i ++;
- i ++;
- }
- i ++;
- }
- numArgs ++;
- while( CommandString[i] == ' ' ) i ++;
- }
- #endif
+ if( giDebugLevel >= 2 )
+ Debug(Client, "Server_ParseClientCommand: (CommandString = '%s')", CommandString);
+
+ if( Server_int_ParseArgs(1, CommandString, &command, &args, NULL) )
+ {
+// printf("command=%s, args=%s\n", command, args);
+ // Is this an error? (just ignore for now)
+ //args = "";
}
// Find command
for( i = 0; i < NUM_COMMANDS; i++ )
{
- if(strcmp(CommandString, gaServer_Commands[i].Name) == 0) {
+ if(strcmp(command, gaServer_Commands[i].Name) == 0) {
+ if( giDebugLevel >= 2 )
+ Debug(Client, "CMD %s - \"%s\"", command, args);
gaServer_Commands[i].Function(Client, args);
return ;
}
*/
void Server_Cmd_USER(tClient *Client, char *Args)
{
- char *space = strchr(Args, ' ');
- if(space) *space = '\0'; // Remove characters after the ' '
+ char *username;
+
+ if( Server_int_ParseArgs(0, Args, &username, NULL) )
+ {
+ sendf(Client->Socket, "407 USER takes 1 argument\n");
+ return ;
+ }
// Debug!
if( giDebugLevel )
- Debug(Client, "Authenticating as '%s'", Args);
+ Debug(Client, "Authenticating as '%s'", username);
// Save username
if(Client->Username)
free(Client->Username);
- Client->Username = strdup(Args);
+ Client->Username = strdup(username);
#if USE_SALT
// Create a salt (that changes if the username is changed)
*/
void Server_Cmd_PASS(tClient *Client, char *Args)
{
- char *space = strchr(Args, ' ');
- if(space) *space = '\0'; // Remove characters after the ' '
+ char *passhash;
+ int flags;
+
+ if( Server_int_ParseArgs(0, Args, &passhash, NULL) )
+ {
+ sendf(Client->Socket, "407 PASS takes 1 argument\n");
+ return ;
+ }
// Pass on to cokebank
- Client->UID = Bank_GetUserAuth(Client->Salt, Client->Username, Args);
+ Client->UID = Bank_GetUserAuth(Client->Salt, Client->Username, passhash);
+
+ if( Client->UID == -1 ) {
+ sendf(Client->Socket, "401 Auth Failure\n");
+ return ;
+ }
- if( Client->UID != -1 ) {
- Client->bIsAuthed = 1;
- sendf(Client->Socket, "200 Auth OK\n");
+ flags = Bank_GetFlags(Client->UID);
+ if( flags & USER_FLAG_DISABLED ) {
+ Client->UID = -1;
+ sendf(Client->Socket, "403 Account Disabled\n");
+ return ;
+ }
+ if( flags & USER_FLAG_INTERNAL ) {
+ Client->UID = -1;
+ sendf(Client->Socket, "403 Internal account\n");
return ;
}
- sendf(Client->Socket, "401 Auth Failure\n");
+ Client->bIsAuthed = 1;
+ sendf(Client->Socket, "200 Auth OK\n");
}
/**
*/
void Server_Cmd_AUTOAUTH(tClient *Client, char *Args)
{
- char *space = strchr(Args, ' ');
- if(space) *space = '\0'; // Remove characters after the ' '
+ char *username;
+ int userflags;
+
+ if( Server_int_ParseArgs(0, Args, &username, NULL) )
+ {
+ sendf(Client->Socket, "407 AUTOAUTH takes 1 argument\n");
+ return ;
+ }
// Check if trusted
if( !Client->bIsTrusted ) {
}
// Get UID
- Client->UID = Bank_GetAcctByName( Args );
+ Client->UID = Bank_GetAcctByName( username );
if( Client->UID < 0 ) {
if(giDebugLevel)
- Debug(Client, "Unknown user '%s'", Args);
- sendf(Client->Socket, "401 Auth Failure\n");
+ Debug(Client, "Unknown user '%s'", username);
+ sendf(Client->Socket, "403 Auth Failure\n");
return ;
}
+ userflags = Bank_GetFlags(Client->UID);
// You can't be an internal account
- if( Bank_GetFlags(Client->UID) & USER_FLAG_INTERNAL ) {
+ if( userflags & USER_FLAG_INTERNAL ) {
+ if(giDebugLevel)
+ Debug(Client, "Autoauth as '%s', not allowed", username);
Client->UID = -1;
- sendf(Client->Socket, "401 Auth Failure\n");
+ sendf(Client->Socket, "403 Account is internal\n");
+ return ;
+ }
+
+ // Disabled accounts
+ if( userflags & USER_FLAG_DISABLED ) {
+ Client->UID = -1;
+ sendf(Client->Socket, "403 Account disabled\n");
return ;
}
Client->bIsAuthed = 1;
if(giDebugLevel)
- Debug(Client, "Auto authenticated as '%s' (%i)", Args, Client->UID);
+ Debug(Client, "Auto authenticated as '%s' (%i)", username, Client->UID);
sendf(Client->Socket, "200 Auth OK\n");
}
*/
void Server_Cmd_SETEUSER(tClient *Client, char *Args)
{
- char *space;
+ char *username;
+ int eUserFlags, userFlags;
- space = strchr(Args, ' ');
-
- if(space) *space = '\0';
+ if( Server_int_ParseArgs(0, Args, &username, NULL) )
+ {
+ sendf(Client->Socket, "407 SETEUSER takes 1 argument\n");
+ return ;
+ }
if( !strlen(Args) ) {
sendf(Client->Socket, "407 SETEUSER expects an argument\n");
}
// Check user permissions
- if( !(Bank_GetFlags(Client->UID) & (USER_FLAG_COKE|USER_FLAG_ADMIN)) ) {
+ userFlags = Bank_GetFlags(Client->UID);
+ if( !(userFlags & (USER_FLAG_COKE|USER_FLAG_ADMIN)) ) {
sendf(Client->Socket, "403 Not in coke\n");
return ;
}
// Set id
- Client->EffectiveUID = Bank_GetAcctByName(Args);
+ Client->EffectiveUID = Bank_GetAcctByName(username);
if( Client->EffectiveUID == -1 ) {
sendf(Client->Socket, "404 User not found\n");
return ;
}
// You can't be an internal account
- if( Bank_GetFlags(Client->EffectiveUID) & USER_FLAG_INTERNAL ) {
+ eUserFlags = Bank_GetFlags(Client->EffectiveUID);
+ if( eUserFlags & USER_FLAG_INTERNAL ) {
Client->EffectiveUID = -1;
sendf(Client->Socket, "404 User not found\n");
return ;
}
+ // Disabled only avaliable to admins
+ if( (eUserFlags & USER_FLAG_DISABLED) && !(userFlags & USER_FLAG_ADMIN) ) {
+ Client->EffectiveUID = -1;
+ sendf(Client->Socket, "403 Account disabled\n");
+ return ;
+ }
sendf(Client->Socket, "200 User set\n");
}
+/**
+ * \brief Send an item status to the client
+ * \param Client Who to?
+ * \param Item Item to send
+ */
+void Server_int_SendItem(tClient *Client, tItem *Item)
+{
+ char *status = "avail";
+
+ if( Item->Handler->CanDispense )
+ {
+ switch(Item->Handler->CanDispense(Client->UID, Item->ID))
+ {
+ case 0: status = "avail"; break;
+ case 1: status = "sold"; break;
+ default:
+ case -1: status = "error"; break;
+ }
+ }
+
+ sendf(Client->Socket,
+ "202 Item %s:%i %s %i %s\n",
+ Item->Handler->Name, Item->ID, status, Item->Price, Item->Name
+ );
+}
+
/**
* \brief Enumerate the items that the server knows about
*/
for( i = 0; i < giNumItems; i ++ ) {
if( gaItems[i].bHidden ) continue;
- sendf(Client->Socket,
- "202 Item %s:%i %i %s\n",
- gaItems[i].Handler->Name, gaItems[i].ID, gaItems[i].Price, gaItems[i].Name
- );
+ Server_int_SendItem( Client, &gaItems[i] );
}
sendf(Client->Socket, "200 List end\n");
*/
void Server_Cmd_ITEMINFO(tClient *Client, char *Args)
{
- tItem *item = _GetItemFromString(Args);
+ tItem *item;
+ char *itemname;
+
+ if( Server_int_ParseArgs(0, Args, &itemname, NULL) ) {
+ sendf(Client->Socket, "407 ITEMINFO takes 1 argument\n");
+ return ;
+ }
+ item = _GetItemFromString(Args);
if( !item ) {
sendf(Client->Socket, "406 Bad Item ID\n");
return ;
}
- sendf(Client->Socket,
- "202 Item %s:%i %i %s\n",
- item->Handler->Name, item->ID, item->Price, item->Name
- );
+ Server_int_SendItem( Client, item );
}
void Server_Cmd_DISPENSE(tClient *Client, char *Args)
tItem *item;
int ret;
int uid;
+ char *itemname;
+
+ if( Server_int_ParseArgs(0, Args, &itemname, NULL) ) {
+ sendf(Client->Socket, "407 DISPENSE takes only 1 argument\n");
+ return ;
+ }
if( !Client->bIsAuthed ) {
sendf(Client->Socket, "401 Not Authenticated\n");
return ;
}
- item = _GetItemFromString(Args);
+ item = _GetItemFromString(itemname);
if( !item ) {
sendf(Client->Socket, "406 Bad Item ID\n");
return ;
int uid, iAmmount;
int thisUid;
- if( !Client->bIsAuthed ) {
- sendf(Client->Socket, "401 Not Authenticated\n");
- return ;
- }
-
- recipient = Args;
-
- ammount = strchr(Args, ' ');
- if( !ammount ) {
- sendf(Client->Socket, "407 Invalid Argument, expected 3 parameters, 1 encountered\n");
+ // Parse arguments
+ if( Server_int_ParseArgs(1, Args, &recipient, &ammount, &reason, NULL) ) {
+ sendf(Client->Socket, "407 GIVE takes only 3 arguments\n");
return ;
}
- *ammount = '\0';
- ammount ++;
-
- reason = strchr(ammount, ' ');
- if( !reason ) {
- sendf(Client->Socket, "407 Invalid Argument, expected 3 parameters, 2 encountered\n");
+ // Check for authed
+ if( !Client->bIsAuthed ) {
+ sendf(Client->Socket, "401 Not Authenticated\n");
return ;
}
- *reason = '\0';
- reason ++;
// Get recipient
uid = Bank_GetAcctByName(recipient);
}
// You can't alter an internal account
- if( Bank_GetFlags(uid) & USER_FLAG_INTERNAL ) {
- sendf(Client->Socket, "404 Invalid target user\n");
- return ;
- }
+// if( Bank_GetFlags(uid) & USER_FLAG_INTERNAL ) {
+// sendf(Client->Socket, "404 Invalid target user\n");
+// return ;
+// }
// Parse ammount
iAmmount = atoi(ammount);
int iAmmount;
int thisUid;
- if( !Client->bIsAuthed ) {
- sendf(Client->Socket, "401 Not Authenticated\n");
- return ;
- }
-
- ammount = Args;
-
- // Get the start of the reason
- reason = strchr(Args, ' ');
- if( !ammount ) {
- sendf(Client->Socket, "407 Invalid Argument, expected 2 parameters, 1 encountered\n");
+ // Parse arguments
+ if( Server_int_ParseArgs(1, Args, &ammount, &reason, NULL) ) {
+ sendf(Client->Socket, "407 DONATE takes 2 arguments\n");
return ;
}
- *reason = '\0';
- reason ++;
- // Check the end of the reason
- if( strchr(reason, ' ') ) {
- sendf(Client->Socket, "407 Invalid Argument, expected 2 parameters, more encountered\n");
+ if( !Client->bIsAuthed ) {
+ sendf(Client->Socket, "401 Not Authenticated\n");
return ;
}
char *user, *ammount, *reason;
int uid, iAmmount;
- if( !Client->bIsAuthed ) {
- sendf(Client->Socket, "401 Not Authenticated\n");
- return ;
- }
-
- user = Args;
-
- ammount = strchr(Args, ' ');
- if( !ammount ) {
- sendf(Client->Socket, "407 Invalid Argument, expected 3 parameters, 1 encountered\n");
+ // Parse arguments
+ if( Server_int_ParseArgs(1, Args, &user, &ammount, &reason, NULL) ) {
+ sendf(Client->Socket, "407 ADD takes 3 arguments\n");
return ;
}
- *ammount = '\0';
- ammount ++;
-
- reason = strchr(ammount, ' ');
- if( !reason ) {
- sendf(Client->Socket, "407 Invalid Argument, expected 3 parameters, 2 encountered\n");
+
+ if( !Client->bIsAuthed ) {
+ sendf(Client->Socket, "401 Not Authenticated\n");
return ;
}
- *reason = '\0';
- reason ++;
// Check user permissions
if( !(Bank_GetFlags(Client->UID) & (USER_FLAG_COKE|USER_FLAG_ADMIN)) ) {
char *user, *ammount, *reason;
int uid, iAmmount;
- if( !Client->bIsAuthed ) {
- sendf(Client->Socket, "401 Not Authenticated\n");
- return ;
- }
-
- user = Args;
-
- ammount = strchr(Args, ' ');
- if( !ammount ) {
- sendf(Client->Socket, "407 Invalid Argument, expected 3 parameters, 1 encountered\n");
+ // Parse arguments
+ if( Server_int_ParseArgs(1, Args, &user, &ammount, &reason, NULL) ) {
+ sendf(Client->Socket, "407 SET takes 3 arguments\n");
return ;
}
- *ammount = '\0';
- ammount ++;
-
- reason = strchr(ammount, ' ');
- if( !reason ) {
- sendf(Client->Socket, "407 Invalid Argument, expected 3 parameters, 2 encountered\n");
+
+ if( !Client->bIsAuthed ) {
+ sendf(Client->Socket, "401 Not Authenticated\n");
return ;
}
- *reason = '\0';
- reason ++;
// Check user permissions
if( !(Bank_GetFlags(Client->UID) & USER_FLAG_ADMIN) ) {
do
{
type = space;
+ while(*type == ' ') type ++;
// Get next space
space = strchr(space, ' ');
if(space) *space = '\0';
void Server_Cmd_USERINFO(tClient *Client, char *Args)
{
int uid;
- char *user = Args;
- char *space;
+ char *user;
- space = strchr(user, ' ');
- if(space) *space = '\0';
+ // Parse arguments
+ if( Server_int_ParseArgs(0, Args, &user, NULL) ) {
+ sendf(Client->Socket, "407 USER_INFO takes 1 argument\n");
+ return ;
+ }
if( giDebugLevel ) Debug(Client, "User Info '%s'", user);
void Server_Cmd_USERADD(tClient *Client, char *Args)
{
- char *username, *space;
+ char *username;
+
+ // Parse arguments
+ if( Server_int_ParseArgs(0, Args, &username, NULL) ) {
+ sendf(Client->Socket, "407 USER_ADD takes 1 argument\n");
+ return ;
+ }
// Check permissions
if( !(Bank_GetFlags(Client->UID) & USER_FLAG_ADMIN) ) {
return ;
}
- // Read arguments
- username = Args;
- while( *username == ' ' ) username ++;
- space = strchr(username, ' ');
- if(space) *space = '\0';
-
// Try to create user
if( Bank_CreateAcct(username) == -1 ) {
sendf(Client->Socket, "404 User exists\n");
void Server_Cmd_USERFLAGS(tClient *Client, char *Args)
{
char *username, *flags;
- char *space;
int mask=0, value=0;
int uid;
- // Check permissions
- if( !(Bank_GetFlags(Client->UID) & USER_FLAG_ADMIN) ) {
- sendf(Client->Socket, "403 Not a coke admin\n");
+ // Parse arguments
+ if( Server_int_ParseArgs(0, Args, &username, &flags, NULL) ) {
+ sendf(Client->Socket, "407 USER_FLAGS takes 2 arguments\n");
return ;
}
- // Read arguments
- // - Username
- username = Args;
- while( *username == ' ' ) username ++;
- space = strchr(username, ' ');
- if(!space) {
- sendf(Client->Socket, "407 USER_FLAGS requires 2 arguments, 1 given\n");
+ // Check permissions
+ if( !(Bank_GetFlags(Client->UID) & USER_FLAG_ADMIN) ) {
+ sendf(Client->Socket, "403 Not a coke admin\n");
return ;
}
- *space = '\0';
- // - Flags
- flags = space + 1;
- while( *flags == ' ' ) flags ++;
- space = strchr(flags, ' ');
- if(space) *space = '\0';
// Get UID
uid = Bank_GetAcctByName(username);
}
}
+// Takes a series of char *'s in
+/**
+ * \brief Parse space-separated entries into
+ */
+int Server_int_ParseArgs(int bUseLongLast, char *ArgStr, ...)
+{
+ va_list args;
+ char savedChar;
+ char **dest;
+ va_start(args, ArgStr);
+
+ // Check for null
+ if( !ArgStr )
+ {
+ while( (dest = va_arg(args, char **)) )
+ *dest = NULL;
+ va_end(args);
+ return 1;
+ }
+
+ savedChar = *ArgStr;
+
+ while( (dest = va_arg(args, char **)) )
+ {
+ // Trim leading spaces
+ while( *ArgStr == ' ' || *ArgStr == '\t' )
+ ArgStr ++;
+
+ // ... oops, not enough arguments
+ if( *ArgStr == '\0' )
+ {
+ // NULL unset arguments
+ do {
+ *dest = NULL;
+ } while( (dest = va_arg(args, char **)) );
+ va_end(args);
+ return -1;
+ }
+
+ if( *ArgStr == '"' )
+ {
+ ArgStr ++;
+ *dest = ArgStr;
+ // Read until quote
+ while( *ArgStr && *ArgStr != '"' )
+ ArgStr ++;
+ }
+ else
+ {
+ // Set destination
+ *dest = ArgStr;
+ // Read until a space
+ while( *ArgStr && *ArgStr != ' ' && *ArgStr != '\t' )
+ ArgStr ++;
+ }
+ savedChar = *ArgStr; // savedChar is used to un-mangle the last string
+ *ArgStr = '\0';
+ ArgStr ++;
+ }
+ va_end(args);
+
+ // Oops, extra arguments, and greedy not set
+ if( (savedChar == ' ' || savedChar == '\t') && !bUseLongLast ) {
+ return -1;
+ }
+
+ // Un-mangle last
+ if(bUseLongLast) {
+ ArgStr --;
+ *ArgStr = savedChar;
+ }
+
+ return 0; // Success!
+}
+
int Server_int_ParseFlags(tClient *Client, const char *Str, int *Mask, int *Value)
{
struct {
git.ucc.asn.au / tpg / opendispense2.git / blobdiff
UCC git Repository :: git.ucc.asn.au